From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by mx.groups.io with SMTP id smtpd.web10.561.1594658236751727737 for ; Mon, 13 Jul 2020 09:37:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=dyq7OUN6; spf=pass (domain: 9elements.com, ip: 209.85.218.65, mailfrom: marcello.bauer@9elements.com) Received: by mail-ej1-f65.google.com with SMTP id p20so17912071ejd.13 for ; Mon, 13 Jul 2020 09:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JED/Pcris87ofgE99R0KJo2nz/djnJCVLEFSAeJhGQY=; b=dyq7OUN6RjhKan0XvgvWENGEzKGPojf48wrrxw9jotKp2FFupx3j0jOdtQ/EgZTsB5 qFHaxNQFsjE5aR2GzGTF3sZ+OjPwF1jVEqjxLCTpE2HHxKO04lIZT9xLOU39046/gP4n bx4p5+2Dcrl16BtrppqfMNK8X3DU1Y0FXfn6d23z7tEjv5cU6ajsqYS5wBxc7kqjsv21 zuUU4JAK54gIyuVvFXZ9FbOYKLOVekQuRCvzeUryqhd/IG9HWBAzYh44v8YVEr6VPGDn A77TYuKi3B2/S7mfly1cc2jb567c0IpaJo7e1DtawamqUAp1Tobw5A4TQW8NOtFmVwT7 yvlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JED/Pcris87ofgE99R0KJo2nz/djnJCVLEFSAeJhGQY=; b=NI8lmUVjDhC21HBPfTZWI7SHlhwp6IZM0jvd0TkAUO8n6bmMh7z68o0sO3xWyAhaVM qmKNQM6HS8rL2FyCQXdy5QQl89MaoxNR0G+jExv/iaPYmUL8QX7Lxleib01PpCR2wdAw ozlqYht7O2U6CDRrN2/v5oDx4mFiD0gOUmcJorbwAeHWGe5erL60MT7W0bHNmMnc7B9L 1/68O388iy6omIynuQooIyFh0nP881S6pTGj2EPtIkm92Gspxosfkv59bej+HKe/IcMb 7AzBg4Ma47ZSZMsuTBs84+hRfXdcyh2gqxzXtvvXnVAFQ3jQJCZw3iNQDovOAP0al7AG TJaQ== X-Gm-Message-State: AOAM530cSCV5iRitAis5lbZb68D6z6JC+KI4YQmWZ5Ke644/N25e8c+b Io3bki5atuqlmHXCwvqexWSflGKPWpg= X-Google-Smtp-Source: ABdhPJwQUVySCmw6efPtrp6w/M3P8tuxUluE+gmShmYCje7NnotZzawGh15hviQ7A2r2lwNSFcd7MA== X-Received: by 2002:a17:906:4e87:: with SMTP id v7mr575899eju.242.1594658235066; Mon, 13 Jul 2020 09:37:15 -0700 (PDT) Return-Path: Received: from T580.dut.n1ce.space ([2a02:908:e851:d750:f570:655a:1f30:429f]) by smtp.gmail.com with ESMTPSA id mf24sm10223063ejb.58.2020.07.13.09.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 09:37:14 -0700 (PDT) From: "Marcello Sylvester Bauer" To: devel@edk2.groups.io Cc: Patrick Rudolph , Christian Walter , Maurice Ma , Nate DeSimone , Star Zeng Subject: [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults Date: Mon, 13 Jul 2020 18:37:11 +0200 Message-Id: <20200713163711.7762-2-marcello.bauer@9elements.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200713163711.7762-1-marcello.bauer@9elements.com> References: <20200713163711.7762-1-marcello.bauer@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Patrick Rudolph The BaseSerialPortLib16550 does fallback to a fixed address UART defined by PcdSerialRegisterBase and does not initialize if it is zero. Do not assume a serial port at 0x3F8, otherwise it could cause errors during initialisation of a non-existent serial port on non legacy platforms. Signed-off-by: Patrick Rudolph Signed-off-by: Marcello Sylvester Bauer Cc: Patrick Rudolph Cc: Christian Walter Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng --- UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 +- UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPay= loadPkgIa32.dsc index 0efcfa8fb2f4..0d8854810700 100644 --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc @@ -306,7 +306,7 @@ [PcdsPatchableInModule.common] # The following parameters are set by Library/PlatformHookLib=0D #=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE=0D - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8=0D + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1=0D =0D diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc b/UefiPayloadPkg/Uefi= PayloadPkgIa32X64.dsc index d645d233cd08..34640b1fc1da 100644 --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc @@ -307,7 +307,7 @@ [PcdsPatchableInModule.common] # The following parameters are set by Library/PlatformHookLib=0D #=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|FALSE=0D - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f8=0D + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate|$(BAUD_RATE)=0D gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride|1=0D =0D --=20 2.27.0