From: "Marcello Sylvester Bauer" <marcello.bauer@9elements.com>
To: devel@edk2.groups.io
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
Christian Walter <christian.walter@9elements.com>,
Maurice Ma <maurice.ma@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Star Zeng <star.zeng@intel.com>
Subject: [PATCH v1 1/2] MdeModulePkg: Fix OptionROM scanning
Date: Mon, 13 Jul 2020 18:39:43 +0200 [thread overview]
Message-ID: <20200713163944.9893-2-marcello.bauer@9elements.com> (raw)
In-Reply-To: <20200713163944.9893-1-marcello.bauer@9elements.com>
From: Patrick Rudolph <patrick.rudolph@9elements.com>
The Option ROM scanner can't work as enumeration was done by the
first stage bootloader. Running it will disable the ability of the
PCIPlatform code to scan for ROMs.
Required for the following patch that enables custom Option ROM
scanning using gPciPlatformProtocol.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: Christian Walter <christian.walter@9elements.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
index 6c68a97d4e46..7420f0079f7d 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
@@ -2530,10 +2530,12 @@ PciEnumeratorLight (
//
RemoveRejectedPciDevices (RootBridgeDev->Handle, RootBridgeDev);
- //
- // Process option rom light
- //
- ProcessOptionRomLight (RootBridgeDev);
+ if (!PcdGetBool (PcdPciDisableBusEnumeration)) {
+ //
+ // Process option rom light
+ //
+ ProcessOptionRomLight (RootBridgeDev);
+ }
//
// Determine attributes for all devices under this root bridge
--
2.27.0
next prev parent reply other threads:[~2020-07-13 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 16:39 [PATCH v1 0/2] Add support for scanning Option ROMs Marcello Sylvester Bauer
2020-07-13 16:39 ` Marcello Sylvester Bauer [this message]
2020-07-13 16:39 ` [PATCH v1 2/2] UefiPayloadPkg: Scan for " Marcello Sylvester Bauer
2020-09-08 18:55 ` [edk2-devel] [PATCH v1 0/2] Add support for scanning " Guo Dong
-- strict thread matches above, loose matches on Subject: below --
2020-07-13 10:22 Marcello Sylvester Bauer
2020-07-13 10:22 ` [PATCH v1 1/2] MdeModulePkg: Fix OptionROM scanning Marcello Sylvester Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713163944.9893-2-marcello.bauer@9elements.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox