From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.19238.1594731847417380149 for ; Tue, 14 Jul 2020 06:04:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=tgj7jQBu; spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f66.google.com with SMTP id f139so5791770wmf.5 for ; Tue, 14 Jul 2020 06:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dUGp/nq4G2YFhmGSlzxwuAoDGfVdu/CzmnUkQ5xtwB8=; b=tgj7jQBuawp/QcVdP9WLVyuhnxG8TCS2slNv87ZxgnZZJ5x9nMX4KhdO1OQQ9k/76P 3ZzgEe4Nide0TVBil0MsdP8wCASRISwx6+6HghZN/UnbQvw9ztZ9lZaTOyfuxBGRnvdV N9vad5GBGPe/MD13tmFQPxljDncxVQbn16EGjIYq4OMqtFmOG0Ile7mmFOB+DBePUgWF IP0/beOpHWG2yinRlL+U9FnBlsGPIK3/6n00NB1FZhzmRLQ0z/ogJATMetmff33N5hXS 1SviVQoIakVbV4t85D8wWhFXtBRgWX+/5HPGxQjqi3Leh8/jBa1/DOLwxDMti7FgxHJJ 5xZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dUGp/nq4G2YFhmGSlzxwuAoDGfVdu/CzmnUkQ5xtwB8=; b=FV+rKw+IuKbAUZ2gD4av3nEmrBDyEosyxRfQDmihDNVwU9uZEQFogzjEC0qqwnQCK+ gOwOrSDnJHBDmLHpsVJv0GIowR1u7s6t8H+I7n2U2NvsC1UttO903mnl18/eIynwzOjl w3Ty0ZWUBUk9o8hdyxRHeIhZOWGFmwsUlUZ06oSmTMeEHZgEaFvY1b+uYnBgCJGL+iPr XpBID94RIxNQ2Zw0hKeP5mNFVMSG04H6pijpjxo+LCu2NBoWyAGzZHpbo89CbN3S6cKa PXOj+3EZwF1ySk6pad1HlsCYf5i1QHVLFvEaIEb6ZAdW1fIwnKNZej/RvA1j8fH0YgEK lbPg== X-Gm-Message-State: AOAM533Ajv8FjtMK9DQuoOj7FEV+CALFezDQ3nUqpYjH5BSdyTvkaLDk hTo4S+jNFIcOpORJKpef/WDmyg== X-Google-Smtp-Source: ABdhPJymC0DlaGXrIDnPLiPKWPYO7MGCYmwMSDL61f8xPwRFSeguXrfSUBhFVE8GTVPsmq20XBlsOw== X-Received: by 2002:a05:600c:2317:: with SMTP id 23mr4567122wmo.72.1594731846046; Tue, 14 Jul 2020 06:04:06 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id n125sm4355887wme.30.2020.07.14.06.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 06:04:05 -0700 (PDT) Date: Tue, 14 Jul 2020 14:04:03 +0100 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, Andrei Warkentin Subject: Re: [PATCH edk2-platforms 1/1] Platform/RaspberryPi: remove unused variable GpuIndex from PlatformLib Message-ID: <20200714130403.GV12303@vanye> References: <20200714124532.6535-1-leif@nuviainc.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 14, 2020 at 13:58:11 +0100, Pete Batard wrote: > Good call. > > On 2020.07.14 13:45, Leif Lindholm wrote: > > Commit 678f6bff3c46 ("RPi4: reserve/map memory above 4GB when present") > > removed the only user of the GpuIndex variable in > > ArmPlatformGetVirtualMemoryMap, which causes a build error of NOOPT > > profile with gcc 8.3. Delete the variable, and its initialization. > > > > Cc: Andrei Warkentin > > Cc: Pete Batard > > Signed-off-by: Leif Lindholm > > --- > > Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c > > index 60a7b43af993..c395e0c75df7 100644 > > --- a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c > > +++ b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c > > @@ -57,7 +57,6 @@ ArmPlatformGetVirtualMemoryMap ( > > ) > > { > > UINTN Index = 0; > > - UINTN GpuIndex; > > INT64 TotalMemorySize; > > INT64 MemorySizeBelow3GB; > > INT64 MemorySizeBelow4GB; > > @@ -162,7 +161,6 @@ ArmPlatformGetVirtualMemoryMap ( > > VirtualMemoryInfo[Index++].Name = L"System RAM < 1GB"; > > // GPU Reserved > > - GpuIndex = Index; > > VirtualMemoryTable[Index].PhysicalBase = mVideoCoreBase; > > VirtualMemoryTable[Index].VirtualBase = VirtualMemoryTable[Index].PhysicalBase; > > VirtualMemoryTable[Index].Length = mVideoCoreSize; > > > > Reviewed-by: Pete Batard Thanks! Pushed as 5d2d48eb8f26. / Leif