From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.8106.1594869238701047809 for ; Wed, 15 Jul 2020 20:13:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: shenglei.zhang@intel.com) IronPort-SDR: UIdY6nsZRwsYdovow4C3czE1Jc/Ov3AZBETUJsM4hu7Lu/TJsw9BdeaO1k3fG8FuqFpJrBOALo 3q38oWOYbOtA== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="137440953" X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="137440953" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 20:13:57 -0700 IronPort-SDR: rRNx3GrQkmGZl1OJZ2AB4WGWddNQm/kyvgkrNdVPKaCFc5T9F9yKV1DSvVAFd9X/wxMXvQMbfw SF4t1GjkJZtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="486461367" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga005.fm.intel.com with ESMTP; 15 Jul 2020 20:13:56 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Date: Thu, 16 Jul 2020 11:13:46 +0800 Message-Id: <20200716031346.40160-1-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836 Current PatchCheck.py checks each line to ensure line's length is not larger than 76. But there's a case that length of user's name is much longer than that number. So enhance the script to handle this case. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -268,7 +268,14 @@ class CommitMessageCheck: for i in range(2, count): if (len(lines[i]) >= 76 and len(lines[i].split()) > 1 and - not lines[i].startswith('git-svn-id:')): + not lines[i].startswith('git-svn-id:') and + not lines[i].startswith('Reviewed-by') and + not lines[i].startswith('Acked-by:') and + not lines[i].startswith('Tested-by:') and + not lines[i].startswith('Reported-by:') and + not lines[i].startswith('Suggested-by:') and + not lines[i].startswith('Signed-off-by:') and + not lines[i].startswith('Cc:')): # # Print a warning if body line is longer than 75 characters # -- 2.18.0.windows.1