From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [62.140.7.102]) by mx.groups.io with SMTP id smtpd.web12.8176.1594870391137721313 for ; Wed, 15 Jul 2020 20:33:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@suse.com header.s=mimecast20200619 header.b=MFn9co3P; spf=pass (domain: suse.com, ip: 62.140.7.102, mailfrom: glin@suse.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1594870387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aeFKxdssC9fk00w+8w1qJpQfpP3C5TldXU61SBQriZ8=; b=MFn9co3PS/jXHTfrm0FQS83j4kfYcDpEy5dxeUAZQ17fVgBX7ATuRni91TQoQ/zMw5s3h9 awSn/nP96ZP0J8ztl9KDNEyRsgfmZBzCYGtayLNQzHI0ZJ8Y8B5T9O2Rb6zDwkrVcgfPhK 5LreaHO42J4N4lUH6JWrytgAddQbgxM= Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-Ad1slsrRObuTCW5U-srL5A-1; Thu, 16 Jul 2020 05:33:05 +0200 X-MC-Unique: Ad1slsrRObuTCW5U-srL5A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqQ08ZaNQ0Y6LQ5TzC/839nCN42wghDuwDo5oZXwBb1gSjslJZynOKR1OjWW9xZD2B1RtKpkWgvfNNYYRSeEsmBASJSl6gyH7a+Hf73NvaWqoo7jmbNx9048DoTX3/woMHtxmTekb1At1OSDTmGCPLB8UFMiTj0lceiQzdXaR6iy5bI388eqi599p87xEw2JKXL85An9DoBXxj5Zw3l/8+GFdJu4i0CU3jWeNIpbwBXq5jFfX9+1NEWcPMpLkQ3sY7/iJUPe9vrqKlr02RaKA3siQqyjo8+aOKtIuzapFlv4Bs9Qn2lunCpIhzI7CPTZdbbiH+jMr34wtz2w45sd/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aeFKxdssC9fk00w+8w1qJpQfpP3C5TldXU61SBQriZ8=; b=nzlItbgCu7CXab7fhZmAuIvIfmu5Vkz5x1bIx3fa6CuRl3+9JZKsjft1WXdFB1uSdwjX2FqCFnIKaw2eZFA8kJisMBCkXu2xeDeStsIuDNkofYKVATg6b6xzsMP+1+W3JpqafM02MUIgqN7WfMIceLxjsX6yIZnuEaQk8W1Z55yfFjKt/jStgNKSOesVxEsqUNDu5Z1JF05SQrejH6D8/Z9k/bcBV/uEGgxVVkgX29T3urgmH4074DAYlBC6PlT8Hy67E3tmNNjcnzSpyAGGmzV5CapKSbgJlw2xUhFDFvyoLBWbtXxNQPyXUroou2b3N6RK+ll75uU4IOQfUBhXkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=suse.com; Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) by AM0PR04MB6529.eurprd04.prod.outlook.com (2603:10a6:208:16f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Thu, 16 Jul 2020 03:33:04 +0000 Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::a14c:d441:c8a9:77ba]) by AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::a14c:d441:c8a9:77ba%6]) with mapi id 15.20.3174.026; Thu, 16 Jul 2020 03:33:04 +0000 Date: Thu, 16 Jul 2020 11:32:55 +0800 From: "Gary Lin" To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Hao A Wu , Ray Ni Subject: Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Message-ID: <20200716033255.GL6058@GaryWorkstation> References: <20200714012259.30504-1-zhichao.gao@intel.com> <20200714012259.30504-4-zhichao.gao@intel.com> In-Reply-To: <20200714012259.30504-4-zhichao.gao@intel.com> X-ClientProxiedBy: AM3PR05CA0102.eurprd05.prod.outlook.com (2603:10a6:207:1::28) To AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) Return-Path: glin@suse.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from GaryWorkstation (60.251.47.115) by AM3PR05CA0102.eurprd05.prod.outlook.com (2603:10a6:207:1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Thu, 16 Jul 2020 03:33:02 +0000 X-Originating-IP: [60.251.47.115] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c4c9fce5-294e-4dd6-2471-08d82938f295 X-MS-TrafficTypeDiagnostic: AM0PR04MB6529: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1079; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tDLuTzuRCmqlZW8q4w9gy0vP79/znUe2zkAY4wnTUHLFRtkHRGBQNt9ZCyYr5ldWV2/nZaTfg4KSnkh2OlGbCk6oF0HzTDdI7GQz2njCp0yLaU7xT9WJfB5+/4+ahoG4FtfIfvAmWXI5dD62gTEgH1b5o05yiVFLhbAf2CyEJ6ZSrCjn6JEqvgBUdC8AzgP4RpSEWfnTpt+1Vu1dVBCd0FlyXv0RE11twTo9/pFDoIiygKIiGome+c0wuu+DHEC7OFOgrMeeh5ARFSP8eWtIIz5nTOTMgtjXLP97T9gkvG6OLZs36AyoTMK0k/vjrNwTPvsc/KzRtEnGzxx/kIpKFFOsSIhFtDe5tnW6FpTP05BLBVlDNHdvU3aQwkMb9o2Qveo7SCal9tibMpw5yPcQow== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR0402MB3809.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(39860400002)(366004)(136003)(376002)(396003)(9686003)(5660300002)(2906002)(8936002)(8676002)(86362001)(66476007)(66556008)(956004)(66946007)(55236004)(4326008)(54906003)(33716001)(478600001)(55016002)(966005)(26005)(6666004)(16526019)(6496006)(316002)(186003)(83380400001)(33656002)(52116002)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: qSj51VphZQr4rYitDht6mI920mnxaR5cvUL7umFJdJjIZwZAW8k3yBYr5clRLJmQKRoX9EsCtehMB1U2nWprASnArFreZRwO+gaAsZsBoNFkRvU7h5BB/mWFS2Dv4Y+zGvUtQcXiwgnO20VkSa8wwkbXr2rNrg4KqOHHY8nX825JlXqhmCC58GO6Rdd35j5J2h0bKrdDvz4ttZeTlXp5RnTiuh1Pk9+xfzpkVjnNEs2PcuVD8JDuNcwjrRu5csmBinHZnnLAnpFlyzmAuiLFE5sqVQ290y4v8sRLt37voaMBelapczVRc05Uo/2GVj1vot3RxTsg0OgzfwlgDo9iqogsLjX+9oG++5tiTaMnSi1sEUzNI7k2Au6GzO8XfYXBHe45T/zp0MS7Fj4Owtjt60dnJVV2acbZwfciZklqx71P75IcJSQFcFfxVCPt+XoQ7Aua026g6/EdeTECqKGpxZxecDOnIDRQkU6z1cUgun8= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4c9fce5-294e-4dd6-2471-08d82938f295 X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3809.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2020 03:33:04.2830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ssPxonLVrQWcDTJPRCCQ1JzRKEPPcPUlz6iRXxpaks6V62+40UJ2vsVvw6seuszO X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6529 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 14, 2020 at 09:22:59AM +0800, Gao, Zhichao via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 > > Treat the EFI_ALREADY_STARTED as EFI_SUCCESS to avoid the partition driver > continuely check next routine function. Hi Zhichao, I just found that this patch breaks the loading of openSUSE iso images[*]. Would you mind to take a look at it? Thanks, Gary Lin [*] http://download.opensuse.org/distribution/leap/15.2/iso/openSUSE-Leap-15.2-NET-x86_64.iso > > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Zhichao Gao > Reviewed-by: Hao A Wu > --- > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > index d1c878ad2e..6a43c3cafb 100644 > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > @@ -1276,6 +1276,15 @@ PartitionInstallChildHandle ( > } else { > FreePool (Private->DevicePath); > FreePool (Private); > + > + // > + // if the Status == EFI_ALREADY_STARTED, it means the child handles > + // are already installed. So return EFI_SUCCESS to avoid do the next > + // partition type check. > + // > + if (Status == EFI_ALREADY_STARTED) { > + Status = EFI_SUCCESS; > + } > } > > return Status; > -- > 2.21.0.windows.1 > > > >