[PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Wang, Jian J]

- Remove the address of Zhang, Chao from maintainer and reviewer list since
  he has left the community. Many thanks to his great contributions to edk2.
- Add Yao, Jiewen as maintainer of CryptoPkg, but remove him from
  SignedCapsulePkg.
- Add Wang, Jian J to maintainer list of SignedCapsulePkg

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 Maintainers.txt | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 32c9003a62..99362676b1 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -161,6 +161,7 @@ M: Liming Gao <liming.gao@intel.com>
 CryptoPkg
 F: CryptoPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
+M: Jiewen Yao <jiewen.yao@intel.com>
 M: Jian J Wang <jian.j.wang@intel.com>
 R: Xiaoyu Lu <xiaoyux.lu@intel.com>
 
@@ -458,7 +459,6 @@ F: SecurityPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
 M: Jiewen Yao <jiewen.yao@intel.com>
 M: Jian J Wang <jian.j.wang@intel.com>
-R: Chao Zhang <chao.b.zhang@intel.com>
 
 SecurityPkg: Secure boot related modules
 F: SecurityPkg/Library/DxeImageVerificationLib/
@@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
 SignedCapsulePkg
 F: SignedCapsulePkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
-M: Jiewen Yao <jiewen.yao@intel.com>
-M: Chao Zhang <chao.b.zhang@intel.com>
+M: Jian J Wang <jian.j.wang@intel.com>
 
 SourceLevelDebugPkg
 F: SourceLevelDebugPkg/
-- 
2.24.0.windows.2

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Liming Gao]

Reviewed-by: Liming Gao <liming.gao@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wang, Jian J
Sent: 2020年7月16日 17:32
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

- Remove the address of Zhang, Chao from maintainer and reviewer list since
  he has left the community. Many thanks to his great contributions to edk2.
- Add Yao, Jiewen as maintainer of CryptoPkg, but remove him from
  SignedCapsulePkg.
- Add Wang, Jian J to maintainer list of SignedCapsulePkg

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 Maintainers.txt | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt index 32c9003a62..99362676b1 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -161,6 +161,7 @@ M: Liming Gao <liming.gao@intel.com>  CryptoPkg F: CryptoPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg+M: Jiewen Yao <jiewen.yao@intel.com> M: Jian J Wang <jian.j.wang@intel.com> R: Xiaoyu Lu <xiaoyux.lu@intel.com> @@ -458,7 +459,6 @@ F: SecurityPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg M: Jiewen Yao <jiewen.yao@intel.com> M: Jian J Wang <jian.j.wang@intel.com>-R: Chao Zhang <chao.b.zhang@intel.com>  SecurityPkg: Secure boot related modules F: SecurityPkg/Library/DxeImageVerificationLib/@@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>  SignedCapsulePkg F: SignedCapsulePkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg-M: Jiewen Yao <jiewen.yao@intel.com>-M: Chao Zhang <chao.b.zhang@intel.com>+M: Jian J Wang <jian.j.wang@intel.com>  SourceLevelDebugPkg F: SourceLevelDebugPkg/--
2.24.0.windows.2


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#62675): https://edk2.groups.io/g/devel/message/62675
Mute This Topic: https://groups.io/mt/75538083/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [liming.gao@intel.com]
-=-=-=-=-=-=

Re: [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Yao, Jiewen]

Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

> -----Original Message-----
> From: Wang, Jian J <jian.j.wang@intel.com>
> Sent: Thursday, July 16, 2020 5:32 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>;
> Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH] Maintainers.txt: Remove invalid email address and a few other
> role changes
> 
> - Remove the address of Zhang, Chao from maintainer and reviewer list since
>   he has left the community. Many thanks to his great contributions to edk2.
> - Add Yao, Jiewen as maintainer of CryptoPkg, but remove him from
>   SignedCapsulePkg.
> - Add Wang, Jian J to maintainer list of SignedCapsulePkg
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
>  Maintainers.txt | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 32c9003a62..99362676b1 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -161,6 +161,7 @@ M: Liming Gao <liming.gao@intel.com>
>  CryptoPkg
> 
>  F: CryptoPkg/
> 
>  W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
> 
> +M: Jiewen Yao <jiewen.yao@intel.com>
> 
>  M: Jian J Wang <jian.j.wang@intel.com>
> 
>  R: Xiaoyu Lu <xiaoyux.lu@intel.com>
> 
> 
> 
> @@ -458,7 +459,6 @@ F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> 
>  M: Jiewen Yao <jiewen.yao@intel.com>
> 
>  M: Jian J Wang <jian.j.wang@intel.com>
> 
> -R: Chao Zhang <chao.b.zhang@intel.com>
> 
> 
> 
>  SecurityPkg: Secure boot related modules
> 
>  F: SecurityPkg/Library/DxeImageVerificationLib/
> 
> @@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
>  SignedCapsulePkg
> 
>  F: SignedCapsulePkg/
> 
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> 
> -M: Jiewen Yao <jiewen.yao@intel.com>
> 
> -M: Chao Zhang <chao.b.zhang@intel.com>
> 
> +M: Jian J Wang <jian.j.wang@intel.com>
> 
> 
> 
>  SourceLevelDebugPkg
> 
>  F: SourceLevelDebugPkg/
> 
> --
> 2.24.0.windows.2

Re: [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Laszlo Ersek]

On 07/16/20 11:31, Jian J Wang wrote:
> - Remove the address of Zhang, Chao from maintainer and reviewer list since
>   he has left the community. Many thanks to his great contributions to edk2.
> - Add Yao, Jiewen as maintainer of CryptoPkg, but remove him from
>   SignedCapsulePkg.
> - Add Wang, Jian J to maintainer list of SignedCapsulePkg
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
>  Maintainers.txt | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 32c9003a62..99362676b1 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -161,6 +161,7 @@ M: Liming Gao <liming.gao@intel.com>
>  CryptoPkg
>  F: CryptoPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
> +M: Jiewen Yao <jiewen.yao@intel.com>
>  M: Jian J Wang <jian.j.wang@intel.com>
>  R: Xiaoyu Lu <xiaoyux.lu@intel.com>
>  
> @@ -458,7 +459,6 @@ F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>  M: Jiewen Yao <jiewen.yao@intel.com>
>  M: Jian J Wang <jian.j.wang@intel.com>
> -R: Chao Zhang <chao.b.zhang@intel.com>
>  
>  SecurityPkg: Secure boot related modules
>  F: SecurityPkg/Library/DxeImageVerificationLib/
> @@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
>  SignedCapsulePkg
>  F: SignedCapsulePkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> -M: Jiewen Yao <jiewen.yao@intel.com>
> -M: Chao Zhang <chao.b.zhang@intel.com>
> +M: Jian J Wang <jian.j.wang@intel.com>
>  
>  SourceLevelDebugPkg
>  F: SourceLevelDebugPkg/
> 

If Chao still has access to his @intel.com email address (just working
in a different role), then it would be nice if he could send an ACK.

(The commit message says Chao has left the community, which I understand
to be the upstream edk2 project; so in theory his Intel email address
could still function. On the other hand, the subject line says the email
address is now "invalid", so I can't really tell.)


Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo

Re: [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Wang, Jian J]

Hi Laszlo,

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Thursday, July 16, 2020 8:35 PM
> To: Wang, Jian J <jian.j.wang@intel.com>; devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>; Leif
> Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [PATCH] Maintainers.txt: Remove invalid email address and a few
> other role changes
> 
> On 07/16/20 11:31, Jian J Wang wrote:
> > - Remove the address of Zhang, Chao from maintainer and reviewer list since
> >   he has left the community. Many thanks to his great contributions to edk2.
> > - Add Yao, Jiewen as maintainer of CryptoPkg, but remove him from
> >   SignedCapsulePkg.
> > - Add Wang, Jian J to maintainer list of SignedCapsulePkg
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> > ---
> >  Maintainers.txt | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index 32c9003a62..99362676b1 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -161,6 +161,7 @@ M: Liming Gao <liming.gao@intel.com>
> >  CryptoPkg
> >  F: CryptoPkg/
> >  W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
> > +M: Jiewen Yao <jiewen.yao@intel.com>
> >  M: Jian J Wang <jian.j.wang@intel.com>
> >  R: Xiaoyu Lu <xiaoyux.lu@intel.com>
> >
> > @@ -458,7 +459,6 @@ F: SecurityPkg/
> >  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> >  M: Jiewen Yao <jiewen.yao@intel.com>
> >  M: Jian J Wang <jian.j.wang@intel.com>
> > -R: Chao Zhang <chao.b.zhang@intel.com>
> >
> >  SecurityPkg: Secure boot related modules
> >  F: SecurityPkg/Library/DxeImageVerificationLib/
> > @@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
> >  SignedCapsulePkg
> >  F: SignedCapsulePkg/
> >  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> > -M: Jiewen Yao <jiewen.yao@intel.com>
> > -M: Chao Zhang <chao.b.zhang@intel.com>
> > +M: Jian J Wang <jian.j.wang@intel.com>
> >
> >  SourceLevelDebugPkg
> >  F: SourceLevelDebugPkg/
> >
> 
> If Chao still has access to his @intel.com email address (just working
> in a different role), then it would be nice if he could send an ACK.
> 
> (The commit message says Chao has left the community, which I understand
> to be the upstream edk2 project; so in theory his Intel email address
> could still function. On the other hand, the subject line says the email
> address is now "invalid", so I can't really tell.)

Sorry I brought confusions to you. Actually he left both Intel and community
so the email address is not valid any more. I don' t have his new address and
cannot notify him in this mailing list. But I did get his ACK through WeChat.

Regards,
Jian
> 
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks
> Laszlo

Re: [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Leif Lindholm]

On Fri, Jul 17, 2020 at 07:41:40 +0000, Wang, Jian J wrote:
> > >  SecurityPkg: Secure boot related modules
> > >  F: SecurityPkg/Library/DxeImageVerificationLib/
> > > @@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
> > >  SignedCapsulePkg
> > >  F: SignedCapsulePkg/
> > >  W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> > > -M: Jiewen Yao <jiewen.yao@intel.com>
> > > -M: Chao Zhang <chao.b.zhang@intel.com>
> > > +M: Jian J Wang <jian.j.wang@intel.com>
> > >
> > >  SourceLevelDebugPkg
> > >  F: SourceLevelDebugPkg/
> > >
> > 
> > If Chao still has access to his @intel.com email address (just working
> > in a different role), then it would be nice if he could send an ACK.
> > 
> > (The commit message says Chao has left the community, which I understand
> > to be the upstream edk2 project; so in theory his Intel email address
> > could still function. On the other hand, the subject line says the email
> > address is now "invalid", so I can't really tell.)
> 
> Sorry I brought confusions to you. Actually he left both Intel and community
> so the email address is not valid any more. I don' t have his new address and
> cannot notify him in this mailing list. But I did get his ACK through WeChat.

OK. This is not a very unusual situation.

However, given that, can we break out Chao from this patch and merge
it separately, stating those reasons. If the commit message says so,
the patch is sent by an Intel employee and we can have a reviewed-by
from another Intel employee (like we did for Supreeth for uefi-sct), I
think that would make the history very clear.

Regards,

Leif


> Regards,
> Jian
> > 
> > 
> > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > 
> > Thanks
> > Laszlo
> 

Re: [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Wang, Jian J]

Lief,


> -----Original Message-----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Friday, July 17, 2020 5:50 PM
> To: Wang, Jian J <jian.j.wang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Yao, Jiewen
> <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [PATCH] Maintainers.txt: Remove invalid email address and a few
> other role changes
> 
> On Fri, Jul 17, 2020 at 07:41:40 +0000, Wang, Jian J wrote:
> > > >  SecurityPkg: Secure boot related modules
> > > >  F: SecurityPkg/Library/DxeImageVerificationLib/
> > > > @@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
> > > >  SignedCapsulePkg
> > > >  F: SignedCapsulePkg/
> > > >  W:
> https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> > > > -M: Jiewen Yao <jiewen.yao@intel.com>
> > > > -M: Chao Zhang <chao.b.zhang@intel.com>
> > > > +M: Jian J Wang <jian.j.wang@intel.com>
> > > >
> > > >  SourceLevelDebugPkg
> > > >  F: SourceLevelDebugPkg/
> > > >
> > >
> > > If Chao still has access to his @intel.com email address (just working
> > > in a different role), then it would be nice if he could send an ACK.
> > >
> > > (The commit message says Chao has left the community, which I understand
> > > to be the upstream edk2 project; so in theory his Intel email address
> > > could still function. On the other hand, the subject line says the email
> > > address is now "invalid", so I can't really tell.)
> >
> > Sorry I brought confusions to you. Actually he left both Intel and community
> > so the email address is not valid any more. I don' t have his new address and
> > cannot notify him in this mailing list. But I did get his ACK through WeChat.
> 
> OK. This is not a very unusual situation.
> 
> However, given that, can we break out Chao from this patch and merge
> it separately, stating those reasons. If the commit message says so,
> the patch is sent by an Intel employee and we can have a reviewed-by
> from another Intel employee (like we did for Supreeth for uefi-sct), I
> think that would make the history very clear.
> 

I already pushed the patch before noticing your comment. Sorry for it.
I'm not sure I get your point. Do you mean I could send the patch in the
name of Chao but R-B by me or others? Or I should have separated one
maintainer change from other changes in different patches?

Regards,
Jian

> Regards,
> 
> Leif
> 
> 
> > Regards,
> > Jian
> > >
> > >
> > > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > >
> > > Thanks
> > > Laszlo
> >

Re: [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Leif Lindholm]

On Mon, Jul 20, 2020 at 04:58:05 +0000, Wang, Jian J wrote:
> Lief,
> 
> 
> > -----Original Message-----
> > From: Leif Lindholm <leif@nuviainc.com>
> > Sent: Friday, July 17, 2020 5:50 PM
> > To: Wang, Jian J <jian.j.wang@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Yao, Jiewen
> > <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: Re: [PATCH] Maintainers.txt: Remove invalid email address and a few
> > other role changes
> > 
> > On Fri, Jul 17, 2020 at 07:41:40 +0000, Wang, Jian J wrote:
> > > > >  SecurityPkg: Secure boot related modules
> > > > >  F: SecurityPkg/Library/DxeImageVerificationLib/
> > > > > @@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
> > > > >  SignedCapsulePkg
> > > > >  F: SignedCapsulePkg/
> > > > >  W:
> > https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> > > > > -M: Jiewen Yao <jiewen.yao@intel.com>
> > > > > -M: Chao Zhang <chao.b.zhang@intel.com>
> > > > > +M: Jian J Wang <jian.j.wang@intel.com>
> > > > >
> > > > >  SourceLevelDebugPkg
> > > > >  F: SourceLevelDebugPkg/
> > > > >
> > > >
> > > > If Chao still has access to his @intel.com email address (just working
> > > > in a different role), then it would be nice if he could send an ACK.
> > > >
> > > > (The commit message says Chao has left the community, which I understand
> > > > to be the upstream edk2 project; so in theory his Intel email address
> > > > could still function. On the other hand, the subject line says the email
> > > > address is now "invalid", so I can't really tell.)
> > >
> > > Sorry I brought confusions to you. Actually he left both Intel and community
> > > so the email address is not valid any more. I don' t have his new address and
> > > cannot notify him in this mailing list. But I did get his ACK through WeChat.
> > 
> > OK. This is not a very unusual situation.
> > 
> > However, given that, can we break out Chao from this patch and merge
> > it separately, stating those reasons. If the commit message says so,
> > the patch is sent by an Intel employee and we can have a reviewed-by
> > from another Intel employee (like we did for Supreeth for uefi-sct), I
> > think that would make the history very clear.
> > 
> 
> I already pushed the patch before noticing your comment. Sorry for it.
> I'm not sure I get your point. Do you mean I could send the patch in the
> name of Chao but R-B by me or others? Or I should have separated one
> maintainer change from other changes in different patches?

Some of the changes were trivial and just moving people around. Does
not require steward review.

The removal of Chao without possibility for them to give an R-b is a
special case and needs some form of due diligence to verify that the
right thing is happening. A reviewed-by from a steward is one way to
do so. It would have made sense to keep it separate.

Regards,

Leif

> 
> Regards,
> Jian
> 
> > Regards,
> > 
> > Leif
> > 
> > 
> > > Regards,
> > > Jian
> > > >
> > > >
> > > > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > > >
> > > > Thanks
> > > > Laszlo
> > >

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Wang, Jian J]

Leif,


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> Lindholm
> Sent: Monday, July 20, 2020 9:37 PM
> To: Wang, Jian J <jian.j.wang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Yao, Jiewen
> <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address
> and a few other role changes
> 
> On Mon, Jul 20, 2020 at 04:58:05 +0000, Wang, Jian J wrote:
> > Lief,
> >
> >
> > > -----Original Message-----
> > > From: Leif Lindholm <leif@nuviainc.com>
> > > Sent: Friday, July 17, 2020 5:50 PM
> > > To: Wang, Jian J <jian.j.wang@intel.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Yao, Jiewen
> > > <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael
> D
> > > <michael.d.kinney@intel.com>
> > > Subject: Re: [PATCH] Maintainers.txt: Remove invalid email address and a
> few
> > > other role changes
> > >
> > > On Fri, Jul 17, 2020 at 07:41:40 +0000, Wang, Jian J wrote:
> > > > > >  SecurityPkg: Secure boot related modules
> > > > > >  F: SecurityPkg/Library/DxeImageVerificationLib/
> > > > > > @@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
> > > > > >  SignedCapsulePkg
> > > > > >  F: SignedCapsulePkg/
> > > > > >  W:
> > > https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> > > > > > -M: Jiewen Yao <jiewen.yao@intel.com>
> > > > > > -M: Chao Zhang <chao.b.zhang@intel.com>
> > > > > > +M: Jian J Wang <jian.j.wang@intel.com>
> > > > > >
> > > > > >  SourceLevelDebugPkg
> > > > > >  F: SourceLevelDebugPkg/
> > > > > >
> > > > >
> > > > > If Chao still has access to his @intel.com email address (just working
> > > > > in a different role), then it would be nice if he could send an ACK.
> > > > >
> > > > > (The commit message says Chao has left the community, which I
> understand
> > > > > to be the upstream edk2 project; so in theory his Intel email address
> > > > > could still function. On the other hand, the subject line says the email
> > > > > address is now "invalid", so I can't really tell.)
> > > >
> > > > Sorry I brought confusions to you. Actually he left both Intel and
> community
> > > > so the email address is not valid any more. I don' t have his new address
> and
> > > > cannot notify him in this mailing list. But I did get his ACK through WeChat.
> > >
> > > OK. This is not a very unusual situation.
> > >
> > > However, given that, can we break out Chao from this patch and merge
> > > it separately, stating those reasons. If the commit message says so,
> > > the patch is sent by an Intel employee and we can have a reviewed-by
> > > from another Intel employee (like we did for Supreeth for uefi-sct), I
> > > think that would make the history very clear.
> > >
> >
> > I already pushed the patch before noticing your comment. Sorry for it.
> > I'm not sure I get your point. Do you mean I could send the patch in the
> > name of Chao but R-B by me or others? Or I should have separated one
> > maintainer change from other changes in different patches?
> 
> Some of the changes were trivial and just moving people around. Does
> not require steward review.
> 
> The removal of Chao without possibility for them to give an R-b is a
> special case and needs some form of due diligence to verify that the
> right thing is happening. A reviewed-by from a steward is one way to
> do so. It would have made sense to keep it separate.
> 

Understood now. Thanks for the explanations.

Regards,
Jian

> Regards,
> 
> Leif
> 
> >
> > Regards,
> > Jian
> >
> > > Regards,
> > >
> > > Leif
> > >
> > >
> > > > Regards,
> > > > Jian
> > > > >
> > > > >
> > > > > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > > > >
> > > > > Thanks
> > > > > Laszlo
> > > >
> 
> 

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

[Wang, Jian J]

Leif,

Sorry for that I mis-spelled your name in last email.

Regards,
Jian

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wang, Jian
> J
> Sent: Monday, July 20, 2020 12:58 PM
> To: Leif Lindholm <leif@nuviainc.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Yao, Jiewen
> <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address
> and a few other role changes
> 
> Lief,
> 
> 
> > -----Original Message-----
> > From: Leif Lindholm <leif@nuviainc.com>
> > Sent: Friday, July 17, 2020 5:50 PM
> > To: Wang, Jian J <jian.j.wang@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Yao, Jiewen
> > <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: Re: [PATCH] Maintainers.txt: Remove invalid email address and a few
> > other role changes
> >
> > On Fri, Jul 17, 2020 at 07:41:40 +0000, Wang, Jian J wrote:
> > > > >  SecurityPkg: Secure boot related modules
> > > > >  F: SecurityPkg/Library/DxeImageVerificationLib/
> > > > > @@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
> > > > >  SignedCapsulePkg
> > > > >  F: SignedCapsulePkg/
> > > > >  W:
> > https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> > > > > -M: Jiewen Yao <jiewen.yao@intel.com>
> > > > > -M: Chao Zhang <chao.b.zhang@intel.com>
> > > > > +M: Jian J Wang <jian.j.wang@intel.com>
> > > > >
> > > > >  SourceLevelDebugPkg
> > > > >  F: SourceLevelDebugPkg/
> > > > >
> > > >
> > > > If Chao still has access to his @intel.com email address (just working
> > > > in a different role), then it would be nice if he could send an ACK.
> > > >
> > > > (The commit message says Chao has left the community, which I
> understand
> > > > to be the upstream edk2 project; so in theory his Intel email address
> > > > could still function. On the other hand, the subject line says the email
> > > > address is now "invalid", so I can't really tell.)
> > >
> > > Sorry I brought confusions to you. Actually he left both Intel and community
> > > so the email address is not valid any more. I don' t have his new address and
> > > cannot notify him in this mailing list. But I did get his ACK through WeChat.
> >
> > OK. This is not a very unusual situation.
> >
> > However, given that, can we break out Chao from this patch and merge
> > it separately, stating those reasons. If the commit message says so,
> > the patch is sent by an Intel employee and we can have a reviewed-by
> > from another Intel employee (like we did for Supreeth for uefi-sct), I
> > think that would make the history very clear.
> >
> 
> I already pushed the patch before noticing your comment. Sorry for it.
> I'm not sure I get your point. Do you mean I could send the patch in the
> name of Chao but R-B by me or others? Or I should have separated one
> maintainer change from other changes in different patches?
> 
> Regards,
> Jian
> 
> > Regards,
> >
> > Leif
> >
> >
> > > Regards,
> > > Jian
> > > >
> > > >
> > > > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > > >
> > > > Thanks
> > > > Laszlo
> > >
> 
>