From: "Bob Feng" <bob.c.feng@intel.com>
To: devel@edk2.groups.io
Cc: Liming Gao <liming.gao@intel.com>
Subject: [Patch] BaseTools: Remove the file timestamp checking during parsing
Date: Thu, 16 Jul 2020 19:22:04 +0800 [thread overview]
Message-ID: <20200716112204.42176-1-bob.c.feng@intel.com> (raw)
During build, the meta files are not changed, so it's no need
to check file timestamp.
This patch is to remove useless logic.
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
.../Source/Python/Workspace/MetaFileTable.py | 12 ++----------
.../Source/Python/Workspace/WorkspaceDatabase.py | 16 ----------------
2 files changed, 2 insertions(+), 26 deletions(-)
diff --git a/BaseTools/Source/Python/Workspace/MetaFileTable.py b/BaseTools/Source/Python/Workspace/MetaFileTable.py
index 0555c91ccc..20cb80e36e 100644
--- a/BaseTools/Source/Python/Workspace/MetaFileTable.py
+++ b/BaseTools/Source/Python/Workspace/MetaFileTable.py
@@ -44,29 +44,21 @@ class MetaFileTable():
self.TableName = "_%s_%s_%s" % (FileType, len(DB.TblFile), uuid.uuid4().hex)
else:
self.TableName = "_%s_%s" % (FileType, len(DB.TblFile))
def IsIntegrity(self):
+ Result = False
try:
TimeStamp = self.MetaFile.TimeStamp
if not self.CurrentContent:
Result = False
else:
Result = self.CurrentContent[-1][0] < 0
- if not Result:
- # update the timestamp in database
- self.DB.SetFileTimeStamp(self.FileId, TimeStamp)
- return False
-
- if TimeStamp != self.DB.GetFileTimeStamp(self.FileId):
- # update the timestamp in database
- self.DB.SetFileTimeStamp(self.FileId, TimeStamp)
- return False
except Exception as Exc:
EdkLogger.debug(EdkLogger.DEBUG_5, str(Exc))
return False
- return True
+ return Result
def SetEndFlag(self):
self.CurrentContent.append(self._DUMMY_)
def GetAll(self):
diff --git a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
index 9420eaa608..d955c78b25 100644
--- a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
+++ b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
@@ -156,16 +156,10 @@ class WorkspaceDatabase(object):
# conversion object for build or file format conversion purpose
self.BuildObject = WorkspaceDatabase.BuildObjectFactory(self)
self.TransformObject = WorkspaceDatabase.TransformObjectFactory(self)
- def SetFileTimeStamp(self,FileId,TimeStamp):
- self.TblFile[FileId-1][6] = TimeStamp
-
- def GetFileTimeStamp(self,FileId):
- return self.TblFile[FileId-1][6]
-
## Summarize all packages in the database
def GetPackageList(self, Platform, Arch, TargetName, ToolChainTag):
self.Platform = Platform
PackageList = []
@@ -191,20 +185,10 @@ class WorkspaceDatabase(object):
continue
PackageList.append(Package)
return PackageList
- ## Summarize all platforms in the database
- def PlatformList(self):
- RetVal = []
- for PlatformFile in [item[3] for item in self.TblFile if item[5] == MODEL_FILE_DSC]:
- try:
- RetVal.append(self.BuildObject[PathClass(PlatformFile), TAB_COMMON])
- except:
- pass
- return RetVal
-
def MapPlatform(self, Dscfile):
Platform = self.BuildObject[PathClass(Dscfile), TAB_COMMON]
if Platform is None:
EdkLogger.error('build', PARSER_ERROR, "Failed to parser DSC file: %s" % Dscfile)
return Platform
--
2.20.1.windows.1
next reply other threads:[~2020-07-16 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 11:22 Bob Feng [this message]
2020-07-20 7:03 ` [Patch] BaseTools: Remove the file timestamp checking during parsing Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716112204.42176-1-bob.c.feng@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox