From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.13343.1594898532800831733 for ; Thu, 16 Jul 2020 04:22:12 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: bob.c.feng@intel.com) IronPort-SDR: Cie5mXFG5QHqn5cKuqkAPQtT7KyDk28YAK+FI3EorsmtqVDGXOQ8og8kPqnrHpGL9MY/FlGuGr rIt/vfggB9VA== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="210888672" X-IronPort-AV: E=Sophos;i="5.75,359,1589266800"; d="scan'208";a="210888672" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2020 04:22:12 -0700 IronPort-SDR: fS6EHjbao75rMn0CFeOuql5oVmuQJWTMFb3EEGhQ7h5bZ8p9yWoRprN5hvAiWbB8jcWv1hPRdR FJ7Hf5eXCpcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,359,1589266800"; d="scan'208";a="308595192" Received: from shwdepsi1121.ccr.corp.intel.com ([10.239.158.83]) by fmsmga004.fm.intel.com with ESMTP; 16 Jul 2020 04:22:11 -0700 From: "Bob Feng" To: devel@edk2.groups.io Cc: Liming Gao Subject: [Patch] BaseTools: Remove the file timestamp checking during parsing Date: Thu, 16 Jul 2020 19:22:04 +0800 Message-Id: <20200716112204.42176-1-bob.c.feng@intel.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit During build, the meta files are not changed, so it's no need to check file timestamp. This patch is to remove useless logic. Signed-off-by: Bob Feng Cc: Liming Gao --- .../Source/Python/Workspace/MetaFileTable.py | 12 ++---------- .../Source/Python/Workspace/WorkspaceDatabase.py | 16 ---------------- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/MetaFileTable.py b/BaseTools/Source/Python/Workspace/MetaFileTable.py index 0555c91ccc..20cb80e36e 100644 --- a/BaseTools/Source/Python/Workspace/MetaFileTable.py +++ b/BaseTools/Source/Python/Workspace/MetaFileTable.py @@ -44,29 +44,21 @@ class MetaFileTable(): self.TableName = "_%s_%s_%s" % (FileType, len(DB.TblFile), uuid.uuid4().hex) else: self.TableName = "_%s_%s" % (FileType, len(DB.TblFile)) def IsIntegrity(self): + Result = False try: TimeStamp = self.MetaFile.TimeStamp if not self.CurrentContent: Result = False else: Result = self.CurrentContent[-1][0] < 0 - if not Result: - # update the timestamp in database - self.DB.SetFileTimeStamp(self.FileId, TimeStamp) - return False - - if TimeStamp != self.DB.GetFileTimeStamp(self.FileId): - # update the timestamp in database - self.DB.SetFileTimeStamp(self.FileId, TimeStamp) - return False except Exception as Exc: EdkLogger.debug(EdkLogger.DEBUG_5, str(Exc)) return False - return True + return Result def SetEndFlag(self): self.CurrentContent.append(self._DUMMY_) def GetAll(self): diff --git a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py index 9420eaa608..d955c78b25 100644 --- a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py +++ b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py @@ -156,16 +156,10 @@ class WorkspaceDatabase(object): # conversion object for build or file format conversion purpose self.BuildObject = WorkspaceDatabase.BuildObjectFactory(self) self.TransformObject = WorkspaceDatabase.TransformObjectFactory(self) - def SetFileTimeStamp(self,FileId,TimeStamp): - self.TblFile[FileId-1][6] = TimeStamp - - def GetFileTimeStamp(self,FileId): - return self.TblFile[FileId-1][6] - ## Summarize all packages in the database def GetPackageList(self, Platform, Arch, TargetName, ToolChainTag): self.Platform = Platform PackageList = [] @@ -191,20 +185,10 @@ class WorkspaceDatabase(object): continue PackageList.append(Package) return PackageList - ## Summarize all platforms in the database - def PlatformList(self): - RetVal = [] - for PlatformFile in [item[3] for item in self.TblFile if item[5] == MODEL_FILE_DSC]: - try: - RetVal.append(self.BuildObject[PathClass(PlatformFile), TAB_COMMON]) - except: - pass - return RetVal - def MapPlatform(self, Dscfile): Platform = self.BuildObject[PathClass(Dscfile), TAB_COMMON] if Platform is None: EdkLogger.error('build', PARSER_ERROR, "Failed to parser DSC file: %s" % Dscfile) return Platform -- 2.20.1.windows.1