Re: [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

["Leif Lindholm" <leif@nuviainc.com>]

On Mon, Jul 20, 2020 at 04:58:05 +0000, Wang, Jian J wrote:
> Lief,
> 
> 
> > -----Original Message-----
> > From: Leif Lindholm <leif@nuviainc.com>
> > Sent: Friday, July 17, 2020 5:50 PM
> > To: Wang, Jian J <jian.j.wang@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Yao, Jiewen
> > <jiewen.yao@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: Re: [PATCH] Maintainers.txt: Remove invalid email address and a few
> > other role changes
> > 
> > On Fri, Jul 17, 2020 at 07:41:40 +0000, Wang, Jian J wrote:
> > > > >  SecurityPkg: Secure boot related modules
> > > > >  F: SecurityPkg/Library/DxeImageVerificationLib/
> > > > > @@ -480,8 +480,7 @@ M: Zhichao Gao <zhichao.gao@intel.com>
> > > > >  SignedCapsulePkg
> > > > >  F: SignedCapsulePkg/
> > > > >  W:
> > https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
> > > > > -M: Jiewen Yao <jiewen.yao@intel.com>
> > > > > -M: Chao Zhang <chao.b.zhang@intel.com>
> > > > > +M: Jian J Wang <jian.j.wang@intel.com>
> > > > >
> > > > >  SourceLevelDebugPkg
> > > > >  F: SourceLevelDebugPkg/
> > > > >
> > > >
> > > > If Chao still has access to his @intel.com email address (just working
> > > > in a different role), then it would be nice if he could send an ACK.
> > > >
> > > > (The commit message says Chao has left the community, which I understand
> > > > to be the upstream edk2 project; so in theory his Intel email address
> > > > could still function. On the other hand, the subject line says the email
> > > > address is now "invalid", so I can't really tell.)
> > >
> > > Sorry I brought confusions to you. Actually he left both Intel and community
> > > so the email address is not valid any more. I don' t have his new address and
> > > cannot notify him in this mailing list. But I did get his ACK through WeChat.
> > 
> > OK. This is not a very unusual situation.
> > 
> > However, given that, can we break out Chao from this patch and merge
> > it separately, stating those reasons. If the commit message says so,
> > the patch is sent by an Intel employee and we can have a reviewed-by
> > from another Intel employee (like we did for Supreeth for uefi-sct), I
> > think that would make the history very clear.
> > 
> 
> I already pushed the patch before noticing your comment. Sorry for it.
> I'm not sure I get your point. Do you mean I could send the patch in the
> name of Chao but R-B by me or others? Or I should have separated one
> maintainer change from other changes in different patches?

Some of the changes were trivial and just moving people around. Does
not require steward review.

The removal of Chao without possibility for them to give an R-b is a
special case and needs some form of due diligence to verify that the
right thing is happening. A reviewed-by from a steward is one way to
do so. It would have made sense to keep it separate.

Regards,

Leif

> 
> Regards,
> Jian
> 
> > Regards,
> > 
> > Leif
> > 
> > 
> > > Regards,
> > > Jian
> > > >
> > > >
> > > > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > > >
> > > > Thanks
> > > > Laszlo
> > >