From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web12.37785.1595252230394222240 for ; Mon, 20 Jul 2020 06:37:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=EwGgaeOn; spf=pass (domain: nuviainc.com, ip: 209.85.221.49, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f49.google.com with SMTP id 88so7609793wrh.3 for ; Mon, 20 Jul 2020 06:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4ODdxd7C5tX24YMUnnsDHc/n1ePmzXZAlsh10LDRT04=; b=EwGgaeOnhUQSJP5tOMOi0yr8sEFOXqe9P3Uk2TC+QP5UwYgQNVGRfkPX+HgdA9xTUn IUxcrviPlaszhamS5kpmwx2OoykdR49zWDps6oO+b0wzJB9HMgFJ6PlkEtDl2qecGaXH LswY7vbpvnhYggWv8Mt1mKIm+nrYTe8dbLr/3Dk7RpvXI7s8zT4aE9JiRUJXXsVpHw3Y JTRkyhcgypdh6XODIQdzYhnYryQK1+/8VrPHXSubQDPTG8ZojfJW2SRcqJeD4/RPUax9 f3pO4lVq8PjFrqH9yLebKCtNNu8tHh1UD57ADsI9iZh3aUUHh1yiaPYIugW44ECzIjwk P3NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4ODdxd7C5tX24YMUnnsDHc/n1ePmzXZAlsh10LDRT04=; b=McYLrtPsT9Dfyp9W71WdoqIvbiqaPJ71nkmb5wEB8LshqAueQT8IxdyaSUs1M9FZew eRWD3VdjBISxlAuLT1O7jzYOvpQeJdj4wlnYG5yKADxQaF5obsr/5v9X8/QA5LnZuQUM xIFl5csrzgshVgeFuF/DKNYQ1U49mo/WWJmzhGe1oEbl7gIGe1qry5U2vo8GV6F+iyzd ZgiQajP1SOg6N+3espNS+f37dHRn1YpXXWiBrlB56HbFaiDR9WlZeMVqU1WHEuEFJY7p DP6bEdBODngD8Ulgcg2NZaD/bZgclrqY4hC+nbadlUnlX1/C7Wgu3fvSsoF/QVa/J96N V9kg== X-Gm-Message-State: AOAM533O2CDWbFXJWG51NB3+cl4e+5sYzmXidkgxMMd2WXciLsrJmwhi ScuqycidPpzZPLfTSYd3lTQrgQ== X-Google-Smtp-Source: ABdhPJyCOhmFfjhm4dp4vjHsACdVL8KW+yAGUHcFxDblty6lLPBPQtucpPhyN6LPxDz28midEIve6A== X-Received: by 2002:a5d:5651:: with SMTP id j17mr21188766wrw.145.1595252228896; Mon, 20 Jul 2020 06:37:08 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id 65sm39283152wre.6.2020.07.20.06.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 06:37:08 -0700 (PDT) Date: Mon, 20 Jul 2020 14:37:06 +0100 From: "Leif Lindholm" To: "Wang, Jian J" Cc: Laszlo Ersek , "devel@edk2.groups.io" , "Yao, Jiewen" , Andrew Fish , "Kinney, Michael D" Subject: Re: [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes Message-ID: <20200720133706.GN12303@vanye> References: <20200716093154.862-1-jian.j.wang@intel.com> <1ddc75fb-a009-872b-6c9b-3ec5087acc5e@redhat.com> <20200717094949.GK12303@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 20, 2020 at 04:58:05 +0000, Wang, Jian J wrote: > Lief, > > > > -----Original Message----- > > From: Leif Lindholm > > Sent: Friday, July 17, 2020 5:50 PM > > To: Wang, Jian J > > Cc: Laszlo Ersek ; devel@edk2.groups.io; Yao, Jiewen > > ; Andrew Fish ; Kinney, Michael D > > > > Subject: Re: [PATCH] Maintainers.txt: Remove invalid email address and a few > > other role changes > > > > On Fri, Jul 17, 2020 at 07:41:40 +0000, Wang, Jian J wrote: > > > > > SecurityPkg: Secure boot related modules > > > > > F: SecurityPkg/Library/DxeImageVerificationLib/ > > > > > @@ -480,8 +480,7 @@ M: Zhichao Gao > > > > > SignedCapsulePkg > > > > > F: SignedCapsulePkg/ > > > > > W: > > https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg > > > > > -M: Jiewen Yao > > > > > -M: Chao Zhang > > > > > +M: Jian J Wang > > > > > > > > > > SourceLevelDebugPkg > > > > > F: SourceLevelDebugPkg/ > > > > > > > > > > > > > If Chao still has access to his @intel.com email address (just working > > > > in a different role), then it would be nice if he could send an ACK. > > > > > > > > (The commit message says Chao has left the community, which I understand > > > > to be the upstream edk2 project; so in theory his Intel email address > > > > could still function. On the other hand, the subject line says the email > > > > address is now "invalid", so I can't really tell.) > > > > > > Sorry I brought confusions to you. Actually he left both Intel and community > > > so the email address is not valid any more. I don' t have his new address and > > > cannot notify him in this mailing list. But I did get his ACK through WeChat. > > > > OK. This is not a very unusual situation. > > > > However, given that, can we break out Chao from this patch and merge > > it separately, stating those reasons. If the commit message says so, > > the patch is sent by an Intel employee and we can have a reviewed-by > > from another Intel employee (like we did for Supreeth for uefi-sct), I > > think that would make the history very clear. > > > > I already pushed the patch before noticing your comment. Sorry for it. > I'm not sure I get your point. Do you mean I could send the patch in the > name of Chao but R-B by me or others? Or I should have separated one > maintainer change from other changes in different patches? Some of the changes were trivial and just moving people around. Does not require steward review. The removal of Chao without possibility for them to give an R-b is a special case and needs some form of due diligence to verify that the right thing is happening. A reviewed-by from a steward is one way to do so. It would have made sense to keep it separate. Regards, Leif > > Regards, > Jian > > > Regards, > > > > Leif > > > > > > > Regards, > > > Jian > > > > > > > > > > > > Acked-by: Laszlo Ersek > > > > > > > > Thanks > > > > Laszlo > > >