public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Zhichao Gao <zhichao.gao@intel.com>,
	Sami Mujawar <Sami.Mujawar@arm.com>
Subject: [PATCH v1 1/1] ShellPkg: smbiosview - Change some type 17 field values format
Date: Mon, 20 Jul 2020 15:32:31 -0400	[thread overview]
Message-ID: <20200720193231.4560-1-Samer.El-Haj-Mahmoud@arm.com> (raw)

Change how some SMBIOS TYpe 17 field values are printed:

 - TotalWidth, DataWidth, ConfiguredMemoryClockSpeed: Print as
   hex values instead of decimal, since there are some special meanings
   for certain values (e.g. 0xFFFF)
 - VolatileSize, NonVolatileSize, CacheSize, and LogicalSize: Print
   as "0x%lx" instead of "0x%x" to prevent truncating output when
   printing these QWORD fields.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Sami Mujawar <Sami.Mujawar@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 1ea7b84bd0fa..7517465ddd49 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -746,8 +746,8 @@ SmbiosPrintStructure (
   case 17:
     PRINT_STRUCT_VALUE_H (Struct, Type17, MemoryArrayHandle);
     PRINT_STRUCT_VALUE_H (Struct, Type17, MemoryErrorInformationHandle);
-    PRINT_STRUCT_VALUE (Struct, Type17, TotalWidth);
-    PRINT_STRUCT_VALUE (Struct, Type17, DataWidth);
+    PRINT_STRUCT_VALUE_H (Struct, Type17, TotalWidth);
+    PRINT_STRUCT_VALUE_H (Struct, Type17, DataWidth);
     PRINT_STRUCT_VALUE (Struct, Type17, Size);
     DisplayMemoryDeviceFormFactor (Struct->Type17->FormFactor, Option);
     PRINT_STRUCT_VALUE_H (Struct, Type17, DeviceSet);
@@ -765,7 +765,7 @@ SmbiosPrintStructure (
     }
     if (AE_SMBIOS_VERSION (0x2, 0x7) && (Struct->Hdr->Length > 0x1C)) {
       PRINT_STRUCT_VALUE (Struct, Type17, ExtendedSize);
-      PRINT_STRUCT_VALUE (Struct, Type17, ConfiguredMemoryClockSpeed);
+      PRINT_STRUCT_VALUE_H (Struct, Type17, ConfiguredMemoryClockSpeed);
     }
     if (AE_SMBIOS_VERSION (0x2, 0x8) && (Struct->Hdr->Length > 0x22)) {
       PRINT_STRUCT_VALUE (Struct, Type17, MinimumVoltage);
@@ -783,16 +783,16 @@ SmbiosPrintStructure (
         PRINT_STRUCT_VALUE_H (Struct, Type17, MemorySubsystemControllerProductID);
       }
       if (Struct->Hdr->Length > 0x34) {
-        PRINT_STRUCT_VALUE_H (Struct, Type17, NonVolatileSize);
+        PRINT_STRUCT_VALUE_LH (Struct, Type17, NonVolatileSize);
       }
       if (Struct->Hdr->Length > 0x3C) {
-        PRINT_STRUCT_VALUE_H (Struct, Type17, VolatileSize);
+        PRINT_STRUCT_VALUE_LH (Struct, Type17, VolatileSize);
       }
       if (Struct->Hdr->Length > 0x44) {
-        PRINT_STRUCT_VALUE_H (Struct, Type17, CacheSize);
+        PRINT_STRUCT_VALUE_LH (Struct, Type17, CacheSize);
       }
       if (Struct->Hdr->Length > 0x4C) {
-        PRINT_STRUCT_VALUE_H (Struct, Type17, LogicalSize);
+        PRINT_STRUCT_VALUE_LH (Struct, Type17, LogicalSize);
       }
     }
     break;
-- 
2.17.1


             reply	other threads:[~2020-07-20 19:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 19:32 Samer El-Haj-Mahmoud [this message]
2020-08-04  1:33 ` [PATCH v1 1/1] ShellPkg: smbiosview - Change some type 17 field values format Gao, Zhichao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720193231.4560-1-Samer.El-Haj-Mahmoud@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox