From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.3207.1595273561091845099 for ; Mon, 20 Jul 2020 12:32:41 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: samer.el-haj-mahmoud@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E52F106F; Mon, 20 Jul 2020 12:32:40 -0700 (PDT) Received: from U203705.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 403EE3F66F; Mon, 20 Jul 2020 12:32:40 -0700 (PDT) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Ray Ni , Zhichao Gao , Sami Mujawar Subject: [PATCH v1 1/1] ShellPkg: smbiosview - Change some type 17 field values format Date: Mon, 20 Jul 2020 15:32:31 -0400 Message-Id: <20200720193231.4560-1-Samer.El-Haj-Mahmoud@arm.com> X-Mailer: git-send-email 2.17.1 Change how some SMBIOS TYpe 17 field values are printed: - TotalWidth, DataWidth, ConfiguredMemoryClockSpeed: Print as hex values instead of decimal, since there are some special meanings for certain values (e.g. 0xFFFF) - VolatileSize, NonVolatileSize, CacheSize, and LogicalSize: Print as "0x%lx" instead of "0x%x" to prevent truncating output when printing these QWORD fields. Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Samer El-Haj-Mahmoud --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index 1ea7b84bd0fa..7517465ddd49 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -746,8 +746,8 @@ SmbiosPrintStructure ( case 17: PRINT_STRUCT_VALUE_H (Struct, Type17, MemoryArrayHandle); PRINT_STRUCT_VALUE_H (Struct, Type17, MemoryErrorInformationHandle); - PRINT_STRUCT_VALUE (Struct, Type17, TotalWidth); - PRINT_STRUCT_VALUE (Struct, Type17, DataWidth); + PRINT_STRUCT_VALUE_H (Struct, Type17, TotalWidth); + PRINT_STRUCT_VALUE_H (Struct, Type17, DataWidth); PRINT_STRUCT_VALUE (Struct, Type17, Size); DisplayMemoryDeviceFormFactor (Struct->Type17->FormFactor, Option); PRINT_STRUCT_VALUE_H (Struct, Type17, DeviceSet); @@ -765,7 +765,7 @@ SmbiosPrintStructure ( } if (AE_SMBIOS_VERSION (0x2, 0x7) && (Struct->Hdr->Length > 0x1C)) { PRINT_STRUCT_VALUE (Struct, Type17, ExtendedSize); - PRINT_STRUCT_VALUE (Struct, Type17, ConfiguredMemoryClockSpeed); + PRINT_STRUCT_VALUE_H (Struct, Type17, ConfiguredMemoryClockSpeed); } if (AE_SMBIOS_VERSION (0x2, 0x8) && (Struct->Hdr->Length > 0x22)) { PRINT_STRUCT_VALUE (Struct, Type17, MinimumVoltage); @@ -783,16 +783,16 @@ SmbiosPrintStructure ( PRINT_STRUCT_VALUE_H (Struct, Type17, MemorySubsystemControllerProductID); } if (Struct->Hdr->Length > 0x34) { - PRINT_STRUCT_VALUE_H (Struct, Type17, NonVolatileSize); + PRINT_STRUCT_VALUE_LH (Struct, Type17, NonVolatileSize); } if (Struct->Hdr->Length > 0x3C) { - PRINT_STRUCT_VALUE_H (Struct, Type17, VolatileSize); + PRINT_STRUCT_VALUE_LH (Struct, Type17, VolatileSize); } if (Struct->Hdr->Length > 0x44) { - PRINT_STRUCT_VALUE_H (Struct, Type17, CacheSize); + PRINT_STRUCT_VALUE_LH (Struct, Type17, CacheSize); } if (Struct->Hdr->Length > 0x4C) { - PRINT_STRUCT_VALUE_H (Struct, Type17, LogicalSize); + PRINT_STRUCT_VALUE_LH (Struct, Type17, LogicalSize); } } break; -- 2.17.1