From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>, Pete Batard <pete@akeo.ie>,
Andrei Warkentin <awarkentin@vmware.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: [edk2-platform][PATCH v1 2/3] Platforms/RaspberryPi: Return GOP PixelInformation in QueryMode()
Date: Tue, 21 Jul 2020 22:01:02 -0400 [thread overview]
Message-ID: <20200722020103.11808-3-Samer.El-Haj-Mahmoud@arm.com> (raw)
In-Reply-To: <20200722020103.11808-1-Samer.El-Haj-Mahmoud@arm.com>
Return correct values of PixelInformation in QueryMode().
This fixes the QueryMode_Func failures reported by SCT tests at
https://github.com/pftf/RPi4/issues/73
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
index 80d0f7b2cb3c..f50ffc816cf1 100644
--- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
+++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
@@ -191,6 +191,10 @@ DisplayQueryMode (
(*Info)->HorizontalResolution = Mode->Width;
(*Info)->VerticalResolution = Mode->Height;
(*Info)->PixelFormat = This->Mode->Info->PixelFormat;
+ (*Info)->PixelInformation.RedMask = This->Mode->Info->PixelInformation.RedMask;
+ (*Info)->PixelInformation.GreenMask = This->Mode->Info->PixelInformation.GreenMask;
+ (*Info)->PixelInformation.BlueMask = This->Mode->Info->PixelInformation.BlueMask;
+ (*Info)->PixelInformation.ReservedMask = This->Mode->Info->PixelInformation.ReservedMask;
(*Info)->PixelsPerScanLine = Mode->Width;
return EFI_SUCCESS;
--
2.17.1
next prev parent reply other threads:[~2020-07-22 2:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 2:01 [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : SCT EFI_GRAPHICS_OUTPUT_PROTOCOL fixes Samer El-Haj-Mahmoud
2020-07-22 2:01 ` [edk2-platform][PATCH v1 1/3] Platforms/RaspberryPi: Fix GOP parameter handling Samer El-Haj-Mahmoud
2020-07-22 4:31 ` Andrei Warkentin
2020-07-22 2:01 ` Samer El-Haj-Mahmoud [this message]
2020-07-22 4:31 ` [edk2-platform][PATCH v1 2/3] Platforms/RaspberryPi: Return GOP PixelInformation in QueryMode() Andrei Warkentin
2020-07-22 2:01 ` [edk2-platform][PATCH v1 3/3] Platforms/RaspberryPi: Fix GOP FrameBufferSize returned by SetMode() Samer El-Haj-Mahmoud
2020-07-22 4:32 ` Andrei Warkentin
2020-07-22 19:47 ` [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : SCT EFI_GRAPHICS_OUTPUT_PROTOCOL fixes Andrei Warkentin
2020-08-13 13:50 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722020103.11808-3-Samer.El-Haj-Mahmoud@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox