From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.8304.1595495045981621054 for ; Thu, 23 Jul 2020 02:04:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=FDv5X7pN; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id q5so4391899wru.6 for ; Thu, 23 Jul 2020 02:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XAKV1BZQTnGgLmd+jIvakXfs9gMUgIRXyuKk/HZ5Q1w=; b=FDv5X7pNpaVldAycttjGdaA7uO51GOHE9qpeCmbsaPVuii13fGoXwffXwS8ceufFxf Af0HD+vSLXUMPukFM31M49qIsFgFpZQ5oDWki2CX8ZWMhKYY/zBSTCHr6hOMPDGFSInw Ane0lF5skp5lu9OdvoCjb0aIjWfKOy8tAqo806zP6GuWAEQzLB7rCQZ0nMEG3v32hOKk rXh8FLIgcKbEnTI9rLYOujOCuQjsEqG9yIfuHU2GQcPihEb2PFTf04JQgU8t9M5wIsGp djlPHgH1E+XJGTk3TBBHUKOp+LToN6tjffOL173b9dJIo+L7+IT6Pyw6S4J6ElpqCWP0 jfOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XAKV1BZQTnGgLmd+jIvakXfs9gMUgIRXyuKk/HZ5Q1w=; b=p4yvoQVtG5oR063guj0bnbPjhjHJLKaua8jOffKYjgj1Mbo+34fb8lel8VN7ab69Ze SHlvpq/ptUnXHO+ZGX3K02Y33pvCzW4DoFPNnciOmF8fXksER6e2CqIUXTH6X1i6I5AH bE/RGce0dvTy0LuC99fuz36J1AIAJJ4LpnYCLeX6+Ix6w1SmPE88zAhNbqOJWmo7PgZx oM2oxczN6/CpFrkFNuJ7XZSmsuTqpCAn3syowdBO7wF6bvshUI36tPCn4uZc8E5QSGj4 MP0W24wOHoLiwIICoXBSCclpLn+ztjxw9YF6+LujSjpHo16rlWeBc79WKwyEoagm9r0d M2FA== X-Gm-Message-State: AOAM530Kt1BobMF+wLi5ZeDBf7VrIJT3hWB7Pwe9q4LdijE87lgpt4Kc irwvdTSxyqZ9o5JrxEE11vrWjw== X-Google-Smtp-Source: ABdhPJy1vsphn0SiK81I1BEqfnhO+qsrUzZ+lEJHzjm0IqpGy82caYFrgibKKyzlohWYOu/e1S2k6w== X-Received: by 2002:a5d:6309:: with SMTP id i9mr3086488wru.245.1595495044361; Thu, 23 Jul 2020 02:04:04 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id u16sm2671290wmn.11.2020.07.23.02.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 02:04:03 -0700 (PDT) Date: Thu, 23 Jul 2020 10:04:01 +0100 From: "Leif Lindholm" To: Bob Feng Cc: devel@edk2.groups.io, Pierre Gondois , Andrew Fish , Michael D Kinney , Liming Gao Subject: Re: [Patch] Revert "BaseTools: Add gcc flag to warn on void* pointer arithmetic" Message-ID: <20200723090401.GI1337@vanye> References: <20200723004129.27708-1-bob.c.feng@intel.com> MIME-Version: 1.0 In-Reply-To: <20200723004129.27708-1-bob.c.feng@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 23, 2020 at 08:41:29 +0800, Bob Feng wrote: > This reverts commit dbd546a32d5abe225306e22d43a7d86e3a042eee. > > This patch also breaks about half of the ARM/AARCH64 platforms in edk2-platforms > > Signed-off-by: Bob Feng Reviewed-by: Leif Lindholm Thanks! > Cc: Pierre Gondois > Cc: Leif Lindholm > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > --- > BaseTools/Conf/tools_def.template | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index a1fd27b1ad..933b3160fd 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1,9 +1,9 @@ > # > # Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
> -# Portions copyright (c) 2011 - 2020, ARM Ltd. All rights reserved.
> +# Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.
> # Copyright (c) 2015, Hewlett-Packard Development Company, L.P.
> # (C) Copyright 2020, Hewlett Packard Enterprise Development LP
> # Copyright (c) Microsoft Corporation > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -1919,13 +1919,13 @@ NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_N > *_*_*_DTC_PATH = DEF(DTC_BIN) > > DEFINE GCC_ALL_CC_FLAGS = -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common > DEFINE GCC_IA32_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -m32 -malign-double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-probe > DEFINE GCC_X64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mno-red-zone -Wno-address -mno-stack-arg-probe > -DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -Wpointer-arith -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft -fno-pic -fno-pie > +DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft -fno-pic -fno-pie > DEFINE GCC_ARM_CC_XIPFLAGS = -mno-unaligned-access > -DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -Wpointer-arith -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables -fno-pic -fno-pie -ffixed-x18 > +DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables -fno-pic -fno-pie -ffixed-x18 > DEFINE GCC_AARCH64_CC_XIPFLAGS = -mstrict-align -mgeneral-regs-only > DEFINE GCC_DLINK_FLAGS_COMMON = -nostdlib --pie > DEFINE GCC_DLINK2_FLAGS_COMMON = -Wl,--script=$(EDK_TOOLS_PATH)/Scripts/GccBase.lds > DEFINE GCC_IA32_X64_DLINK_COMMON = DEF(GCC_DLINK_FLAGS_COMMON) --gc-sections > DEFINE GCC_ARM_AARCH64_DLINK_COMMON= -Wl,--emit-relocs -nostdlib -Wl,--gc-sections -u $(IMAGE_ENTRY_POINT) -Wl,-e,$(IMAGE_ENTRY_POINT),-Map,$(DEST_DIR_DEBUG)/$(BASE_NAME).map > -- > 2.20.1.windows.1 >