public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Meenakshi Aggarwal <meenakshi.aggarwal@oss.nxp.com>
Cc: ard.biesheuvel@arm.com, michael.d.kinney@intel.com,
	devel@edk2.groups.io, v.sethi@nxp.com
Subject: Re: [edk2-platforms] [PATCH v3 0/2] Add USB driver support
Date: Fri, 24 Jul 2020 17:47:02 +0100	[thread overview]
Message-ID: <20200724164702.GT1337@vanye> (raw)
In-Reply-To: <1594325036-10606-1-git-send-email-meenakshi.aggarwal@oss.nxp.com>

On Fri, Jul 10, 2020 at 01:33:54 +0530, Meenakshi Aggarwal wrote:
> This patchset implement USB driver for DWC3 controller and enable
> USB for LX2160A Platform.
> 
> Changes in v2:
> 	- Indentation changes
> 	- Incorporated review comments
> 	- create EndOfDxe event and initialize USB in EndOfDxe
> 	  callback function.
> 
> Changes in v3:
> 	- Passing Usb initialization function as init function
> 	  of RegisterNonDiscoverableMmioDevice()
> 
> Meenakshi Aggarwal (2):
>   Silicon/NXP: Add DWC3 USB controller initialization driver
>   Platform/NXP:LX2160: Enable support of USB controller

For series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

However, in future, please rebase patches onto current master before
sumitting later revisions. This set conflicted with 7c552c1a2611
("Platform/NXP: LX2160aRdbPkg: Enable PlatformDxe driver") which was
pushed on 3 July.

Pushed (together with SATA series previously reviewed) as:
b972f17b329a..7de21b6aa3e0

>  Silicon/NXP/NxpQoriqLs.dec                   |   5 +
>  Silicon/NXP/LX2160A/LX2160A.dsc.inc          |   4 +
>  Silicon/NXP/NxpQoriqLs.dsc.inc               |  12 +
>  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc |   1 +
>  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf |  18 +-
>  Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf |  45 ++++
>  Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.h   | 138 ++++++++++
>  Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.c   | 275 ++++++++++++++++++++
>  8 files changed, 495 insertions(+), 3 deletions(-)
>  create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf
>  create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.h
>  create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.c
> 
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2020-07-24 16:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02 13:47 [PATCH edk2-platforms 0/2] Add USB driver support Meenakshi Aggarwal
2020-06-02 13:47 ` [PATCH edk2-platforms 1/2] Silicon/NXP: Add DWC3 USB controller initialization driver Meenakshi Aggarwal
2020-06-02  8:43   ` Ard Biesheuvel
2020-06-02 13:47 ` [PATCH edk2-platforms 2/2] Platform/NXP:LX2160: Enable support of USB controller Meenakshi Aggarwal
2020-06-03 16:00 ` [PATCH edk2-platforms V2 0/2] Add USB driver support Meenakshi Aggarwal
2020-06-03 16:00   ` [PATCH edk2-platforms V2 1/2] Silicon/NXP: Add DWC3 USB controller initialization driver Meenakshi Aggarwal
2020-06-12 10:29     ` Ard Biesheuvel
2020-06-03 16:00   ` [PATCH edk2-platforms V2 2/2] Platform/NXP:LX2160: Enable support of USB controller Meenakshi Aggarwal
2020-07-09 20:03   ` [edk2-platforms] [PATCH v3 0/2] Add USB driver support Meenakshi Aggarwal
2020-07-09 20:03     ` [edk2-platforms] [PATCH v3 1/2] Silicon/NXP: Add DWC3 USB controller initialization driver Meenakshi Aggarwal
2020-07-09 20:03     ` [edk2-platforms] [PATCH v3 2/2] Platform/NXP:LX2160: Enable support of USB controller Meenakshi Aggarwal
     [not found]     ` <VI1PR04MB45920207F1DCBCDC64B8918CE87B0@VI1PR04MB4592.eurprd04.prod.outlook.com>
2020-07-20  6:26       ` [edk2-platforms] [PATCH v3 0/2] Add USB driver support Meenakshi Aggarwal
2020-07-24 16:47     ` Leif Lindholm [this message]
2020-07-27  5:29       ` Meenakshi Aggarwal (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724164702.GT1337@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox