From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.74.1595609226292094817 for ; Fri, 24 Jul 2020 09:47:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=f2bAHcWG; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id f18so8839625wml.3 for ; Fri, 24 Jul 2020 09:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SKKEqgL4FSNaHAgUC0tXtwh5Bt/sk2+AN38YvsTMGJA=; b=f2bAHcWGKE7DZcYfyMTJgRWX9o4s/kBSbK3fmXFDhfSCWT/iIBQMgmeMyaV8ZwZqa7 JIxObaL0d8lHRGE633HgGoeCh+8FdNaJnUcd/h7n4oPG2A+sWbg1o6gC5TrM9Dk4+r2y uutj8cUFidBwJZinmID6ScvpTvKIMQum00+DGD858Hbf7dmhOFci/veS3GEdfaTS274a MX734o+rPMClZi15Nrmt+2TNOln+MlvQtxmGejrBZTRVx+wcgj/qjMsMsC+BcnH4ZGwZ aYKmUAad/sWVJaMHCc2bTy1ADz8eKkDmhPwwRMfk5mnzlW5W9Gjhk1mw//a9yw0292VZ 0deQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SKKEqgL4FSNaHAgUC0tXtwh5Bt/sk2+AN38YvsTMGJA=; b=e5JTiV7uzBIGW3Fj5KCs5DsWJYySJ18y0QKjzmJqy4nklvmXuJ8wtjFoiZgsLsyMOP 8sQZvFMlEOE9SkL8JuoO7ZobBsgITZB4Idc6xjm/ZjxTa9XvhVJltbLHwiYFEnLxdAwM UXdq0+MPDWyW0ag2YesIGnmmMK4UE4BvhpFTtMQ5nRI5kxp8tBazKIbOlMYUToh9Vl/J taAVPYtiiyx4SixzJVs4lZMmksq+eJwecBqQgH1MD/erbsb8dzlfpfuaHaitfDD2PcH6 l95Rb14Z6+8k1dSaMfxiLG97OJVTdkVVcsRldfgYiVk1GOSSjBiIXzin/fqoWXvEoi8m AbPg== X-Gm-Message-State: AOAM532/+w3lw+fVAk+P2O2G1bhCHX/NNmwKUuMW57mHpbd044WAY0lz 3HS4aUN4hJDkyhJnUdTZHcry9A== X-Google-Smtp-Source: ABdhPJzdTEN7eo3Cx83xhfR5+jlSvFt/wCUYPPzcIKEG0Fy+2AaJ8vDfX3gz/k0g1H5CVt36iMHJAQ== X-Received: by 2002:a1c:4c0e:: with SMTP id z14mr9474017wmf.54.1595609224797; Fri, 24 Jul 2020 09:47:04 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id 1sm7565116wmf.21.2020.07.24.09.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 09:47:04 -0700 (PDT) Date: Fri, 24 Jul 2020 17:47:02 +0100 From: "Leif Lindholm" To: Meenakshi Aggarwal Cc: ard.biesheuvel@arm.com, michael.d.kinney@intel.com, devel@edk2.groups.io, v.sethi@nxp.com Subject: Re: [edk2-platforms] [PATCH v3 0/2] Add USB driver support Message-ID: <20200724164702.GT1337@vanye> References: <1591200042-11232-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> <1594325036-10606-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <1594325036-10606-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 10, 2020 at 01:33:54 +0530, Meenakshi Aggarwal wrote: > This patchset implement USB driver for DWC3 controller and enable > USB for LX2160A Platform. > > Changes in v2: > - Indentation changes > - Incorporated review comments > - create EndOfDxe event and initialize USB in EndOfDxe > callback function. > > Changes in v3: > - Passing Usb initialization function as init function > of RegisterNonDiscoverableMmioDevice() > > Meenakshi Aggarwal (2): > Silicon/NXP: Add DWC3 USB controller initialization driver > Platform/NXP:LX2160: Enable support of USB controller For series: Reviewed-by: Leif Lindholm However, in future, please rebase patches onto current master before sumitting later revisions. This set conflicted with 7c552c1a2611 ("Platform/NXP: LX2160aRdbPkg: Enable PlatformDxe driver") which was pushed on 3 July. Pushed (together with SATA series previously reviewed) as: b972f17b329a..7de21b6aa3e0 > Silicon/NXP/NxpQoriqLs.dec | 5 + > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 4 + > Silicon/NXP/NxpQoriqLs.dsc.inc | 12 + > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 1 + > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 18 +- > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf | 45 ++++ > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.h | 138 ++++++++++ > Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.c | 275 ++++++++++++++++++++ > 8 files changed, 495 insertions(+), 3 deletions(-) > create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf > create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.h > create mode 100644 Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.c > > -- > 1.9.1 >