* [PATCH] BaseTools/PeCoffLoaderEx: Remove the unused local variable
@ 2020-07-25 2:34 Abner Chang
2020-07-29 2:58 ` [edk2-devel] " Liming Gao
0 siblings, 1 reply; 2+ messages in thread
From: Abner Chang @ 2020-07-25 2:34 UTC (permalink / raw)
To: devel; +Cc: abner.chang, Bob Feng, Liming Gao, Daniel Schaefer
BZ:2864 GCC build fails due to variable self assignment.
This local variable is not used at any where, we can just remove it.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
BaseTools/Source/C/Common/PeCoffLoaderEx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/BaseTools/Source/C/Common/PeCoffLoaderEx.c b/BaseTools/Source/C/Common/PeCoffLoaderEx.c
index 588b3a2f84..799f282970 100644
--- a/BaseTools/Source/C/Common/PeCoffLoaderEx.c
+++ b/BaseTools/Source/C/Common/PeCoffLoaderEx.c
@@ -127,10 +127,7 @@ PeCoffLoaderRelocateRiscVImage (
{
UINT32 Value;
UINT32 Value2;
- UINT32 OrgValue;
- OrgValue = *(UINT32 *) Fixup;
- OrgValue = OrgValue;
switch ((*Reloc) >> 12) {
case EFI_IMAGE_REL_BASED_RISCV_HI20:
RiscVHi20Fixup = (UINT32 *) Fixup;
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [edk2-devel] [PATCH] BaseTools/PeCoffLoaderEx: Remove the unused local variable
2020-07-25 2:34 [PATCH] BaseTools/PeCoffLoaderEx: Remove the unused local variable Abner Chang
@ 2020-07-29 2:58 ` Liming Gao
0 siblings, 0 replies; 2+ messages in thread
From: Liming Gao @ 2020-07-29 2:58 UTC (permalink / raw)
To: devel@edk2.groups.io, abner.chang@hpe.com; +Cc: Feng, Bob C, Daniel Schaefer
Reviewed-by: Liming Gao <liming.gao@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang
Sent: 2020年7月25日 10:35
To: devel@edk2.groups.io
Cc: abner.chang@hpe.com; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Daniel Schaefer <daniel.schaefer@hpe.com>
Subject: [edk2-devel] [PATCH] BaseTools/PeCoffLoaderEx: Remove the unused local variable
BZ:2864 GCC build fails due to variable self assignment.
This local variable is not used at any where, we can just remove it.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
BaseTools/Source/C/Common/PeCoffLoaderEx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/BaseTools/Source/C/Common/PeCoffLoaderEx.c b/BaseTools/Source/C/Common/PeCoffLoaderEx.c
index 588b3a2f84..799f282970 100644
--- a/BaseTools/Source/C/Common/PeCoffLoaderEx.c
+++ b/BaseTools/Source/C/Common/PeCoffLoaderEx.c
@@ -127,10 +127,7 @@ PeCoffLoaderRelocateRiscVImage (
{ UINT32 Value; UINT32 Value2;- UINT32 OrgValue; - OrgValue = *(UINT32 *) Fixup;- OrgValue = OrgValue; switch ((*Reloc) >> 12) { case EFI_IMAGE_REL_BASED_RISCV_HI20: RiscVHi20Fixup = (UINT32 *) Fixup;--
2.25.0
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63269): https://edk2.groups.io/g/devel/message/63269
Mute This Topic: https://groups.io/mt/75779823/1759384
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] -=-=-=-=-=-=
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-29 2:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-25 2:34 [PATCH] BaseTools/PeCoffLoaderEx: Remove the unused local variable Abner Chang
2020-07-29 2:58 ` [edk2-devel] " Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox