* [PATCH edk2-platforms 1/1] Silicon/Socionext: rename Emmc.c to fix build error
@ 2020-07-29 0:58 Masahisa Kojima
2020-07-29 11:34 ` [edk2-devel] " Leif Lindholm
0 siblings, 1 reply; 2+ messages in thread
From: Masahisa Kojima @ 2020-07-29 0:58 UTC (permalink / raw)
To: devel
Cc: leif, ard.biesheuvel, sami.mujawar, tomas.pilar, bob.c.feng,
liming.gao, Masahisa Kojima, Pierre Gondois
Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/ has both an Emmc.asl
and an Emmc.c file, which the patch(edk2 commit:0a4aa20e8d446 "BaseTools:
Compile AML bytecode arrays into .obj file") both generate an Emmc.obj
in the same output directory.
To fix the build error for Developerbox platform, this patch renames
the Emmc.c.
Suggested-by: Leif Lindholm <leif@nuviainc.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
---
Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 2 +-
Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/{Emmc.c => EmmcDxe.c} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
index aa3cbdf35c73..74bbd2d48b30 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
@@ -18,7 +18,7 @@ [Defines]
[Sources]
Emmc.asl
- Emmc.c
+ EmmcDxe.c
Optee.asl
Pci.c
PlatformDxe.c
diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/EmmcDxe.c
similarity index 100%
rename from Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c
rename to Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/EmmcDxe.c
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Socionext: rename Emmc.c to fix build error
2020-07-29 0:58 [PATCH edk2-platforms 1/1] Silicon/Socionext: rename Emmc.c to fix build error Masahisa Kojima
@ 2020-07-29 11:34 ` Leif Lindholm
0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2020-07-29 11:34 UTC (permalink / raw)
To: devel, masahisa.kojima
Cc: ard.biesheuvel, sami.mujawar, tomas.pilar, bob.c.feng, liming.gao,
Pierre Gondois
On Wed, Jul 29, 2020 at 09:58:20 +0900, Masahisa Kojima wrote:
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/ has both an Emmc.asl
> and an Emmc.c file, which the patch(edk2 commit:0a4aa20e8d446 "BaseTools:
> Compile AML bytecode arrays into .obj file") both generate an Emmc.obj
> in the same output directory.
>
> To fix the build error for Developerbox platform, this patch renames
> the Emmc.c.
>
> Suggested-by: Leif Lindholm <leif@nuviainc.com>
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
I have pushed this one, followed by
- Silicon/SynQuacer: add ACPI descriptor of MMIO TPM
- Silicon/SynQuacer: CRLF fixup for Acpi.dsc.inc
as a8eecf187198..deb1988e3b18.
Thanks!
> ---
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 2 +-
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/{Emmc.c => EmmcDxe.c} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> index aa3cbdf35c73..74bbd2d48b30 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -18,7 +18,7 @@ [Defines]
>
> [Sources]
> Emmc.asl
> - Emmc.c
> + EmmcDxe.c
> Optee.asl
> Pci.c
> PlatformDxe.c
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/EmmcDxe.c
> similarity index 100%
> rename from Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c
> rename to Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/EmmcDxe.c
> --
> 2.17.1
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-29 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-29 0:58 [PATCH edk2-platforms 1/1] Silicon/Socionext: rename Emmc.c to fix build error Masahisa Kojima
2020-07-29 11:34 ` [edk2-devel] " Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox