public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: devel@edk2.groups.io, masahisa.kojima@linaro.org
Cc: ard.biesheuvel@arm.com, sami.mujawar@arm.com,
	tomas.pilar@arm.com, bob.c.feng@intel.com, liming.gao@intel.com,
	Pierre Gondois <Pierre.Gondois@arm.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Socionext: rename Emmc.c to fix build error
Date: Wed, 29 Jul 2020 12:34:58 +0100	[thread overview]
Message-ID: <20200729113458.GF31778@vanye> (raw)
In-Reply-To: <20200729005820.26499-1-masahisa.kojima@linaro.org>

On Wed, Jul 29, 2020 at 09:58:20 +0900, Masahisa Kojima wrote:
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/ has both an Emmc.asl
> and an Emmc.c file, which the patch(edk2 commit:0a4aa20e8d446 "BaseTools:
> Compile AML bytecode arrays into .obj file") both generate an Emmc.obj
> in the same output directory.
> 
> To fix the build error for Developerbox platform, this patch renames
> the Emmc.c.
> 
> Suggested-by: Leif Lindholm <leif@nuviainc.com>
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

I have pushed this one, followed by
- Silicon/SynQuacer: add ACPI descriptor of MMIO TPM
- Silicon/SynQuacer: CRLF fixup for Acpi.dsc.inc
as a8eecf187198..deb1988e3b18.

Thanks!

> ---
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf       | 2 +-
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/{Emmc.c => EmmcDxe.c} | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> index aa3cbdf35c73..74bbd2d48b30 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -18,7 +18,7 @@ [Defines]
>  
>  [Sources]
>    Emmc.asl
> -  Emmc.c
> +  EmmcDxe.c
>    Optee.asl
>    Pci.c
>    PlatformDxe.c
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/EmmcDxe.c
> similarity index 100%
> rename from Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c
> rename to Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/EmmcDxe.c
> -- 
> 2.17.1
> 
> 
> 
> 

      reply	other threads:[~2020-07-29 11:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29  0:58 [PATCH edk2-platforms 1/1] Silicon/Socionext: rename Emmc.c to fix build error Masahisa Kojima
2020-07-29 11:34 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729113458.GF31778@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox