public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests
@ 2020-08-03 22:50 Bret Barkelew
  2020-08-04  0:22 ` [EXTERNAL] " Bret Barkelew
  0 siblings, 1 reply; 2+ messages in thread
From: Bret Barkelew @ 2020-08-03 22:50 UTC (permalink / raw)
  To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao

Update the CI invocable that builds host-based unit tests to make
sure that BUILDREPORT is built for all tests. This is useful for
determining which libraries were consumed in the build.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 .pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py b/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
index f21b40caf291..43abd1f4795b 100644
--- a/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
+++ b/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
@@ -86,6 +86,8 @@ class HostUnitTestCompilerPlugin(ICiBuildPlugin):
     def RunBuildPlugin(self, packagename, Edk2pathObj, pkgconfig, environment, PLM, PLMHelper, tc, output_stream=None):
         self._env = environment
         environment.SetValue("CI_BUILD_TYPE", "host_unit_test", "Set in HostUnitTestCompilerPlugin")
+        environment.SetValue("BUILDREPORTING", "TRUE", "Set in HostUnitTestCompilerPlugin")
+        environment.SetValue("BUILDREPORT_TYPES", "PCD DEPEX LIBRARY BUILD_FLAGS", "Set in HostUnitTestCompilerPlugin")
 
         # Parse the config for required DscPath element
         if "DscPath" not in pkgconfig:
-- 
2.27.0.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [EXTERNAL] [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests
  2020-08-03 22:50 [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests Bret Barkelew
@ 2020-08-04  0:22 ` Bret Barkelew
  0 siblings, 0 replies; 2+ messages in thread
From: Bret Barkelew @ 2020-08-04  0:22 UTC (permalink / raw)
  To: Bret Barkelew, devel@edk2.groups.io
  Cc: Sean Brogan, Kinney, Michael D, liming.gao

[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]

Second version (ignore the title) of this coming soon to update the regular builds and collect the artifacts.

- Bret

From: Bret Barkelew<mailto:bret@corthon.com>
Sent: Monday, August 3, 2020 3:50 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>; liming.gao<mailto:liming.gao@intel.com>
Subject: [EXTERNAL] [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests

Update the CI invocable that builds host-based unit tests to make
sure that BUILDREPORT is built for all tests. This is useful for
determining which libraries were consumed in the build.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 .pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py b/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
index f21b40caf291..43abd1f4795b 100644
--- a/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
+++ b/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
@@ -86,6 +86,8 @@ class HostUnitTestCompilerPlugin(ICiBuildPlugin):
     def RunBuildPlugin(self, packagename, Edk2pathObj, pkgconfig, environment, PLM, PLMHelper, tc, output_stream=None):

         self._env = environment

         environment.SetValue("CI_BUILD_TYPE", "host_unit_test", "Set in HostUnitTestCompilerPlugin")

+        environment.SetValue("BUILDREPORTING", "TRUE", "Set in HostUnitTestCompilerPlugin")

+        environment.SetValue("BUILDREPORT_TYPES", "PCD DEPEX LIBRARY BUILD_FLAGS", "Set in HostUnitTestCompilerPlugin")



         # Parse the config for required DscPath element

         if "DscPath" not in pkgconfig:

--
2.27.0.windows.1


[-- Attachment #2: Type: text/html, Size: 4514 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-04  0:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-03 22:50 [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests Bret Barkelew
2020-08-04  0:22 ` [EXTERNAL] " Bret Barkelew

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox