From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: devel@edk2.groups.io
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Eric Jin <eric.jin@intel.com>
Subject: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test
Date: Tue, 4 Aug 2020 08:00:59 -0400 [thread overview]
Message-ID: <20200804120059.24585-1-Samer.El-Haj-Mahmoud@arm.com> (raw)
The GUID of one of the EfiCompliant test cases is incorrect. The GUID
is defined in test case 5.22.1.2.12 in section 2.1.2 of
UEFI_SCTII_Case_Spec_2_6_A.pdf, which is available from UEFI Forum:
http://www.uefi.org/sites/default/files/resources/
UEFI2.6SCTII_Final_Release.zip
The GUID value is correct in the code
(gEfiCompliantBbTestPlatformAssertionGuid012), but not in Guid_uefi.h,
causing a disconnect between the data file and the code, which resulted
in the test case being omitted from SCT.
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Eric Jin <eric.jin@intel.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h
index 158231c46d37..7e3552bc99b1 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h
@@ -81,7 +81,7 @@ extern EFI_GUID gEfiCompliantBbTestPlatformAssertionGuid010;
extern EFI_GUID gEfiCompliantBbTestPlatformAssertionGuid011;
#define EFI_TEST_EFICOMPLIANTBBTESTPLATFORM_ASSERTION_012_GUID \
-{ 0x76A621B0, 0x8C53, 0x407d, {0x84, 0x86, 0x9a, 0x6e, 0x63, 0x32, 0xd3, 0xce }}
+{ 0x76A6A1B0, 0x8C53, 0x407d, {0x84, 0x86, 0x9a, 0x6e, 0x63, 0x32, 0xd3, 0xce }}
extern EFI_GUID gEfiCompliantBbTestPlatformAssertionGuid012;
--
2.17.1
next reply other threads:[~2020-08-04 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 12:00 Samer El-Haj-Mahmoud [this message]
2020-09-10 19:00 ` [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test G Edhaya Chandran
2020-09-14 19:17 ` G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804120059.24585-1-Samer.El-Haj-Mahmoud@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox