* [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test
@ 2020-08-04 12:00 Samer El-Haj-Mahmoud
2020-09-10 19:00 ` [edk2-devel] " G Edhaya Chandran
0 siblings, 1 reply; 3+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-08-04 12:00 UTC (permalink / raw)
To: devel; +Cc: G Edhaya Chandran, Eric Jin
The GUID of one of the EfiCompliant test cases is incorrect. The GUID
is defined in test case 5.22.1.2.12 in section 2.1.2 of
UEFI_SCTII_Case_Spec_2_6_A.pdf, which is available from UEFI Forum:
http://www.uefi.org/sites/default/files/resources/
UEFI2.6SCTII_Final_Release.zip
The GUID value is correct in the code
(gEfiCompliantBbTestPlatformAssertionGuid012), but not in Guid_uefi.h,
causing a disconnect between the data file and the code, which resulted
in the test case being omitted from SCT.
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Eric Jin <eric.jin@intel.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h
index 158231c46d37..7e3552bc99b1 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h
@@ -81,7 +81,7 @@ extern EFI_GUID gEfiCompliantBbTestPlatformAssertionGuid010;
extern EFI_GUID gEfiCompliantBbTestPlatformAssertionGuid011;
#define EFI_TEST_EFICOMPLIANTBBTESTPLATFORM_ASSERTION_012_GUID \
-{ 0x76A621B0, 0x8C53, 0x407d, {0x84, 0x86, 0x9a, 0x6e, 0x63, 0x32, 0xd3, 0xce }}
+{ 0x76A6A1B0, 0x8C53, 0x407d, {0x84, 0x86, 0x9a, 0x6e, 0x63, 0x32, 0xd3, 0xce }}
extern EFI_GUID gEfiCompliantBbTestPlatformAssertionGuid012;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test
2020-08-04 12:00 [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test Samer El-Haj-Mahmoud
@ 2020-09-10 19:00 ` G Edhaya Chandran
2020-09-14 19:17 ` G Edhaya Chandran
0 siblings, 1 reply; 3+ messages in thread
From: G Edhaya Chandran @ 2020-09-10 19:00 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud, devel
[-- Attachment #1: Type: text/plain, Size: 60 bytes --]
Reviewed-by: G Edhaya Chandran < edhaya.chandran@arm.com >
[-- Attachment #2: Type: text/html, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test
2020-09-10 19:00 ` [edk2-devel] " G Edhaya Chandran
@ 2020-09-14 19:17 ` G Edhaya Chandran
0 siblings, 0 replies; 3+ messages in thread
From: G Edhaya Chandran @ 2020-09-14 19:17 UTC (permalink / raw)
To: G Edhaya Chandran, devel
[-- Attachment #1: Type: text/plain, Size: 114 bytes --]
Upstreamed by Commit-ID:
https://github.com/tianocore/edk2-test/commit/23421e1d8393582545b01d3deee4d26e3a9f9a05
[-- Attachment #2: Type: text/html, Size: 124 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-14 19:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-04 12:00 [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test Samer El-Haj-Mahmoud
2020-09-10 19:00 ` [edk2-devel] " G Edhaya Chandran
2020-09-14 19:17 ` G Edhaya Chandran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox