* [PATCH edk2-platforms v1 1/3] Silicon/Marvell/Drivers: Casts to avoid void* pointer arithmetic
2020-07-30 19:15 [PATCH edk2-platforms v1 0/3] Casts to avoid void* pointer arithmetic PierreGondois
@ 2020-07-30 19:15 ` PierreGondois
2020-07-30 19:15 ` [PATCH edk2-platforms v1 2/3] Silicon/Socionext/SynQuacer: " PierreGondois
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: PierreGondois @ 2020-07-30 19:15 UTC (permalink / raw)
To: devel; +Cc: Pierre Gondois, leif, ard.biesheuvel, sami.mujawar, nd
From: Pierre Gondois <pierre.gondois@arm.com>
By default, gcc allows void* pointer arithmetic.
This is a GCC extension.
However, the C reference manual states that void*
pointer "cannot be operands of addition or subtraction
operators". Cf s5.3.1 "Generic Pointers".
This patch adds casts to avoid doing void* pointer arithmetic.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2-platforms/commits/Casts_avoiding_void_pointer_arith_v1
Notes:
v1:
- Use casts to avoid void* pointer arithmetic. [Pierre]
Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 5 +++--
Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c | 5 +++--
Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 4 ++--
Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c | 9 ++++++---
4 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c
index 9a1d1a7bede84d75a58806bf5f594684eaa9f0cb..0872f1788993b09394fb339f4c2113cc7d6a4491 100644
--- a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c
+++ b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c
@@ -1,5 +1,6 @@
/********************************************************************************
Copyright (C) 2016 Marvell International Ltd.
+Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -1342,7 +1343,7 @@ Pp2DxeInitialiseController (
for (Index = 0; Index < MVPP2_MAX_PORT; Index++) {
Mvpp2Shared->BufferLocation.TxDescs[Index] = (MVPP2_TX_DESC *)
- (BufferSpace + Index * MVPP2_MAX_TXD * sizeof(MVPP2_TX_DESC));
+ ((UINTN)BufferSpace + Index * MVPP2_MAX_TXD * sizeof(MVPP2_TX_DESC));
}
Mvpp2Shared->BufferLocation.AggrTxDescs = (MVPP2_TX_DESC *)
@@ -1356,7 +1357,7 @@ Pp2DxeInitialiseController (
for (Index = 0; Index < MVPP2_MAX_PORT; Index++) {
Mvpp2Shared->BufferLocation.RxBuffers[Index] = (DmaAddrT)
- (BufferSpace + (MVPP2_MAX_TXD * MVPP2_MAX_PORT + MVPP2_AGGR_TXQ_SIZE) *
+ ((UINTN)BufferSpace + (MVPP2_MAX_TXD * MVPP2_MAX_PORT + MVPP2_AGGR_TXQ_SIZE) *
sizeof(MVPP2_TX_DESC) + MVPP2_MAX_RXD * MVPP2_MAX_PORT * sizeof(MVPP2_RX_DESC) +
Index * MVPP2_BM_SIZE * RX_BUFFER_SIZE);
}
diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c
index 6059cf84d934a84bed704ad8cb2090db63d33a45..9fbf302c2848ae9491043b2a281905638ae3d61a 100755
--- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c
+++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c
@@ -1,5 +1,6 @@
/*******************************************************************************
Copyright (C) 2016 Marvell International Ltd.
+Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -629,7 +630,7 @@ XenonTransferPio (
// solution.
//
for (Index = 0; Index < BlockSize; Index += 4) {
- Offs = Buffer + Index;
+ Offs = (UINT8*)((UINTN)Buffer + Index);
if (Read) {
*(UINT32 *)Offs = MmioRead32 (SDHC_DAT_BUF_PORT_ADDR);
} else {
@@ -699,7 +700,7 @@ XenonTransferData (
XenonTransferPio (Slot, Buffer, BlockSize, Read);
- Buffer += BlockSize;
+ Buffer = (VOID*)((UINTN)Buffer + BlockSize);
if (++Block >= Blocks) {
break;
}
diff --git a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
index 3b909f341289dc829684527a562eb9183bd94246..2ecaec2af515267ddaeb24248d6e1a629f554ddb 100644
--- a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
+++ b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
@@ -1,7 +1,7 @@
/** @file
This driver installs SMBIOS information for Marvell Armada platforms
- Copyright (c) 2015, ARM Limited. All rights reserved.
+ Copyright (c) 2015-2020, Arm Limited. All rights reserved.<BR>
Copyright (c) 2019, Marvell International Ltd. and its affiliates
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -605,7 +605,7 @@ LogSmbiosData (
CopyMem (Record, Template, Template->Length);
// Append string pack
- Str = ((VOID *)Record) + Record->Length;
+ Str = (CHAR8*)((UINTN)Record + Record->Length);
for (Index = 0; StringArray[Index] != NULL; Index++) {
StringSize = AsciiStrSize (StringArray[Index]);
CopyMem (Str, StringArray[Index], StringSize);
diff --git a/Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c b/Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c
index db12adb7644ec3f211df75ef16bb19e7c96fbdc7..f99f3d5763cdb25206e2e3d9165b6c9039690fcb 100755
--- a/Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c
+++ b/Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c
@@ -1,5 +1,6 @@
/*******************************************************************************
Copyright (C) 2016 Marvell International Ltd.
+Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -233,7 +234,7 @@ MvSpiFlashRead (
Offset += ReadLength;
Length -= ReadLength;
- Buf += ReadLength;
+ Buf = (VOID*)((UINTN)Buf + ReadLength);
}
return Status;
@@ -268,8 +269,10 @@ MvSpiFlashWrite (
SpiFlashFormatAddress (WriteAddr, Slave->AddrSize, Cmd);
// Program proper write address and write data
- Status = MvSpiFlashWriteCommon (Slave, Cmd, Slave->AddrSize + 1, Buf + ActualIndex,
- ChunkLength);
+ Status = MvSpiFlashWriteCommon (
+ Slave, Cmd, Slave->AddrSize + 1,
+ (VOID*)((UINTN)Buf + ActualIndex), ChunkLength
+ );
if (EFI_ERROR (Status)) {
DEBUG((DEBUG_ERROR, "SpiFlash: Error while programming write address\n"));
return Status;
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH edk2-platforms v1 2/3] Silicon/Socionext/SynQuacer: Casts to avoid void* pointer arithmetic
2020-07-30 19:15 [PATCH edk2-platforms v1 0/3] Casts to avoid void* pointer arithmetic PierreGondois
2020-07-30 19:15 ` [PATCH edk2-platforms v1 1/3] Silicon/Marvell/Drivers: " PierreGondois
@ 2020-07-30 19:15 ` PierreGondois
2020-07-30 19:15 ` [PATCH edk2-platforms v1 3/3] Silicon/Synopsys/DesignWare: " PierreGondois
2020-08-05 10:06 ` [PATCH edk2-platforms v1 0/3] " Leif Lindholm
3 siblings, 0 replies; 5+ messages in thread
From: PierreGondois @ 2020-07-30 19:15 UTC (permalink / raw)
To: devel; +Cc: Pierre Gondois, leif, ard.biesheuvel, sami.mujawar, nd
From: Pierre Gondois <pierre.gondois@arm.com>
By default, gcc allows void* pointer arithmetic.
This is a GCC extension.
However, the C reference manual states that void*
pointer "cannot be operands of addition or subtraction
operators". Cf s5.3.1 "Generic Pointers".
This patch adds casts to avoid doing void* pointer arithmetic.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2-platforms/commits/Casts_avoiding_void_pointer_arith_v1
Notes:
v1:
- Use casts to avoid void* pointer arithmetic. [Pierre]
Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c | 14 +++++++++++---
Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c | 3 ++-
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c
index c9fc4d6e2d8e495a39a2edf24490dfea424d14e5..25cc1ac2b12f67a254799be1b57620466fd8dd6d 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c
@@ -2,6 +2,7 @@
Copyright (c) 2016 Socionext Inc. All rights reserved.<BR>
Copyright (c) 2017, Linaro, Ltd. All rights reserved.<BR>
+ Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -774,11 +775,18 @@ SnpTransmit (
// Copy destination address
CopyMem (BufAddr, (VOID *)DstAddr, NET_ETHER_ADDR_LEN);
// Copy source address
- CopyMem (BufAddr + NET_ETHER_ADDR_LEN, (VOID *)SrcAddr, NET_ETHER_ADDR_LEN);
+ CopyMem (
+ (VOID*)((UINTN)BufAddr + NET_ETHER_ADDR_LEN),
+ (VOID*)SrcAddr,
+ NET_ETHER_ADDR_LEN
+ );
// Copy protocol
Proto = HTONS (*Protocol);
- CopyMem (BufAddr + (NET_ETHER_ADDR_LEN * 2), (VOID *)&Proto,
- sizeof (UINT16));
+ CopyMem (
+ (VOID*)((UINTN)BufAddr + (NET_ETHER_ADDR_LEN * 2)),
+ (VOID*)&Proto,
+ sizeof (UINT16)
+ );
}
Status = DmaMap (MapOperationBusMasterRead, BufAddr, &BufSize,
diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c
index 1a654e4430c8451fe755b066e11a33f4887d9332..bded74dc4f02dc2444db724ee46fb75096234126 100644
--- a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c
+++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c
@@ -3,6 +3,7 @@
Copyright (c) 2016, Linaro, Ltd. All rights reserved.<BR>
Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -316,7 +317,7 @@ PerformFlashWriteWithProgress (
Print (L".");
}
- Buffer += BlockSize;
+ Buffer = (VOID*)((UINTN)Buffer + BlockSize);
Length -= BlockSize;
Lba++;
}
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH edk2-platforms v1 3/3] Silicon/Synopsys/DesignWare: Casts to avoid void* pointer arithmetic
2020-07-30 19:15 [PATCH edk2-platforms v1 0/3] Casts to avoid void* pointer arithmetic PierreGondois
2020-07-30 19:15 ` [PATCH edk2-platforms v1 1/3] Silicon/Marvell/Drivers: " PierreGondois
2020-07-30 19:15 ` [PATCH edk2-platforms v1 2/3] Silicon/Socionext/SynQuacer: " PierreGondois
@ 2020-07-30 19:15 ` PierreGondois
2020-08-05 10:06 ` [PATCH edk2-platforms v1 0/3] " Leif Lindholm
3 siblings, 0 replies; 5+ messages in thread
From: PierreGondois @ 2020-07-30 19:15 UTC (permalink / raw)
To: devel; +Cc: Pierre Gondois, leif, ard.biesheuvel, sami.mujawar, nd
From: Pierre Gondois <pierre.gondois@arm.com>
By default, gcc allows void* pointer arithmetic.
This is a GCC extension.
However, the C reference manual states that void*
pointer "cannot be operands of addition or subtraction
operators". Cf s5.3.1 "Generic Pointers".
This patch adds casts to avoid doing void* pointer arithmetic.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2-platforms/commits/Casts_avoiding_void_pointer_arith_v1
Notes:
v1:
- Use casts to avoid void* pointer arithmetic. [Pierre]
Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DriverBinding.c | 3 ++-
Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DriverBinding.c b/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DriverBinding.c
index bdf885458197887e198dcba83355c8a8631d9e58..f1a9771f066983c3152bc72ce5c2cf6fa12de95e 100755
--- a/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DriverBinding.c
+++ b/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DriverBinding.c
@@ -1,6 +1,7 @@
/** @file
Copyright (c) 2011 - 2019, Intel Corporaton. All rights reserved.
+ Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -171,7 +172,7 @@ DriverStart (
}
//DMA mapping for receive buffer
- RxBufferAddr = (VOID *)Snp->MacDriver.RxBuffer + (Index * BufferSize);
+ RxBufferAddr = (UINTN*)((UINTN)Snp->MacDriver.RxBuffer + (Index * BufferSize));
Status = DmaMap (MapOperationBusMasterWrite, (VOID *) RxBufferAddr,
&BufferSize, &RxBufferAddrMap, &Snp->MacDriver.RxBufNum[Index].Mapping);
if (EFI_ERROR (Status)) {
diff --git a/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c b/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c
index 09e6754798a048f6dc3c40086039ca836dfb9540..4cb3371d79bbdc23735f85826ce35e5d71dbcdf9 100755
--- a/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c
+++ b/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c
@@ -5,7 +5,7 @@
The original software modules are licensed as follows:
- Copyright (c) 2012 - 2014, ARM Limited. All rights reserved.
+ Copyright (c) 2012 - 2020, Arm Limited. All rights reserved.<BR>
Copyright (c) 2004 - 2010, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -1135,7 +1135,8 @@ SnpReceive (
Snp->MacDriver.RxCurrentDescriptorNum = Snp->MacDriver.RxNextDescriptorNum;
DescNum = Snp->MacDriver.RxCurrentDescriptorNum;
RxDescriptor = Snp->MacDriver.RxdescRing[DescNum];
- RxBufferAddr = (VOID *)Snp->MacDriver.RxBuffer + (DescNum * BufferSizeBuf);
+ RxBufferAddr = (UINTN*)((UINTN)Snp->MacDriver.RxBuffer +
+ (DescNum * BufferSizeBuf));
RxDescriptorMap = (VOID *)(UINTN)Snp->MacDriver.RxdescRingMap[DescNum].AddrMap;
RawData = (UINT8 *) Data;
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH edk2-platforms v1 0/3] Casts to avoid void* pointer arithmetic
2020-07-30 19:15 [PATCH edk2-platforms v1 0/3] Casts to avoid void* pointer arithmetic PierreGondois
` (2 preceding siblings ...)
2020-07-30 19:15 ` [PATCH edk2-platforms v1 3/3] Silicon/Synopsys/DesignWare: " PierreGondois
@ 2020-08-05 10:06 ` Leif Lindholm
3 siblings, 0 replies; 5+ messages in thread
From: Leif Lindholm @ 2020-08-05 10:06 UTC (permalink / raw)
To: PierreGondois; +Cc: devel, ard.biesheuvel, sami.mujawar, nd
On Thu, Jul 30, 2020 at 20:15:08 +0100, PierreGondois wrote:
> These patches cast void* pointers to UINTN, preventing to do
> void* pointer arithmetc.
>
> Pierre Gondois (3):
> Silicon/Marvell/Drivers: Casts to avoid void* pointer arithmetic
> Silicon/Socionext/SynQuacer: Casts to avoid void* pointer arithmetic
> Silicon/Synopsys/DesignWare: Casts to avoid void* pointer arithmetic
Thanks!
For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 02cf0dcf8f93..b2eebc1d593e.
> Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 5 +++--
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c | 5 +++--
> Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 4 ++--
> Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c | 9 ++++++---
> Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c | 14 +++++++++++---
> Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c | 3 ++-
> Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DriverBinding.c | 3 ++-
> Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c | 5 +++--
> 8 files changed, 32 insertions(+), 16 deletions(-)
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
^ permalink raw reply [flat|nested] 5+ messages in thread