From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web11.8050.1596636702730863992 for ; Wed, 05 Aug 2020 07:11:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=DAC16VSh; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id c15so4625692wrs.11 for ; Wed, 05 Aug 2020 07:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IVczxqd82hnKwwLeF3/Z4Z9pXdOpzgbFTlejgk5eaKo=; b=DAC16VShmOyd3bJ3rNDBfIrYZRPtRP+9XPuKU/F3wMX92REMczPEqYDTSAKNSjsIt/ aomPwqxbIGfkidN5Y4Q8g6U+lOKUpy9EN7LIhc1eHcVj1OWW1Xj+/+oq54HPP3kBMj2Y 0L8+OU77a411bB5T6j1YSfF+hd70iXDck3gZQMCeB8ULoanYOEBqzUWi97HeVvB3FjWN S+2Vcurm+5OSzyKuH59OagnzSa557jm8a1G0y7pc8ikyNMPLvE2uR5DeeaaOl/BKv4// Zeis3z8uf+9zB30mvU/0DEdLkRISxLxKdrSClSAalCJFLuoSguU4C8ywnl2SHDx7DNoK GDcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IVczxqd82hnKwwLeF3/Z4Z9pXdOpzgbFTlejgk5eaKo=; b=lEEAn/kONZjdnFYJY/ad9+gOfs6KfaDcIm1bKhS6g+BPYOng12RPI8H3vOidn8gPYz S9BqKP2ChPSH9f0lfX5grFsdKIJOgja6vNL7vFZaKg0vpI5fWKCp0CvLo3b62wOeEkyH fzRbM/1P+6cZs5VNBekQu7giqUKZIVZaK7Y29LSUaJTjhVomj45+WdZD9hMPwLS9MYvz PMzUhhTI9bPvjT8WFUry2RW+EBKFiayGFIkbNcgSTtPnXbZKv1EEe2AyzlMe9tCkkXr1 Fp1delmnT2es8ZajyJIad2x3YObrt7Ufz5PQHbmdLhTRU5emv8Fbr+X8ktPBhhkNE+p7 umuA== X-Gm-Message-State: AOAM531Nf/RUlx7Evn2B/9rBBV5PSWpTkU/VuB4W7mx5jDG2XL2QXv1k O+NGjv9xI2h3oanTwdviiDDBMA== X-Google-Smtp-Source: ABdhPJyBQ1tF5z7/Md2KXfEmZt0/gqRJpNM4rsn3FA/8FU2IZa/io9gbLdrC3l0S5xsn8EY2ze21jg== X-Received: by 2002:adf:aa9e:: with SMTP id h30mr2851458wrc.377.1596636701235; Wed, 05 Aug 2020 07:11:41 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id e4sm2862816wru.55.2020.08.05.07.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 07:11:40 -0700 (PDT) Date: Wed, 5 Aug 2020 15:11:38 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH edk2-platforms 1/3] Silicon/NXP: Use runtime safe version of DebugLib Message-ID: <20200805141138.GN31778@vanye> References: <20200708051933.8123-1-pankaj.bansal@oss.nxp.com> <20200708051933.8123-2-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200708051933.8123-2-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 08, 2020 at 00:19:31 -0500, Pankaj Bansal wrote: > From: Pankaj Bansal > > For DXE_RUNTIME_DRIVER runtime safe version of DebugLib should be > used. Otherwise, any DEBUG print in code can result in abort in OS. > > Signed-off-by: Pankaj Bansal For this patch: Reviewed-by: Leif Lindholm Pushed as e5c5ad8bfb03. > --- > Silicon/NXP/NxpQoriqLs.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc > index ee639d552483..06ee012c227a 100644 > --- a/Silicon/NXP/NxpQoriqLs.dsc.inc > +++ b/Silicon/NXP/NxpQoriqLs.dsc.inc > @@ -163,6 +163,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > > [LibraryClasses.AARCH64] > # > -- > 2.17.1 >