From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.52]) by mx.groups.io with SMTP id smtpd.web10.39.1596816743416235485 for ; Fri, 07 Aug 2020 09:12:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ekB4flcJ; spf=pass (domain: arm.com, ip: 40.107.8.52, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJ+bwgu1lm0GTTPGdPhcB2Ph5mJP/Y4BnKNGxp6rRSk=; b=ekB4flcJd/r2Gq7NCCLKI8BL8Yhu360OHo9PZ2cXUTEMbJOdKXwIzwoaZnS+UzvvXJsCSPuFTSgIUeY8WO6d+nACVXaL1oylJpacw5uMJtMuWi7SArE6f5OTBlktXmHW9cDFsGOS4yJdnyA8ZN6NgJ/aXKgIZzbxYEu5oxBYqdE= Received: from MRXP264CA0029.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::17) by DB8PR08MB5194.eurprd08.prod.outlook.com (2603:10a6:10:e8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Fri, 7 Aug 2020 16:12:20 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:14:cafe::2c) by MRXP264CA0029.outlook.office365.com (2603:10a6:500:14::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15 via Frontend Transport; Fri, 7 Aug 2020 16:12:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16 via Frontend Transport; Fri, 7 Aug 2020 16:12:19 +0000 Received: ("Tessian outbound 195a290eb161:v64"); Fri, 07 Aug 2020 16:12:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8c17a5d70552f964 X-CR-MTA-TID: 64aa7808 Received: from 17d99c28c56f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5858AB33-6FB5-41E2-8672-A9C65718C878.1; Fri, 07 Aug 2020 16:12:13 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 17d99c28c56f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 07 Aug 2020 16:12:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRjb32S487WNu1++zctcZ2YXxlo/wnqQk25ZGMv9Uz9+/KOPugKbzYZdjmAWOSMOAek9kyilL2yY/ExzP8LzMgMpruaktALbUtJEpEftot1pULcZNLUNSxQ3fIlG/8jIro9Qd543R6+LtyMAmwcrw8xNE/2GyFRE4killuUDOeAOxpL6OArS+G5NSL/xu60EPLzYd13LAQb3d/NfizoS3h1lJvUBmizDZQzm4rH18IdLm/27183AtyILld6JMtmiNiiLJ4sJfsdU4S2pyO8Io2QYsOtZCLnk/xQNnvxur4medQchE/rUJQ+mz4Hm4HUNtga3AzBokbYbudwiAW46GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJ+bwgu1lm0GTTPGdPhcB2Ph5mJP/Y4BnKNGxp6rRSk=; b=H4kN2aScz9BY0If95ttTD3dGKbTSlNJ70owhGbrDWvwweRc+1Xfu6zugpTsnDI+AKYrZitVtdK5V4ePxV25PXec/ZmXXuOLltTYwG33nw+xOk6egWUIn9FZ2pXJtH7DW0RraCHA1KECn1HQPOAz9Si0qL9poVMU8HYQDDsHk8VXhHqp9WF80B6zL8fwKjiDt10R+HurS67ldn7XWPAvg35SA9CE4GE4ib5h27iCfKQBH8Warv2howgzaU5bIth86fRwsU5g4rzAgHp8nIkb5VLIabwZeklhCXcpUDqGEvLasrMwFTi69tpBJZA1B8n0Rxvj+w/eh2bf/FpQqtmbKAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJ+bwgu1lm0GTTPGdPhcB2Ph5mJP/Y4BnKNGxp6rRSk=; b=ekB4flcJd/r2Gq7NCCLKI8BL8Yhu360OHo9PZ2cXUTEMbJOdKXwIzwoaZnS+UzvvXJsCSPuFTSgIUeY8WO6d+nACVXaL1oylJpacw5uMJtMuWi7SArE6f5OTBlktXmHW9cDFsGOS4yJdnyA8ZN6NgJ/aXKgIZzbxYEu5oxBYqdE= Received: from MR2P264CA0157.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::20) by DB7PR08MB3914.eurprd08.prod.outlook.com (2603:10a6:10:32::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Fri, 7 Aug 2020 16:12:11 +0000 Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:1:cafe::5b) by MR2P264CA0157.outlook.office365.com (2603:10a6:501:1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15 via Frontend Transport; Fri, 7 Aug 2020 16:12:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3261.16 via Frontend Transport; Fri, 7 Aug 2020 16:12:10 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Fri, 7 Aug 2020 16:12:09 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Fri, 7 Aug 2020 16:12:07 +0000 Received: from E107187.Arm.com (10.57.36.22) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Fri, 7 Aug 2020 16:12:06 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , Subject: [PATCH v3 1/2] DynamicTablesPkg: Fix issues reported by EDKII CI Date: Fri, 7 Aug 2020 17:12:04 +0100 Message-ID: <20200807161205.50468-2-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20200807161205.50468-1-sami.mujawar@arm.com> References: <20200807161205.50468-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5956527e-9ea2-40bf-44fd-08d83aeca913 X-MS-TrafficTypeDiagnostic: DB7PR08MB3914:|DB8PR08MB5194: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4941;OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MD+QerWpX2ecUAljS7ceu08YsEDybM3Bfs2DXZ8bc0HG8ckwF8gi8HXWZ67br0EkpqF7fZr9vsiruoB6OeJ0A5v9joQpYVm4Waz5PmJJnPtpSljviRnYik2RrlBoFDKsylGMmB1nlL51wP4BeyFyy5KNjYT9a/Vgi8GqNtCLA3IBtZJH0NGsOHgLdlMp0i60sMBhFquTmQcIKA13ZLOHAp189x472L0q4Rb1p6zPwKx2OdtUsS/gJ0RF81bFzIYGSxtjJW6blaan688vBRf7u88mKvnx5byby8Q/nD0wZ5FyODXUwzzjaqHq4zhEmitf6AVzOVQG0HJGUkFZaK1FUpkWdMtTirNOysN8y1b8KA7K0P/GhrjpD45fabwZRUj56ftVhfJytH7JNwDZ98yJmVRrknoiESqqOYsCSWoegq38oFGI6pFgxl07lSSVjOXwbvr4oZr0hA/VzStTRVco10+Z4Co2sUUzLka7gRvUGjE= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(396003)(136003)(39860400002)(46966005)(2616005)(316002)(81166007)(54906003)(86362001)(966005)(6916009)(356005)(478600001)(82740400003)(47076004)(1076003)(186003)(8676002)(426003)(7696005)(4326008)(26005)(336012)(8936002)(70206006)(70586007)(5660300002)(83380400001)(2906002)(82310400002)(36756003)(44832011)(30864003);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3914 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a5c1dae1-9914-483d-6899-08d83aeca397 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6IF653t3sAgGrO7hQPB4bXc9aMGzswpvDC/f35zW/5tdeev05vkmNUTxiK0JcOY70tnlk5Ycvi8Mh8rOGachm23VzaDYEkqL+pszOUXSNIkLRaKUHswtjvuw+sbe30CUd1LvxCnqOuTa0lJ7GSRe7SwB497SxtVx6caN+FCiZOBF3wg93PDSfoUxd/tP4DVIdpdP4bOkyi7YmJm3p+bh3m4NDFw3vrUdCzymPn9d67kxj2d70/5RI4C52pcZ3TD8mKnoCDRcWGDhpRI2zmnIVP094LYDWVioyZ0xObfHmKavNumggFQD52+3nf8yLbWXP3k/PPTa2IqhN43O4dMGrvRXQCJ9hO7ubnMixG7VLTEe8Qyvp71ukTgJbfEuSwuhdZI/RrRL4PTwXpP6o3FOCU4/rutDX5lrR2godtsHXooGQ3NS5NLcptx+ViQ6fAEv8WL4OFeS9p2yPbvyPUC4GYcSKgm4cFYjJISFp9ZJ37s= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(396003)(376002)(39860400002)(346002)(136003)(46966005)(36756003)(47076004)(336012)(70586007)(7696005)(5660300002)(86362001)(70206006)(4326008)(81166007)(83380400001)(478600001)(36906005)(82740400003)(82310400002)(186003)(316002)(8676002)(6916009)(1076003)(2616005)(44832011)(426003)(30864003)(966005)(26005)(54906003)(2906002)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2020 16:12:19.4401 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5956527e-9ea2-40bf-44fd-08d83aeca913 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5194 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules: * https://pypi.org/project/edk2-pytool-library/ * https://pypi.org/project/edk2-pytool-extensions/ More information on configuring the environment and running the builds can be found in edk2\.pytool\Readme.md This patch fixes the issues reported by the CI system mainly around fixing typo errors and package dec and dsc files. A subsequent patch enables the CI builds for the DynamicTablesPkg. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v3: - No code change. Splitting v2 patch series into two series. [Sam= i] The v3 series contains the patches for DynamicTablesPkg. Ref: https://edk2.groups.io/g/devel/message/63255 =20 v2: - Added INF files in components section to prevent [Sami= ] DscCompleteCheck from failing. - Why are there modules not built during ci (The files [Sean= ] listed in the DscCompleteCheck[IgnoreInf] list) =20 v1: - Fix for various issues reported by the EDKII CI [Sami= ] DynamicTablesPkg/DynamicTables.dsc.inc | 14 ++++= ++++++++++ DynamicTablesPkg/DynamicTablesPkg.dec | 7 ++++= +-- DynamicTablesPkg/DynamicTablesPkg.dsc | 4 ++-- DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 6 +++-= -- DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 4 ++-- DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 8 ++++= ---- DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 12 ++++= ++------ DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 6 +++-= -- DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 4 ++-- DynamicTablesPkg/Readme.md | 2 +- 10 files changed, 42 insertions(+), 25 deletions(-) diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/Dyna= micTables.dsc.inc index 0bf7a77cf2dcf82135f52a834774769bb06ba21a..48ad8833f48d0c56ec3468f4a89= ca56da1a6c56c 100644 --- a/DynamicTablesPkg/DynamicTables.dsc.inc +++ b/DynamicTablesPkg/DynamicTables.dsc.inc @@ -17,6 +17,20 @@ [LibraryClasses.common] =20 [Components.common] # + # Generators + # + DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf + DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf + DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf + DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf + DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf + DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf + DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf + DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf + DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf + DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/AcpiSratLibArm.inf + + # # Dynamic Table Factory Dxe # DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.i= nf { diff --git a/DynamicTablesPkg/DynamicTablesPkg.dec b/DynamicTablesPkg/Dynam= icTablesPkg.dec index cf453faf590368c2e480e65a09cef4b5fbdc70d1..6cb8a0b4f2c91b59e888951fda0= 34bfdc56d95e1 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dec +++ b/DynamicTablesPkg/DynamicTablesPkg.dec @@ -1,7 +1,7 @@ ## @file # dec file for Dynamic Tables Framework. # -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
+# Copyright (c) 2017 - 2020, ARM Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -16,8 +16,11 @@ [Defines] [Includes] Include =20 +[LibraryClasses] + ## @libraryclass Defines a set of helper methods. + TableHelperLib|Include/Library/TableHelperLib.h + [Protocols] - # Configuration Manager Protocol GUID gEdkiiConfigurationManagerProtocolGuid =3D { 0xd85a4835, 0x5a82, 0x4894,= { 0xac, 0x2, 0x70, 0x6f, 0x43, 0xd5, 0x97, 0x8e } } =20 diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/Dynam= icTablesPkg.dsc index 02f04447fffa867c602c748279c041bd566a7fd6..5fb30a9315a75750a7d4c3e802c= 610a7991111c7 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dsc +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc @@ -2,7 +2,7 @@ # Dsc file for Dynamic Tables Framework. # # Copyright (c) 2019, Linaro Limited. All rights reserved.
-# Copyright (c) 2019, ARM Limited. All rights reserved.
+# Copyright (c) 2019 - 2020, ARM Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -39,7 +39,7 @@ [Components.common] DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf =20 [BuildOptions] - *_*_*_CC_FLAGS =3D -DDISABLE_NEW_DEPRECATED_INTERFACES + *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES =20 !ifdef STATIC_ANALYSIS # Check all rules diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTables= Pkg/Include/ArmNameSpaceObjects.h index 2f326960313c1d7658029205e5cb09b89b0cdd88..57a282d5cb6883d0dabb74ceac7= c8905ed3ef43a 100644 --- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. + Copyright (c) 2017 - 2020, ARM Limited. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -682,7 +682,7 @@ typedef struct CmArmProcHierarchyInfo { UINT32 NoOfPrivateResources; /// Token of the array which contains references to the resources privat= e to /// this CM_ARM_PROC_HIERARCHY_INFO instance. This field is ignored if - /// the NoOfPrivateResources is 0, in which case it is recomended to set + /// the NoOfPrivateResources is 0, in which case it is recommended to se= t /// this field to CM_NULL_TOKEN. CM_OBJECT_TOKEN PrivateResourcesArrayToken; } CM_ARM_PROC_HIERARCHY_INFO; @@ -795,7 +795,7 @@ typedef struct CmArmDeviceHandlePci { /// PCI Bus Number - Max 256 busses (Bits 15:8 of BDF) UINT8 BusNumber; =20 - /// PCI Device Mumber - Max 32 devices (Bits 7:3 of BDF) + /// PCI Device Number - Max 32 devices (Bits 7:3 of BDF) UINT8 DeviceNumber; =20 /// PCI Function Number - Max 8 functions (Bits 2:0 of BDF) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c index 51c843d25f75388104694855ce133b3d61860196..172d99f61cf36e7e65d62249960= fd7527d8dae00 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c @@ -1,7 +1,7 @@ /** @file DBG2 Table Generator =20 - Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. + Copyright (c) 2017 - 2020, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -323,7 +323,7 @@ BuildDbg2Table ( Status =3D EFI_INVALID_PARAMETER; DEBUG (( DEBUG_ERROR, - "ERROR: DBG2: Uart port sybtype is invalid. PortSubtype =3D 0x%x\n", + "ERROR: DBG2: Uart port subtype is invalid. PortSubtype =3D 0x%x\n", SerialPortInfo->PortSubtype )); goto error_handler; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c index 65d006c89e668c8b2b8a14326cddf1b69979597f..349caa8006bc34ca789cb3e321a= 0f87c0cd4ff0d 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c @@ -1,7 +1,7 @@ /** @file IORT Table Generator =20 - Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. + Copyright (c) 2017 - 2020, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -1053,7 +1053,7 @@ AddRootComplexNodes ( **/ STATIC EFI_STATUS -AddSmmuInterrruptArray ( +AddSmmuInterruptArray ( IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL * CONST CfgMgrProtoc= ol, IN OUT EFI_ACPI_6_0_IO_REMAPPING_SMMU_INT * InterruptArr= ay, IN UINT32 InterruptCou= nt, @@ -1199,7 +1199,7 @@ AddSmmuV1V2Nodes ( SmmuNode->SMMU_NSgCfgIrptFlags =3D NodeList->SMMU_NSgCfgIrptFlags; =20 // Add Context Interrupt Array - Status =3D AddSmmuInterrruptArray ( + Status =3D AddSmmuInterruptArray ( CfgMgrProtocol, ContextInterruptArray, SmmuNode->NumContextInterrupts, @@ -1217,7 +1217,7 @@ AddSmmuV1V2Nodes ( // Add PMU Interrupt Array if ((SmmuNode->NumPmuInterrupts > 0) && (NodeList->PmuInterruptToken !=3D CM_NULL_TOKEN)) { - Status =3D AddSmmuInterrruptArray ( + Status =3D AddSmmuInterruptArray ( CfgMgrProtocol, PmuInterruptArray, SmmuNode->NumPmuInterrupts, diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c index 2651ca15414694c494678bcec655fc882ee2cc0c..7ec800f51cb0dbee0da46a82986= 3647fd1839c23 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c @@ -1,7 +1,7 @@ /** @file MADT Table Generator =20 - Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. + Copyright (c) 2017 - 2020, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -332,24 +332,24 @@ AddGICMsiFrameInfoList ( /** Update the GIC Redistributor Information. =20 @param [in] Gicr Pointer to GIC Redistributor structure= . - @param [in] GicRedisributorInfo Pointer to the GIC Redistributor Info. + @param [in] GicRedistributorInfo Pointer to the GIC Redistributor Info= . **/ STATIC VOID AddGICRedistributor ( IN EFI_ACPI_6_3_GICR_STRUCTURE * CONST Gicr, - IN CONST CM_ARM_GIC_REDIST_INFO * CONST GicRedisributorInfo + IN CONST CM_ARM_GIC_REDIST_INFO * CONST GicRedistributorInfo ) { ASSERT (Gicr !=3D NULL); - ASSERT (GicRedisributorInfo !=3D NULL); + ASSERT (GicRedistributorInfo !=3D NULL); =20 Gicr->Type =3D EFI_ACPI_6_3_GICR; Gicr->Length =3D sizeof (EFI_ACPI_6_3_GICR_STRUCTURE); Gicr->Reserved =3D EFI_ACPI_RESERVED_WORD; Gicr->DiscoveryRangeBaseAddress =3D - GicRedisributorInfo->DiscoveryRangeBaseAddress; - Gicr->DiscoveryRangeLength =3D GicRedisributorInfo->DiscoveryRangeLength= ; + GicRedistributorInfo->DiscoveryRangeBaseAddress; + Gicr->DiscoveryRangeLength =3D GicRedistributorInfo->DiscoveryRangeLengt= h; } =20 /** Add the GIC Redistributor Information to the MADT Table. diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c index 4b2580da7df9b4472ae9bcc3df2138a9e13004d0..b80e98ee7e143e39c540557d53a= 4129bf4ac5eb7 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c @@ -1,7 +1,7 @@ /** @file SPCR Table Generator =20 - Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. + Copyright (c) 2017 - 2020, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -189,7 +189,7 @@ BuildSpcrTable ( Status =3D EFI_INVALID_PARAMETER; DEBUG (( DEBUG_ERROR, - "ERROR: SPCR: Uart port sybtype is invalid. PortSubtype =3D 0x%x\n", + "ERROR: SPCR: Uart port subtype is invalid. PortSubtype =3D 0x%x\n", SerialPortInfo->PortSubtype )); goto error_handler; @@ -224,7 +224,7 @@ BuildSpcrTable ( Status =3D EFI_INVALID_PARAMETER; DEBUG (( DEBUG_ERROR, - "ERROR: SPCR: Invalid Port Sybtype (must be < 256). Status =3D %r\n"= , + "ERROR: SPCR: Invalid Port subtype (must be < 256). Status =3D %r\n"= , Status )); goto error_handler; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c index 620e2929ef2460b6bf318fa85f8bca984608b955..6844bb40eb02e994bb6a4edfaf2= 5689685ca01fc 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c @@ -1,7 +1,7 @@ /** @file SRAT Table Generator =20 - Copyright (c) 2019, ARM Limited. All rights reserved. + Copyright (c) 2019 - 2020, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -101,7 +101,7 @@ GET_OBJECT_LIST ( /** Return the PCI Device information in BDF format =20 PCI Bus Number - Max 256 busses (Bits 15:8 of BDF) - PCI Device Mumber - Max 32 devices (Bits 7:3 of BDF) + PCI Device Number - Max 32 devices (Bits 7:3 of BDF) PCI Function Number - Max 8 functions (Bits 2:0 of BDF) =20 @param [in] DeviceHandlePci Pointer to the PCI Device Handle. diff --git a/DynamicTablesPkg/Readme.md b/DynamicTablesPkg/Readme.md index 93fd1f313aa5227df5c1ccc82dfe17cb4c8f9e0a..bcaae6daa5fff24d9f62639149e= 9f82c2665c682 100644 --- a/DynamicTablesPkg/Readme.md +++ b/DynamicTablesPkg/Readme.md @@ -136,4 +136,4 @@ Documentation =20 Refer to the following presentation from *UEFI Plugfest Seattle 2018*: =20 -[Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced= Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS)= Tables =E2=80=93 Sami Mujawar (Arm).](http://www.uefi.org/sites/default/fi= les/resources/Arm_Dynamic%20Tables%20Framework%20A%20Step%20Towards%20Autom= atic%20Generation%20of%20Advanced%20Configuration%20and%20Power%20Interface= %20%28ACPI%29%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Tables%20= _0.pdf) +[Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced= Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS)= Tables](http://www.uefi.org/sites/default/files/resources/Arm_Dynamic%20Ta= bles%20Framework%20A%20Step%20Towards%20Automatic%20Generation%20of%20Advan= ced%20Configuration%20and%20Power%20Interface%20%28ACPI%29%20%26%20System%2= 0Management%20BIOS%20%28SMBIOS%29%20Tables%20_0.pdf) --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'