public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gary Lin" <glin@suse.com>
To: Zhichao Gao <zhichao.gao@intel.com>
Cc: devel@edk2.groups.io, Jian J Wang <jian.j.wang@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>, Ray Ni <ray.ni@intel.com>,
	Andrew Fish <afish@apple.com>
Subject: Re: [PATCH 0/3] MdeModulePkg/PartitionDxe: Make the parition driver match the spec
Date: Tue, 11 Aug 2020 15:54:43 +0800	[thread overview]
Message-ID: <20200811075443.GG21538@GaryWorkstation> (raw)
In-Reply-To: <20200811064302.33188-1-zhichao.gao@intel.com>

On Tue, Aug 11, 2020 at 02:42:59PM +0800, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843
> 
> Refer to the UEFI spec 2.8, Section 13.3.2:
> A block device should be scanned as below order:
> 1. GPT
> 2. ISO 9660 (El Torito) (UDF should aslo be here)
> 4. MBR
> 5. no partition found
> 
> But the code implementation is:
> 1. GPT
> 2. MBR
> 3. ISO 9660 (El Torito) (UDF)
> 4. no partition found
> 
> Which would cause the ISO 9960 image with MBR info be treated as MBR
> device. That would cause unexpect behavior. So fix it to follow the spec
> description.
> 
> The fix of the PartitionInstallChildHandle would change the boot behavior
> of Linux ISO image with MBR table. So add it after the order adjustment
> to make no impact of the boot.
> 
Thanks for the patches. After applying this patch series, the firmware
recognizes openSUSE/SUSE iso images again.

Tested-by: Gary Lin <glin@suse.com>

> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Gary Lin <glin@suse.com>
> Cc: Andrew Fish <afish@apple.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> Zhichao Gao (3):
>   MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR
>   MdeModulePkg/PartitionDxe: Remove the check for special MBR
>   MdeModulePkg/PartitionDxe: Fix the incorrect LBA size in child hander
> 
>  .../Universal/Disk/PartitionDxe/Mbr.c         | 19 ----------------
>  .../Universal/Disk/PartitionDxe/Partition.c   | 22 ++++++++++---------
>  2 files changed, 12 insertions(+), 29 deletions(-)
> 
> -- 
> 2.21.0.windows.1
> 


      parent reply	other threads:[~2020-08-11  7:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11  6:42 [PATCH 0/3] MdeModulePkg/PartitionDxe: Make the parition driver match the spec Gao, Zhichao
2020-08-11  6:43 ` [PATCH 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR Gao, Zhichao
2020-08-11  8:04   ` Ni, Ray
2020-08-11  8:33     ` Gao, Zhichao
2020-08-11 13:48       ` Ni, Ray
2020-08-12  0:44         ` Gao, Zhichao
2020-08-12  1:57           ` [edk2-devel] " Ni, Ray
2020-08-11  6:43 ` [PATCH 2/3] MdeModulePkg/PartitionDxe: Remove the check for special MBR Gao, Zhichao
2020-08-11  8:05   ` Ni, Ray
2020-08-11  8:28     ` [edk2-devel] " Gao, Zhichao
2020-08-11 13:49       ` Ni, Ray
2020-08-11  6:43 ` [PATCH 3/3] MdeModulePkg/PartitionDxe: Fix the incorrect LBA size in child hander Gao, Zhichao
2020-08-11  8:08   ` Ni, Ray
2020-08-11  7:54 ` Gary Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200811075443.GG21538@GaryWorkstation \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox