From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [51.163.158.102]) by mx.groups.io with SMTP id smtpd.web10.10433.1597132498817763362 for ; Tue, 11 Aug 2020 00:54:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@suse.com header.s=mimecast20200619 header.b=j5B8i0cf; spf=pass (domain: suse.com, ip: 51.163.158.102, mailfrom: glin@suse.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1597132496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jqiZvOmM9YaTFnrCnhtAtYrVXAsCaOcshDnfFcrAh6A=; b=j5B8i0cfPS2u7l1yg4FGh9nUk/kgkSNgalNMqPiONKj2KsjZ4UGReqJdddxqMUD1HRWWKa eKLSHBsa1S3uj3KPtSrG3WsA5ClB4PIyQ2EhH7GnbMa7EoEH/W3OND55NTSp12hceYzKHd 6+hmmtAqAAOJcEtDrMcTj15vGEfBg4I= Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2051.outbound.protection.outlook.com [104.47.10.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-7-_iSxhMVGNkuyzr5KYZm34Q-1; Tue, 11 Aug 2020 09:54:54 +0200 X-MC-Unique: _iSxhMVGNkuyzr5KYZm34Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8O8tROWhrgIubgJ062luJcBvVZDAsqQDNNMQF/1qKLVhl4/wC0mh93Pdk0J/fna6oK2FaAFHi77q+SUv4yArTVHjmRMWTCSXRUYeSI9X8igThhLFIGPYsJX9mD90OOBRbpZZnUoyswOGKTc1XVrEZfSEh5AB5ePm3LlXhXmFmw33M2miqHBd0k03cJng+i+GZTuX3oDb2xBokt0slFP7XfW/CPJrsASIMFPQ+ERvnUYhDerBLgWeAQMrLGLgAHDz8JFGnsgnzRnzRd+r+b/1L3VgipVpkHs7hgaV+LjyPGbxRRPUutMgx6jgQWUgi5qK9jBw+CZW0QS6VadpkIzZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jqiZvOmM9YaTFnrCnhtAtYrVXAsCaOcshDnfFcrAh6A=; b=TkTBpAMiN0ZLY3ZUz0ldl+pufyGnjMwlOKNPzaNvORyK57YVAdDWuVHBmWYY5s7diYvTlLSJnjYUABPQaqpabymHwiTuDdylTqARUF93iDU6g1gknpJyI9pgrKyJU15Rik0OdKSY5PcfSdQ2Zc5M/xxiS48SchZZRewbunbCghGb5BK7XCMycGrqd5NinItHVyk++rkwnPbZLFo5e/97SXUWxECRFhXNVl7P4hmm2em7+6wtZyc9JqKT4BzHQHLz0ejMm9668xNAtke9wC23f+DsdMcQvm4U+Hu0m2sazmHcXHCTvPW8r3Ybx5JL4ouX8G8zKLXpRcsUU1KgHCeRwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=suse.com; Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) by AM0PR04MB4481.eurprd04.prod.outlook.com (2603:10a6:208:70::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.17; Tue, 11 Aug 2020 07:54:53 +0000 Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::156f:d82d:35d4:4f02]) by AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::156f:d82d:35d4:4f02%2]) with mapi id 15.20.3261.024; Tue, 11 Aug 2020 07:54:53 +0000 Date: Tue, 11 Aug 2020 15:54:43 +0800 From: "Gary Lin" To: Zhichao Gao Cc: devel@edk2.groups.io, Jian J Wang , Hao A Wu , Ray Ni , Andrew Fish Subject: Re: [PATCH 0/3] MdeModulePkg/PartitionDxe: Make the parition driver match the spec Message-ID: <20200811075443.GG21538@GaryWorkstation> References: <20200811064302.33188-1-zhichao.gao@intel.com> In-Reply-To: <20200811064302.33188-1-zhichao.gao@intel.com> X-ClientProxiedBy: AM4PR0701CA0034.eurprd07.prod.outlook.com (2603:10a6:200:42::44) To AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) Return-Path: glin@suse.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from GaryWorkstation (60.251.47.115) by AM4PR0701CA0034.eurprd07.prod.outlook.com (2603:10a6:200:42::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.7 via Frontend Transport; Tue, 11 Aug 2020 07:54:50 +0000 X-Originating-IP: [60.251.47.115] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1e90a9e-399c-415f-30ea-08d83dcbd475 X-MS-TrafficTypeDiagnostic: AM0PR04MB4481: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZUhgxu//e6tFk5uv98zD6LG9B3m6pvRVWAQdFRfnvJ9s0BvSyN+zD2gIh0UySZxAfJ83JkMWFoE/TqhbHYC7nVqJQuL1HP87sg2Xxa9aA2DElk5KFPBQOHCSIv+7p+/FD+dtCu7Mvb7GTjlRSe1FXsMx2cAigzEA+qiVRye1/uuMzUuEVo8MrkJ8LKb7Mzrp6orL4sdmTOCRdUxuRJ2gEBgg+nuBAt5cJLY+tCSHTixULUkpOt06gDzazCIzwUEMmAQVhVc0uwua9qQ4ZJmSIa1AS9CbBk74t0mbkhSitCCtx5ih8eiGxIQwBWotVYTB5qlKTpau534lM2LZUdVoFLJOqZX8pJ/XxBsiDBUV8jctk9Hv6jN7JL6NvIRXJLBO7/EFUPomuhkG+Rq+7b1f3g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR0402MB3809.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(346002)(376002)(366004)(39860400002)(136003)(6916009)(9686003)(6496006)(26005)(8676002)(956004)(966005)(52116002)(55236004)(4326008)(316002)(478600001)(8936002)(54906003)(33656002)(2906002)(5660300002)(55016002)(66946007)(6666004)(83380400001)(186003)(33716001)(1076003)(16526019)(66556008)(66476007)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: l40uLZKyAB17FQseI1MgPFa5/zHEgqlSSM4bcytmodM3by3IejQwiD8VLKs7TsXPx+z47ONnxIHyuAOH2gDcdUsD2iMdfkdFj2V0tRG4ergLV+jnNn1lATriiiRkpnQxY+f9FN3zrhO9Lh9Wdxm0huZaxb+D/vsl/oQEtCkvLIsHJ7jXy/Y0PraeQ3GjAUmOYHSMNsXGj/m4sWJUSQ2pqGbzyZnnpyAmtjxU6913Cf8JCX0+1+o/+VINT9jr9MVjdJMdIvWPQROmT9ASCONE960EnkC8Igfy+lxp+icANw1dn1Sc7Au3D4n/FLxCbiisvBD6IVgaHRzYHPb03RbYS2jl83URX3iJkB/4C5eB5uxIXE5pE072YUvKi6HbjvsCHuO6q/1cc8cBElxKvdNVbzHZ4TKBBj7+j2PL4z74+RqLBfIwqw+PDXrBqzsMj+pCMJqVsKfC4GKcQvjo0klEbq1nA9gZvgh8HKw0AkwbjubQOu2AlAYrCXa65Gj4TMHzOeCeIdn9qoIjZhQqVCNT+tIxRrMGwkMGQmdHY4jq4cVwgDLZmhDF4LY2e1uNW7NaFH+43LuSuB81St5oPGxMrBzvDgj7fzKSZQfCj2ZmWyyeiK7X7jc3HArTs4DrnAAufhcl5mv7BdJ1t9HDCW3dyw== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1e90a9e-399c-415f-30ea-08d83dcbd475 X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3809.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2020 07:54:52.8968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tF2yJDG+Duwad3EPOJDtVtsJWlyoF3/8iANvekzjeOdJ8TzwIUeNj2cyWE5Q0ECB X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4481 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 11, 2020 at 02:42:59PM +0800, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843 > > Refer to the UEFI spec 2.8, Section 13.3.2: > A block device should be scanned as below order: > 1. GPT > 2. ISO 9660 (El Torito) (UDF should aslo be here) > 4. MBR > 5. no partition found > > But the code implementation is: > 1. GPT > 2. MBR > 3. ISO 9660 (El Torito) (UDF) > 4. no partition found > > Which would cause the ISO 9960 image with MBR info be treated as MBR > device. That would cause unexpect behavior. So fix it to follow the spec > description. > > The fix of the PartitionInstallChildHandle would change the boot behavior > of Linux ISO image with MBR table. So add it after the order adjustment > to make no impact of the boot. > Thanks for the patches. After applying this patch series, the firmware recognizes openSUSE/SUSE iso images again. Tested-by: Gary Lin > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Cc: Gary Lin > Cc: Andrew Fish > Signed-off-by: Zhichao Gao > Zhichao Gao (3): > MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR > MdeModulePkg/PartitionDxe: Remove the check for special MBR > MdeModulePkg/PartitionDxe: Fix the incorrect LBA size in child hander > > .../Universal/Disk/PartitionDxe/Mbr.c | 19 ---------------- > .../Universal/Disk/PartitionDxe/Partition.c | 22 ++++++++++--------- > 2 files changed, 12 insertions(+), 29 deletions(-) > > -- > 2.21.0.windows.1 >