From: "Jeremy Linton" <jeremy.linton@arm.com>
To: devel@edk2.groups.io
Cc: Jeremy Linton <jeremy.linton@arm.com>,
Leif Lindholm <leif@nuviainc.com>, Pete Batard <pete@akeo.ie>,
Andrei Warkentin <awarkentin@vmware.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: [PATCH 2/3] Platform/RaspberryPi4: Create ACPI fan object
Date: Thu, 13 Aug 2020 18:00:55 -0500 [thread overview]
Message-ID: <20200813230056.40526-3-jeremy.linton@arm.com> (raw)
In-Reply-To: <20200813230056.40526-1-jeremy.linton@arm.com>
Now that we have a thermal zone we can add active cooling
by specifying active cooling points (_ACx) which can
be tied to fan objects that turn fans on/off using GPIO
pins.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
.../RaspberryPi/Drivers/ConfigDxe/SsdtThermal.asl | 83 ++++++++++++++++++++++
1 file changed, 83 insertions(+)
create mode 100644 Platform/RaspberryPi/Drivers/ConfigDxe/SsdtThermal.asl
diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/SsdtThermal.asl b/Platform/RaspberryPi/Drivers/ConfigDxe/SsdtThermal.asl
new file mode 100644
index 0000000000..c87bda6dbc
--- /dev/null
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/SsdtThermal.asl
@@ -0,0 +1,83 @@
+/** @file
+ *
+ * Secondary System Description Table (SSDT) for active (fan) cooling
+ *
+ * Copyright (c) 2020, Arm Ltd. All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-2-Clause-Patent
+ *
+ **/
+
+#include <IndustryStandard/Bcm2711.h>
+#include <IndustryStandard/Bcm2836.h>
+#include <IndustryStandard/Bcm2836Gpio.h>
+
+#include <IndustryStandard/Acpi.h>
+
+DefinitionBlock(__FILE__, "SSDT", 5, "RPIFDN", "RPITHFAN", 2)
+{
+#if (GPIO_FAN_PIN != 0)
+ External(\_SB_.EC0, DeviceObj)
+ External(\_SB_.EC0.TZ0, DeviceObj)
+
+ Scope (\_SB_.EC0)
+ {
+ // Describe a fan
+ PowerResource(PFAN, 0, 0) {
+ OperationRegion (GPIO, SystemMemory, GPIO_BASE_ADDRESS, 0x1000)
+ Field (GPIO, DWordAcc, NoLock, Preserve) {
+ Offset(0x1C),
+ GPS0, 32,
+ GPS1, 32,
+ RES1, 32,
+ GPC0, 32,
+ GPC1, 32,
+ RES2, 32,
+ GPL1, 32,
+ GPL2, 32
+ }
+ // We are hitting a GPIO pin to on/off the fan
+ // this assumes that UEFI has programmed the
+ // direction as OUT.
+ // (search "rpi gpio fan controller" for how to
+ // wire this up if your not electrically inclined
+ // the basic idea is to use a BJT/etc to switch a
+ // larger voltage through a fan where the GPIO pin
+ // feeds a NPN/PNP base. Thats because its unlikly
+ // that the fan can be driven directly from the GPIO
+ // pin due to hitting the current limit on the pins.
+ // Matching a resistor between the GPIO->Base can
+ // allow pretty much any random NPN with a reasonable
+ // EC current to work (to limit the GPIO current).)
+ Method (_STA) {
+ if ( GPL1 & (1 << GPIO_FAN_PIN) ) {
+ Return ( 1 ) // present and enabled
+ }
+ Return ( 0 )
+ }
+ Method (_ON) { //turn fan on
+ Store((1 << GPIO_FAN_PIN), GPS0)
+ }
+ Method (_OFF) { //turn fan off
+ Store((1 << GPIO_FAN_PIN), GPC0)
+ }
+ }
+ Device(FAN) {
+ // Note, not currently an ACPIv4 fan
+ // the latter adds speed control/detection
+ // but in the case of linux needs FIF, FPS, FSL, and FST
+ Name(_HID, EISAID("PNP0C0B"))
+ Name(_PR0, Package() {PFAN})
+ }
+ }
+
+ // merge in an active cooling point.
+ Scope (\_SB_.EC0.TZ0)
+ {
+ Method(_AC0) { return(3332) } // (60K) active cooling trip point,
+ // if this is lower than PSV then we
+ // prefer active cooling
+ Name(_AL0, Package(){\_SB_.EC0.FAN}) // the fan used for AC0 above
+ }
+#endif
+}
--
2.13.7
next prev parent reply other threads:[~2020-08-13 23:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 23:00 [PATCH 0/3] Platform/RasberryPi: Thermal zone Jeremy Linton
2020-08-13 23:00 ` [PATCH 1/3] Platform/RaspberryPi4: Add a basic thermal zone Jeremy Linton
2020-08-17 11:10 ` Pete Batard
2020-08-13 23:00 ` Jeremy Linton [this message]
2020-08-17 11:10 ` [edk2-devel] [PATCH 2/3] Platform/RaspberryPi4: Create ACPI fan object Pete Batard
2020-08-13 23:00 ` [PATCH 3/3] Platform/RaspberryPi: Add entry for user fan control Jeremy Linton
2020-08-17 11:10 ` Pete Batard
2020-08-17 18:10 ` Jeremy Linton
2020-08-17 14:31 ` [PATCH 0/3] Platform/RasberryPi: Thermal zone Ard Biesheuvel
2020-08-17 19:03 ` [edk2-devel] " Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813230056.40526-3-jeremy.linton@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox