From: "Leif Lindholm" <leif@nuviainc.com>
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Cc: devel@edk2.groups.io, Ard.Biesheuvel@arm.com,
thomas.abraham@arm.com, Aditya.Angadi@arm.com,
richard.storer@arm.com
Subject: Re: [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
Date: Thu, 20 Aug 2020 10:59:56 +0100 [thread overview]
Message-ID: <20200820095956.GA1191@vanye> (raw)
In-Reply-To: <1597848823-27171-1-git-send-email-vijayenthiran.subramaniam@arm.com>
On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote:
> PcdChipCount constant is used to define the maximum number chips
> included in the multi-chip configuration. Add this constant to the
> RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> constant to be used in the RDN1EdgeX2 ACPI tables.
This patch fixes a build failure, the commit message should say so,
and refer to which commit it fixes.
Also, this fixes a build failure introduced 3.5 months ago, and no one
noticed until now. Are we sure this platform belongs upstream?
/
Leif
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
> Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
> gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>
> + gArmSgiTokenSpaceGuid.PcdChipCount
> +
> gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-08-20 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 14:53 [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2 Vijayenthiran Subramaniam
2020-08-20 8:10 ` Ard Biesheuvel
2020-08-20 13:27 ` Sami Mujawar
2020-08-20 9:59 ` Leif Lindholm [this message]
2020-08-21 16:49 ` [edk2-devel] " mailinglistforreading
2020-08-21 16:54 ` Vijayenthiran Subramaniam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820095956.GA1191@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox