* [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
@ 2020-08-19 14:53 Vijayenthiran Subramaniam
2020-08-20 8:10 ` Ard Biesheuvel
2020-08-20 9:59 ` Leif Lindholm
0 siblings, 2 replies; 6+ messages in thread
From: Vijayenthiran Subramaniam @ 2020-08-19 14:53 UTC (permalink / raw)
To: devel, leif, Ard.Biesheuvel; +Cc: thomas.abraham, Aditya.Angadi, richard.storer
PcdChipCount constant is used to define the maximum number chips
included in the multi-chip configuration. Add this constant to the
RDN1EdgeX2 ACPI tables build information (INF) file to allow this
constant to be used in the RDN1EdgeX2 ACPI tables.
Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
---
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
index 974d9db543..d44f02ab0c 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
@@ -45,6 +45,8 @@
gArmSgiTokenSpaceGuid.PcdDramBlock2Base
gArmSgiTokenSpaceGuid.PcdDramBlock2Size
+ gArmSgiTokenSpaceGuid.PcdChipCount
+
gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
2020-08-19 14:53 [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2 Vijayenthiran Subramaniam
@ 2020-08-20 8:10 ` Ard Biesheuvel
2020-08-20 13:27 ` Sami Mujawar
2020-08-20 9:59 ` Leif Lindholm
1 sibling, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2020-08-20 8:10 UTC (permalink / raw)
To: Vijayenthiran Subramaniam, devel, leif
Cc: thomas.abraham, Aditya.Angadi, richard.storer, Sami Mujawar
(+ Sami)
On 8/19/20 4:53 PM, Vijayenthiran Subramaniam wrote:
> PcdChipCount constant is used to define the maximum number chips
> included in the multi-chip configuration. Add this constant to the
> RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> constant to be used in the RDN1EdgeX2 ACPI tables.
>
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
> Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
> gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>
> + gArmSgiTokenSpaceGuid.PcdChipCount
> +
> gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
2020-08-19 14:53 [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2 Vijayenthiran Subramaniam
2020-08-20 8:10 ` Ard Biesheuvel
@ 2020-08-20 9:59 ` Leif Lindholm
2020-08-21 16:49 ` [edk2-devel] " mailinglistforreading
2020-08-21 16:54 ` Vijayenthiran Subramaniam
1 sibling, 2 replies; 6+ messages in thread
From: Leif Lindholm @ 2020-08-20 9:59 UTC (permalink / raw)
To: Vijayenthiran Subramaniam
Cc: devel, Ard.Biesheuvel, thomas.abraham, Aditya.Angadi,
richard.storer
On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote:
> PcdChipCount constant is used to define the maximum number chips
> included in the multi-chip configuration. Add this constant to the
> RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> constant to be used in the RDN1EdgeX2 ACPI tables.
This patch fixes a build failure, the commit message should say so,
and refer to which commit it fixes.
Also, this fixes a build failure introduced 3.5 months ago, and no one
noticed until now. Are we sure this platform belongs upstream?
/
Leif
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
> Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
> gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>
> + gArmSgiTokenSpaceGuid.PcdChipCount
> +
> gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
2020-08-20 8:10 ` Ard Biesheuvel
@ 2020-08-20 13:27 ` Sami Mujawar
0 siblings, 0 replies; 6+ messages in thread
From: Sami Mujawar @ 2020-08-20 13:27 UTC (permalink / raw)
To: Ard Biesheuvel, Vijayenthiran Subramaniam, devel@edk2.groups.io,
leif@nuviainc.com
Cc: Thomas Abraham, Aditya Angadi, Richard Storer
It might be worth mentioning that this patch fixes the build issue with commit https://github.com/tianocore/edk2-platforms/commit/e8fe2026dd7936c8c1661ec9289766f3b0c6d382
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@arm.com>
Sent: 20 August 2020 09:10 AM
To: Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@arm.com>; devel@edk2.groups.io; leif@nuviainc.com
Cc: Thomas Abraham <thomas.abraham@arm.com>; Aditya Angadi <Aditya.Angadi@arm.com>; Richard Storer <Richard.Storer@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>
Subject: Re: [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
(+ Sami)
On 8/19/20 4:53 PM, Vijayenthiran Subramaniam wrote:
> PcdChipCount constant is used to define the maximum number chips
> included in the multi-chip configuration. Add this constant to the
> RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> constant to be used in the RDN1EdgeX2 ACPI tables.
>
> Signed-off-by: Vijayenthiran Subramaniam
> <vijayenthiran.subramaniam@arm.com>
> ---
> Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
> gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>
> + gArmSgiTokenSpaceGuid.PcdChipCount
> +
> gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
2020-08-20 9:59 ` Leif Lindholm
@ 2020-08-21 16:49 ` mailinglistforreading
2020-08-21 16:54 ` Vijayenthiran Subramaniam
1 sibling, 0 replies; 6+ messages in thread
From: mailinglistforreading @ 2020-08-21 16:49 UTC (permalink / raw)
To: devel, leif
Cc: Ard.Biesheuvel, thomas.abraham, Aditya.Angadi, richard.storer,
sami.mujawar
Hi Leif
On Thu, Aug 20, 2020 at 10:00 AM Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote:
> > PcdChipCount constant is used to define the maximum number chips
> > included in the multi-chip configuration. Add this constant to the
> > RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> > constant to be used in the RDN1EdgeX2 ACPI tables.
>
> This patch fixes a build failure, the commit message should say so,
> and refer to which commit it fixes.
>
Okay, I will do that.
> Also, this fixes a build failure introduced 3.5 months ago, and no one
> noticed until now. Are we sure this platform belongs upstream?
This was noticed after the patch was merged upstream. This probably
slipped through during the patch rework and rebase. This was fixed
outside of the upstream code but missed to get this merged upstream.
Regards,
Vijayenthiran
>
> /
> Leif
>
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > ---
> > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > index 974d9db543..d44f02ab0c 100644
> > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > @@ -45,6 +45,8 @@
> > gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> > gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >
> > + gArmSgiTokenSpaceGuid.PcdChipCount
> > +
> > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> > gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> > --
> > 2.17.1
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
2020-08-20 9:59 ` Leif Lindholm
2020-08-21 16:49 ` [edk2-devel] " mailinglistforreading
@ 2020-08-21 16:54 ` Vijayenthiran Subramaniam
1 sibling, 0 replies; 6+ messages in thread
From: Vijayenthiran Subramaniam @ 2020-08-21 16:54 UTC (permalink / raw)
To: devel, leif
Cc: Ard.Biesheuvel, thomas.abraham, Aditya.Angadi, richard.storer,
sami.mujawar
Hi Leif,
On Thu, Aug 20, 2020 at 10:00 AM Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote:
> > PcdChipCount constant is used to define the maximum number chips
> > included in the multi-chip configuration. Add this constant to the
> > RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> > constant to be used in the RDN1EdgeX2 ACPI tables.
>
> This patch fixes a build failure, the commit message should say so,
> and refer to which commit it fixes.
>
Okay, I will do that.
> Also, this fixes a build failure introduced 3.5 months ago, and no one
> noticed until now. Are we sure this platform belongs upstream?
>
This was noticed after the patch was merged upstream. This probably
slipped through during the patch rework and rebase. This was fixed
outside of the upstream code but missed to get this merged upstream.
Regards,
Vijayenthiran
> /
> Leif
>
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > ---
> > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > index 974d9db543..d44f02ab0c 100644
> > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > @@ -45,6 +45,8 @@
> > gArmSgiTokenSpaceGuid.PcdDramBlock2Base
> > gArmSgiTokenSpaceGuid.PcdDramBlock2Size
> >
> > + gArmSgiTokenSpaceGuid.PcdChipCount
> > +
> > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
> > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
> > gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-21 16:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-19 14:53 [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2 Vijayenthiran Subramaniam
2020-08-20 8:10 ` Ard Biesheuvel
2020-08-20 13:27 ` Sami Mujawar
2020-08-20 9:59 ` Leif Lindholm
2020-08-21 16:49 ` [edk2-devel] " mailinglistforreading
2020-08-21 16:54 ` Vijayenthiran Subramaniam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox