From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web11.107349.1597917601024726958 for ; Thu, 20 Aug 2020 03:00:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=2JyRk589; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id y3so1436688wrl.4 for ; Thu, 20 Aug 2020 03:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZOsFFRr3g9vfU0V0F9rPfoqRbFFpOYPtnkbA/iERQV0=; b=2JyRk5890jlesYL9csIn0Ht/BSC4ehZ+PmMCkuDbt69X2v/ToDCE6LBaQ85Z3W6sev awZuRTjJjzsMjXPYgXwVcwKHg5s37Fz/flYBrpEXBapFjfc8s9iShxynlHaQ/qQXdOqS 6HE+jJN5qH6pQpwnGIF6uahqhNlytwBqMfczfirUBJffVKaS4dTam+87vKg9QfVoWClm SrC9Titb2kGnz5ZF74F3iAxH1WvPXBWHgPYDogqO9ZxdDnYIVNHhG+vW2MwOzQoSGGOX a4M05mZdHHD9lW1ng66lyU9jq4WIb946CAKZjSuLQSU7auf1Pd7YRDuyBfxWqLCGqftX xgyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZOsFFRr3g9vfU0V0F9rPfoqRbFFpOYPtnkbA/iERQV0=; b=tTgvg10AqKC88xAqqL3ySVRBjG5cDk4gOZBTkq0ku7DoXvN9odQOPnSMkkJT6UNomw WQjjSPHIkaZ8Ugo3sAbeOiZzd9tBctsuE6bUP9cK7Nw4xCSxwjC3NSqdg8OcP/IiVKUr gyyrAXVybCJ5WSRjGdaeto4ZJ34NKVRmmvmeysmgU0yCWYyP9YVK84+OOl1CqpeMpdE0 pLlmKIglKBT9M/LEPuBedfq9w8Ugw6odDRvByGMySHUfjBMr2SAlg8Vh3AROqz2tZtzj JIeUjXMKONjv8PQ7Xp2ZhIipNg93WLWUWG3LesBZ2YqCy617C5PAhi6DaNDvfEYEO/ZW Trnw== X-Gm-Message-State: AOAM533ystO/18+yERQxwVLq5q/8PkfqQucNdHqxrp/DYwCp6MTmszJZ VNPRBdj+osP1/MhYUAJnVRjKHg== X-Google-Smtp-Source: ABdhPJyKpcmHox9lER/JSG9kMsVXxGPzeCPQAspjgMJz+tmqz6wAKxK3YI/W8ZnEUeQL8swCbXVPRA== X-Received: by 2002:adf:818b:: with SMTP id 11mr2269716wra.141.1597917599455; Thu, 20 Aug 2020 02:59:59 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id i22sm3740355wrb.45.2020.08.20.02.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2020 02:59:58 -0700 (PDT) Date: Thu, 20 Aug 2020 10:59:56 +0100 From: "Leif Lindholm" To: Vijayenthiran Subramaniam Cc: devel@edk2.groups.io, Ard.Biesheuvel@arm.com, thomas.abraham@arm.com, Aditya.Angadi@arm.com, richard.storer@arm.com Subject: Re: [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2 Message-ID: <20200820095956.GA1191@vanye> References: <1597848823-27171-1-git-send-email-vijayenthiran.subramaniam@arm.com> MIME-Version: 1.0 In-Reply-To: <1597848823-27171-1-git-send-email-vijayenthiran.subramaniam@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote: > PcdChipCount constant is used to define the maximum number chips > included in the multi-chip configuration. Add this constant to the > RDN1EdgeX2 ACPI tables build information (INF) file to allow this > constant to be used in the RDN1EdgeX2 ACPI tables. This patch fixes a build failure, the commit message should say so, and refer to which commit it fixes. Also, this fixes a build failure introduced 3.5 months ago, and no one noticed until now. Are we sure this platform belongs upstream? / Leif > Signed-off-by: Vijayenthiran Subramaniam > --- > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > index 974d9db543..d44f02ab0c 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > @@ -45,6 +45,8 @@ > gArmSgiTokenSpaceGuid.PcdDramBlock2Base > gArmSgiTokenSpaceGuid.PcdDramBlock2Size > > + gArmSgiTokenSpaceGuid.PcdChipCount > + > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum > gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum > -- > 2.17.1 >