From: Joseph Hemann <joseph.hemann@arm.com>
To: devel@edk2.groups.io
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Eric Jin <eric.jin@intel.com>, Irene Park <ipark@nvidia.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Subject: [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer
Date: Wed, 26 Aug 2020 16:46:03 -0500 [thread overview]
Message-ID: <20200826214603.11530-1-joseph.hemann@arm.com> (raw)
gcc_version returned by compiler is a string, and needs to be converted
to a integer before testing
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Eric Jin <eric.jin@intel.com>
Cc: Irene Park <ipark@nvidia.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Signed-off-by: Joseph Hemann <joseph.hemann@arm.com>
Change-Id: I24f3f52c12660928b58e6f836fdef86890688d26
---
uefi-sct/SctPkg/build.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh
index d0c7f16e172c..cad17ccdedc7 100755
--- a/uefi-sct/SctPkg/build.sh
+++ b/uefi-sct/SctPkg/build.sh
@@ -56,8 +56,8 @@ function get_gcc_version
{
gcc_version=$($1 -dumpversion)
- if [ "$gcc_version" -gt "5" ]; then
- gcc_version="5"
+ if [ ${gcc_version%%.*} -gt 5 ]; then
+ gcc_version=5
fi
case $gcc_version in
--
2.17.1
next reply other threads:[~2020-08-26 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 21:46 Joseph Hemann [this message]
2020-09-03 16:10 ` [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer Samer El-Haj-Mahmoud
2020-09-14 9:23 ` [edk2-devel] " G Edhaya Chandran
2020-09-14 10:09 ` G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826214603.11530-1-joseph.hemann@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox