From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.7326.1598484019182220254 for ; Wed, 26 Aug 2020 16:20:19 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: samer.el-haj-mahmoud@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 700CA31B; Wed, 26 Aug 2020 16:20:17 -0700 (PDT) Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B6B53F66B; Wed, 26 Aug 2020 16:20:17 -0700 (PDT) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Pete Batard , Andrei Warkentin Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe Date: Wed, 26 Aug 2020 19:20:15 -0400 Message-Id: <20200826232015.9030-1-Samer.El-Haj-Mahmoud@arm.com> X-Mailer: git-send-email 2.17.1 Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding extern module global, but did not remove the STATIC declaration, which caused the build to break. Fix the build error by removing STATIC for that module global variable. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c index ae4b2735820c..3eba98e5aa87 100644 --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c @@ -87,7 +87,7 @@ DisplayBlt ( IN UINTN Delta OPTIONAL ); -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = { +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = { DriverSupported, DriverStart, DriverStop, -- 2.17.1