From: "Leif Lindholm" <leif@nuviainc.com>
To: Abner Chang <abner.chang@hpe.com>
Cc: devel@edk2.groups.io, Daniel Schaefer <daniel.schaefer@hpe.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-plaforms PATCH 1/3] edk2-platforms: Revise Readme.md
Date: Thu, 27 Aug 2020 14:01:03 +0100 [thread overview]
Message-ID: <20200827130103.GT1191@vanye> (raw)
In-Reply-To: <20200827120305.26095-2-abner.chang@hpe.com>
You have a typo in the list name inside [] above.
If that's in your static config, please fix it.
If it's not, please make one :)
For this actual patch (unaffected by the above):
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
On Thu, Aug 27, 2020 at 20:03:03 +0800, Abner Chang wrote:
> Mention to update submodule under for edk2-platforms. It is for RISC-V OpenSBI library.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Co-authored-by: Daniel Schaefer <daniel.schaefer@hpe.com>
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> Readme.md | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Readme.md b/Readme.md
> index 0675685fb7..d896b2c5fc 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -97,6 +97,7 @@ target-specific binutils. These are included with any prepackaged GCC toolchain
> $ git submodule update --init
> ...
> $ git clone https://github.com/tianocore/edk2-platforms.git
> + $ git submodule update --init
> ...
> $ git clone https://github.com/tianocore/edk2-non-osi.git
> ```
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-08-27 13:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 12:03 [edk2-plaforms PATCH 0/3] Revise Readme for RISC-V updates Abner Chang
2020-08-27 12:03 ` [edk2-plaforms PATCH 1/3] edk2-platforms: Revise Readme.md Abner Chang
2020-08-27 13:01 ` Leif Lindholm [this message]
2020-08-27 13:14 ` Abner Chang
2020-08-27 12:03 ` [edk2-plaforms PATCH 2/3] RISC-V/PlatformPkg: " Abner Chang
2020-08-27 13:23 ` [edk2-devel] " Leif Lindholm
2020-08-27 16:33 ` Abner Chang
2020-08-27 12:03 ` [edk2-plaforms PATCH 3/3] Platform/U5SeriesPkg: " Abner Chang
2020-08-27 13:24 ` [edk2-devel] " Leif Lindholm
2020-08-27 13:43 ` Daniel Schaefer
2020-08-27 14:06 ` Abner Chang
2020-08-27 14:54 ` Daniel Schaefer
2020-08-27 16:37 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827130103.GT1191@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox