[edk2-platforms][Patch 0/3] Fix Quark build issues

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [edk2-platforms][Patch 0/3] Fix Quark build issues
@ 2020-08-28 19:14 Michael D Kinney
  2020-08-28 19:14 ` [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID Michael D Kinney
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Michael D Kinney @ 2020-08-28 19:14 UTC (permalink / raw)
  To: devel

Fix issues that are generating build breaks for Quark:

* Missing GUID in INF
* References to a retired PCD
* Use of TIANOCOMPRESS RuleOverride that appears to be a BaseTools
  regression.

Michael D Kinney (3):
  QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID
  QuarkPlatformPkg: Removed reference to retired PCD
  QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride

 Platform/Intel/QuarkPlatformPkg/Quark.dsc                    | 5 +----
 Platform/Intel/QuarkPlatformPkg/Quark.fdf                    | 2 +-
 Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                 | 5 +----
 .../Library/QNCAccessLib/RuntimeQNCAccessLib.inf             | 5 ++++-
 4 files changed, 7 insertions(+), 10 deletions(-)

-- 
2.21.0.windows.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID
  2020-08-28 19:14 [edk2-platforms][Patch 0/3] Fix Quark build issues Michael D Kinney
@ 2020-08-28 19:14 ` Michael D Kinney
  2020-08-28 19:16   ` Steele, Kelly
  2020-08-28 19:14 ` [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference to retired PCD Michael D Kinney
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Michael D Kinney @ 2020-08-28 19:14 UTC (permalink / raw)
  To: devel; +Cc: Kelly Steele

Add missing gEfiEventVirtualAddressChangeGuid to the
[Guids] section.

Cc: Kelly Steele <kelly.steele@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 .../Library/QNCAccessLib/RuntimeQNCAccessLib.inf             | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Silicon/Intel/QuarkSocPkg/QuarkNorthCluster/Library/QNCAccessLib/RuntimeQNCAccessLib.inf b/Silicon/Intel/QuarkSocPkg/QuarkNorthCluster/Library/QNCAccessLib/RuntimeQNCAccessLib.inf
index 0e6aa4cd97..0d3e1a5630 100644
--- a/Silicon/Intel/QuarkSocPkg/QuarkNorthCluster/Library/QNCAccessLib/RuntimeQNCAccessLib.inf
+++ b/Silicon/Intel/QuarkSocPkg/QuarkNorthCluster/Library/QNCAccessLib/RuntimeQNCAccessLib.inf
@@ -3,7 +3,7 @@
 #
 # Intel QNC internal network access Library Instance.
 #
-# Copyright (c) 2013-2015 Intel Corporation.
+# Copyright (c) 2013-2020 Intel Corporation.
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -39,5 +39,8 @@ [LibraryClasses]
   UefiBootServicesTableLib
   UefiRuntimeLib
 
+[Guids]
+  gEfiEventVirtualAddressChangeGuid
+
 [Pcd]
   gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID
  2020-08-28 19:14 ` [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID Michael D Kinney
@ 2020-08-28 19:16   ` Steele, Kelly
  0 siblings, 0 replies; 8+ messages in thread
From: Steele, Kelly @ 2020-08-28 19:16 UTC (permalink / raw)
  To: Kinney, Michael D, devel@edk2.groups.io



Reviewed-by: Kelly Steele <kelly.steele@intel.com>

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, August 28, 2020 12:14 PM
> To: devel@edk2.groups.io
> Cc: Steele, Kelly <kelly.steele@intel.com>
> Subject: [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib:
> Add missing GUID
> 
> Add missing gEfiEventVirtualAddressChangeGuid to the
> [Guids] section.
> 
> Cc: Kelly Steele <kelly.steele@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  .../Library/QNCAccessLib/RuntimeQNCAccessLib.inf             | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git
> a/Silicon/Intel/QuarkSocPkg/QuarkNorthCluster/Library/QNCAccessLib/Runti
> meQNCAccessLib.inf
> b/Silicon/Intel/QuarkSocPkg/QuarkNorthCluster/Library/QNCAccessLib/Runt
> imeQNCAccessLib.inf
> index 0e6aa4cd97..0d3e1a5630 100644
> ---
> a/Silicon/Intel/QuarkSocPkg/QuarkNorthCluster/Library/QNCAccessLib/Runti
> meQNCAccessLib.inf
> +++
> b/Silicon/Intel/QuarkSocPkg/QuarkNorthCluster/Library/QNCAccessLib/Runt
> imeQNCAccessLib.inf
> @@ -3,7 +3,7 @@
>  #
>  # Intel QNC internal network access Library Instance.
>  #
> -# Copyright (c) 2013-2015 Intel Corporation.
> +# Copyright (c) 2013-2020 Intel Corporation.
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -39,5 +39,8 @@ [LibraryClasses]
>    UefiBootServicesTableLib
>    UefiRuntimeLib
> 
> +[Guids]
> +  gEfiEventVirtualAddressChangeGuid
> +
>  [Pcd]
>    gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> --
> 2.21.0.windows.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference to retired PCD
  2020-08-28 19:14 [edk2-platforms][Patch 0/3] Fix Quark build issues Michael D Kinney
  2020-08-28 19:14 ` [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID Michael D Kinney
@ 2020-08-28 19:14 ` Michael D Kinney
  2020-08-28 19:16   ` kelly.steele
  2020-08-28 19:14 ` [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride Michael D Kinney
  2020-08-28 19:16 ` [edk2-devel] [edk2-platforms][Patch 0/3] Fix Quark build issues Steele, Kelly
  3 siblings, 1 reply; 8+ messages in thread
From: Michael D Kinney @ 2020-08-28 19:14 UTC (permalink / raw)
  To: devel; +Cc: Kelly Steele

Remove all references to the following PCD that has been
retired:

gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout

Cc: Kelly Steele <kelly.steele@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 Platform/Intel/QuarkPlatformPkg/Quark.dsc    | 5 +----
 Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
index e352aed49f..2e4e3491ee 100644
--- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
+++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
@@ -2,7 +2,7 @@
 # Clanton Peak CRB platform with 32-bit DXE for 4MB/8MB flash devices.
 #
 # This package provides Clanton Peak CRB platform specific modules.
-# Copyright (c) 2013 - 2019 Intel Corporation.
+# Copyright (c) 2013 - 2020 Intel Corporation.
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -384,9 +384,6 @@ [PcdsFixedAtBuild]
 !endif
   gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00002000
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x1000
-  ## RTC Update Timeout Value, need to increase timeout since also
-  # waiting for RTC to be busy.
-  gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|500000
 
 !if $(SECURE_BOOT_ENABLE)
   # override the default values from SecurityPkg to ensure images from all sources are verified in secure boot
diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
index d1e2c0f437..ec52fe0fe4 100644
--- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
+++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
@@ -2,7 +2,7 @@
 # Clanton Peak CRB platform with 32-bit DXE for 4MB/8MB flash devices.
 #
 # This package provides Clanton Peak CRB platform specific modules.
-# Copyright (c) 2013 - 2019 Intel Corporation.
+# Copyright (c) 2013 - 2020 Intel Corporation.
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -340,9 +340,6 @@ [PcdsFixedAtBuild]
   # Make VariableRuntimeDxe work at emulated non-volatile variable mode.
   #
   gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE
-  ## RTC Update Timeout Value, need to increase timeout since also
-  # waiting for RTC to be busy.
-  gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|500000
 
 !if $(SECURE_BOOT_ENABLE)
   # override the default values from SecurityPkg to ensure images from all sources are verified in secure boot
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference to retired PCD
  2020-08-28 19:14 ` [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference to retired PCD Michael D Kinney
@ 2020-08-28 19:16   ` kelly.steele
  0 siblings, 0 replies; 8+ messages in thread
From: kelly.steele @ 2020-08-28 19:16 UTC (permalink / raw)
  To: Kinney, Michael D, devel@edk2.groups.io



Reviewed-by: Kelly Steele <kelly.steele@intel.com>

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, August 28, 2020 12:14 PM
> To: devel@edk2.groups.io
> Cc: Steele, Kelly <kelly.steele@intel.com>
> Subject: [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference
> to retired PCD
> 
> Remove all references to the following PCD that has been
> retired:
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout
> 
> Cc: Kelly Steele <kelly.steele@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Platform/Intel/QuarkPlatformPkg/Quark.dsc    | 5 +----
>  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 5 +----
>  2 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> index e352aed49f..2e4e3491ee 100644
> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> @@ -2,7 +2,7 @@
>  # Clanton Peak CRB platform with 32-bit DXE for 4MB/8MB flash devices.
>  #
>  # This package provides Clanton Peak CRB platform specific modules.
> -# Copyright (c) 2013 - 2019 Intel Corporation.
> +# Copyright (c) 2013 - 2020 Intel Corporation.
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -384,9 +384,6 @@ [PcdsFixedAtBuild]
>  !endif
>    gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00002000
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x1
> 000
> -  ## RTC Update Timeout Value, need to increase timeout since also
> -  # waiting for RTC to be busy.
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|5000
> 00
> 
>  !if $(SECURE_BOOT_ENABLE)
>    # override the default values from SecurityPkg to ensure images from all
> sources are verified in secure boot
> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> index d1e2c0f437..ec52fe0fe4 100644
> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> @@ -2,7 +2,7 @@
>  # Clanton Peak CRB platform with 32-bit DXE for 4MB/8MB flash devices.
>  #
>  # This package provides Clanton Peak CRB platform specific modules.
> -# Copyright (c) 2013 - 2019 Intel Corporation.
> +# Copyright (c) 2013 - 2020 Intel Corporation.
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -340,9 +340,6 @@ [PcdsFixedAtBuild]
>    # Make VariableRuntimeDxe work at emulated non-volatile variable mode.
>    #
>    gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE
> -  ## RTC Update Timeout Value, need to increase timeout since also
> -  # waiting for RTC to be busy.
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|5000
> 00
> 
>  !if $(SECURE_BOOT_ENABLE)
>    # override the default values from SecurityPkg to ensure images from all
> sources are verified in secure boot
> --
> 2.21.0.windows.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride
  2020-08-28 19:14 [edk2-platforms][Patch 0/3] Fix Quark build issues Michael D Kinney
  2020-08-28 19:14 ` [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID Michael D Kinney
  2020-08-28 19:14 ` [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference to retired PCD Michael D Kinney
@ 2020-08-28 19:14 ` Michael D Kinney
  2020-08-28 19:16   ` Steele, Kelly
  2020-08-28 19:16 ` [edk2-devel] [edk2-platforms][Patch 0/3] Fix Quark build issues Steele, Kelly
  3 siblings, 1 reply; 8+ messages in thread
From: Michael D Kinney @ 2020-08-28 19:14 UTC (permalink / raw)
  To: devel; +Cc: Kelly Steele

Temporarily disable use of TIANOCOMPRESSED RuleOverride.
This is causing a build break and appears to be a regression
in BaseTools.  Once BaseTools issue is resolved, this change
can be reverted.

Cc: Kelly Steele <kelly.steele@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 Platform/Intel/QuarkPlatformPkg/Quark.fdf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.fdf b/Platform/Intel/QuarkPlatformPkg/Quark.fdf
index cc71cbe999..53d2820ad4 100644
--- a/Platform/Intel/QuarkPlatformPkg/Quark.fdf
+++ b/Platform/Intel/QuarkPlatformPkg/Quark.fdf
@@ -675,7 +675,7 @@ [FV.PAYLOAD]
 #
 # Shell and Applications
 #
-INF  RuleOverride = TIANOCOMPRESSED ShellPkg/Application/Shell/Shell.inf
+INF  ShellPkg/Application/Shell/Shell.inf
 
 !if $(CAPSULE_ENABLE) || $(RECOVERY_ENABLE)
 
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride
  2020-08-28 19:14 ` [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride Michael D Kinney
@ 2020-08-28 19:16   ` Steele, Kelly
  0 siblings, 0 replies; 8+ messages in thread
From: Steele, Kelly @ 2020-08-28 19:16 UTC (permalink / raw)
  To: Kinney, Michael D, devel@edk2.groups.io



Reviewed-by: Kelly Steele <kelly.steele@intel.com>

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, August 28, 2020 12:14 PM
> To: devel@edk2.groups.io
> Cc: Steele, Kelly <kelly.steele@intel.com>
> Subject: [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of
> TIANOCOMPRESSED RuleOverride
> 
> Temporarily disable use of TIANOCOMPRESSED RuleOverride.
> This is causing a build break and appears to be a regression
> in BaseTools.  Once BaseTools issue is resolved, this change
> can be reverted.
> 
> Cc: Kelly Steele <kelly.steele@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Platform/Intel/QuarkPlatformPkg/Quark.fdf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.fdf
> b/Platform/Intel/QuarkPlatformPkg/Quark.fdf
> index cc71cbe999..53d2820ad4 100644
> --- a/Platform/Intel/QuarkPlatformPkg/Quark.fdf
> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.fdf
> @@ -675,7 +675,7 @@ [FV.PAYLOAD]
>  #
>  # Shell and Applications
>  #
> -INF  RuleOverride = TIANOCOMPRESSED ShellPkg/Application/Shell/Shell.inf
> +INF  ShellPkg/Application/Shell/Shell.inf
> 
>  !if $(CAPSULE_ENABLE) || $(RECOVERY_ENABLE)
> 
> --
> 2.21.0.windows.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [edk2-platforms][Patch 0/3] Fix Quark build issues
  2020-08-28 19:14 [edk2-platforms][Patch 0/3] Fix Quark build issues Michael D Kinney
                   ` (2 preceding siblings ...)
  2020-08-28 19:14 ` [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride Michael D Kinney
@ 2020-08-28 19:16 ` Steele, Kelly
  3 siblings, 0 replies; 8+ messages in thread
From: Steele, Kelly @ 2020-08-28 19:16 UTC (permalink / raw)
  To: devel@edk2.groups.io, Kinney, Michael D



Reviewed-by: Kelly Steele <kelly.steele@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> D Kinney
> Sent: Friday, August 28, 2020 12:14 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-platforms][Patch 0/3] Fix Quark build issues
> 
> Fix issues that are generating build breaks for Quark:
> 
> * Missing GUID in INF
> * References to a retired PCD
> * Use of TIANOCOMPRESS RuleOverride that appears to be a BaseTools
>   regression.
> 
> Michael D Kinney (3):
>   QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID
>   QuarkPlatformPkg: Removed reference to retired PCD
>   QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride
> 
>  Platform/Intel/QuarkPlatformPkg/Quark.dsc                    | 5 +----
>  Platform/Intel/QuarkPlatformPkg/Quark.fdf                    | 2 +-
>  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                 | 5 +----
>  .../Library/QNCAccessLib/RuntimeQNCAccessLib.inf             | 5 ++++-
>  4 files changed, 7 insertions(+), 10 deletions(-)
> 
> --
> 2.21.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-08-28 19:18 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-28 19:14 [edk2-platforms][Patch 0/3] Fix Quark build issues Michael D Kinney
2020-08-28 19:14 ` [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID Michael D Kinney
2020-08-28 19:16   ` Steele, Kelly
2020-08-28 19:14 ` [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference to retired PCD Michael D Kinney
2020-08-28 19:16   ` kelly.steele
2020-08-28 19:14 ` [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride Michael D Kinney
2020-08-28 19:16   ` Steele, Kelly
2020-08-28 19:16 ` [edk2-devel] [edk2-platforms][Patch 0/3] Fix Quark build issues Steele, Kelly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox