Re: [PATCH 1/1] Maintainers.txt: Update reviewers of */RiscV64

["Leif Lindholm" <leif@nuviainc.com>]

On Sun, Aug 30, 2020 at 16:03:06 +0800, Abner Chang wrote:
> Add reviewers for all /RiscV64 folders.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  Maintainers.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 57cd2fc662..ff34a24abd 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -98,6 +98,11 @@ F: */Arm/
>  M: Leif Lindholm <leif@nuviainc.com>
>  M: Ard Biesheuvel <ard.biesheuvel@arm.com>
>  
> +RISCV64
> +F: */RiscV64/
> +R: Abner Chang <abner.chang@hpe.com>
> +R: Daniel Schaefer <daniel.schaefer@hpe.com>

I think we want an M: entry for this, and I think that should be you
(since you have the access privileges). It signifies that you are the
one responsible for patches that have been reviewed actually get
pushed.

This doesn't always mean you need to do it yourself, especially for
this entry which will always overlap with other entries (like MdePkg,
MdeModulePkg, ...), but it does make it clear that you need to make
sure it doesn't get dropped.

With that change:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> +
>  EDK II Continuous Integration:
>  ------------------------------
>  .azurepipelines/
> -- 
> 2.25.0
>