From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web11.30165.1598787845888325522 for ; Sun, 30 Aug 2020 04:44:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=a179ES+r; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id w2so2943337wmi.1 for ; Sun, 30 Aug 2020 04:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=37gd0dhMNSJgdwHYqmOPGzQDbT/6EuA5aXe4wVQ+ZSw=; b=a179ES+rBW+OE8j7Ji+BYqci4pYDRQxmjORa2jmgqqxSciwq+uN4uJUFC6GrK9fdDI jvABXZcKEvGSAo4RDdgBlwrL8K3D/x1bFWbToBvrBqeAPVOCGuV49moz+UXFiIo0nV/l sXhNw7+vAbGAlsvoPo9Q8Es1HumaQDuhj6ua//26LjnvwxLAnf0XNpDKtDrVSzpzmW/I WwxbKYKrsy48YEwcZFxQrLUbzLw1cWGyfXsJNnfLa72fuU5J44x5NyNtKFqkLrKiyGu5 Ku/jyiGqezNE6nb30gmHGwy7d2hq/7kHMSKaRrzR3qfYtCw37KfH1tco1+dQD49d/U45 0PrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=37gd0dhMNSJgdwHYqmOPGzQDbT/6EuA5aXe4wVQ+ZSw=; b=GW5vsjZsHUpacNMFpSrPRY908HtkKesESN6ZhIEVGHbbgo4nkiQQabkEBmg56K7n/E QS5vH4H/KWcWV4hmG1ysXycEmpLSh9NLtPuWrWLGwgPe10JeLDgEFoEGDaEvED8Huaia 5iQdt+zL1dW/lLOi4KQF6IOiGGfZa75IqWkwkMdkR1xCJkRmtHHwonPFADbMcX79/ssE ESGlHHT7BFdabneQoDMqOqJuCKMX2oiMzXUIX65QmSD6VhndpQ9Z8S6apj7kgoK8FNRv 2ISWU18HjxFFhiNbR6ikwfM9F4oR3qMVYygsPB+dilDU2Ssr3GI35WxaOXtpw7oMjTxk 6W5A== X-Gm-Message-State: AOAM530GSsRT4PTlMPYlRsiTJMSTeK+fZa1UHOln3e/D5WKA8kMRHpuc 11cc5ccEGva+v84eFeoLk/ySrg== X-Google-Smtp-Source: ABdhPJxgdosoO8TAeN3a1j0Vp+90KqbswnyamG6sMUPBYBr5O9CVGk2DOrfAt+AsCiy892DMnvRUWw== X-Received: by 2002:a1c:ed15:: with SMTP id l21mr6812856wmh.56.1598787844401; Sun, 30 Aug 2020 04:44:04 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id h186sm1834904wmf.24.2020.08.30.04.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 04:44:03 -0700 (PDT) Date: Sun, 30 Aug 2020 12:44:01 +0100 From: "Leif Lindholm" To: Abner Chang Cc: devel@edk2.groups.io, Andrew Fish , Laszlo Ersek , Michael D Kinney , Leif Lindholm Subject: Re: [PATCH 1/1] Maintainers.txt: Update reviewers of */RiscV64 Message-ID: <20200830114401.GB20124@vanye> References: <20200830080306.17769-1-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <20200830080306.17769-1-abner.chang@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Aug 30, 2020 at 16:03:06 +0800, Abner Chang wrote: > Add reviewers for all /RiscV64 folders. > > Signed-off-by: Abner Chang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Leif Lindholm > --- > Maintainers.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 57cd2fc662..ff34a24abd 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -98,6 +98,11 @@ F: */Arm/ > M: Leif Lindholm > M: Ard Biesheuvel > > +RISCV64 > +F: */RiscV64/ > +R: Abner Chang > +R: Daniel Schaefer I think we want an M: entry for this, and I think that should be you (since you have the access privileges). It signifies that you are the one responsible for patches that have been reviewed actually get pushed. This doesn't always mean you need to do it yourself, especially for this entry which will always overlap with other entries (like MdePkg, MdeModulePkg, ...), but it does make it clear that you need to make sure it doesn't get dropped. With that change: Reviewed-by: Leif Lindholm > + > EDK II Continuous Integration: > ------------------------------ > .azurepipelines/ > -- > 2.25.0 >