Re: [PATCH edk2-platforms 1/1] Silicon/SiFive: fix RELEASE builds of U54 PeiCoreInfoHobLib

["Leif Lindholm" <leif@nuviainc.com>]

On Sun, Aug 30, 2020 at 12:59:06 +0000, Chang, Abner (HPS SW/FW Technologist) wrote:
> > > > @@ -63,7 +64,8 @@ CreateU54E51CoreProcessorSpecificDataHob (
> > > >      return EFI_INVALID_PARAMETER;
> > > >    }
> > > >
> > > > -  ASSERT_EFI_ERROR (SbiGetFirmwareContext (&FirmwareContext));
> > > > +  Status = SbiGetFirmwareContext (&FirmwareContext);
> > > > ASSERT_EFI_ERROR
> > > ASSERT_EFI_ERROR() should start at the new line. I see this macro just
> > > attached to the end of Status = SbiGetFirmwareContext
> > > (&FirmwareContext). Is my editor problem?
> > 
> > INVALID URI REMOVED
> > 3A__edk2.groups.io_g_devel_message_64794&d=DwIBAg&c=C5b8zRQO1mi
> > GmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=
> > UkdQYKg5exPcuGmzwjtBQvaRGX5SPNiaP9ko8nTDWgQ&s=r0p7ssf1Q8Y2070
> > L71hNFsILUzkHznlm5k8mpyVeV9k&e=
> > It's your editor.
> Ok.
> > 
> > > > + (Status);
> > > Please add error condition check for the Status. Return
> > > EFI_INVALID_PARAMETERS to caller, and also update the function header
> > > for the case of @retval is EFI_INVALID_PARAMETER. Just realized that
> > > we use @return in the function header instead of @retval.
> > 
> > I agree this looks like a better way of handling the failure, but I'll leave that to
> > you. This patch simply stops the current handling from breaking RELEASE
> > builds.
> Sure!
> 
> Reviewed-by: Abner Chang <abner.chang@hpe.com>

Thanks.
Pushed as 50639477fc0f.

> > 
> > Regards,
> > 
> > Leif
> > 
> > >
> > > Thanks for this.
> > > Abner
> > >
> > > >    DEBUG ((DEBUG_INFO, "    Firmware Context is at 0x%x.\n",
> > > > FirmwareContext));
> > > >    FirmwareContextHartSpecific = FirmwareContext->HartSpecific[HartId];
> > > >    DEBUG ((DEBUG_INFO, "    Firmware Context Hart specific is at 0x%x.\n",
> > > > FirmwareContextHartSpecific));
> > > > --
> > > > 2.20.1
> > >