From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.31751.1598794205163607232 for ; Sun, 30 Aug 2020 06:30:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=uKgvXy1q; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id t14so3009543wmi.3 for ; Sun, 30 Aug 2020 06:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ekJhGTk6fOUeDhH74HHbt0M4kSAyKLVlhCg4tTGslIw=; b=uKgvXy1qUC2nQC40E7YIa0vK6Z/RJKtYG28hUO24EXnTfqFixHy4tNQQLvfNEia6V2 qAcYwmU6pPox2M+4FrkeAFpFmIiGMieL5EDMADBYqV1qXVkqFbaI1pY19dnh7DV93Mrr 4zvHiwbnN2s0xgK9YpW5BhYuF5PAgAswFss9DjLwYaNR307optzf6EOKZCAkTgIYDPZM ngaYJ6BFDYUVeItw4aObQUktd/jAkpARVHKp3pzW2Ar1fN+jp/lv+FkHdov9U0/AkSqE ZzGyFoPNxrjsi0QqhK7gZFmzAQHC+G3ofzFmrBZkzoP6HnqS5ju9GeudHh8ZVDXaYRY2 Pq2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ekJhGTk6fOUeDhH74HHbt0M4kSAyKLVlhCg4tTGslIw=; b=mPaZXaElkhjghV/eMUj3a2vCJx1qAYQPXRTPMj8Xvm6c6kSqo1OPY1NZED8WKbSWyk 4pcgO2IinuZDVgDeHEnHWuLJVHxe2P+3sqvXcg50oT959Y8oi0teeknzVIF/k6ijkBYT lctdo6S9TP1KGlMBt7MmtGYDgk3ZAsSUvFNCa+pfH2s6cIzHF2+IdXE/T1BaOVaPM91a nf5UnF2mWp9PJGfMOq+t7A6RHnsxEVtO1ruHiq1+AkIyuW+qoNgsWwPYcazGPyrZ/LCY BmnqCrl9OA1vo8/i28ei0oYQ9TBFx7MRcrSAlMWAaWLoFXlOQDSqaq1w2EGccxqVZKvi 9H/Q== X-Gm-Message-State: AOAM531l3DK20p3lwTMdmcBOcx8bmVrlS9chrTamcUojmz8/J1Ahgh1k xk0UagNvGKIJFP2AyI/tYo50VUzVnce0IA== X-Google-Smtp-Source: ABdhPJwb1OdlbAj7dpEDFcBdVo8QUBE8FZ+ciXlN/D+3K/BptpLQbBz4CYkwarwqG4nks/czEG9zyg== X-Received: by 2002:a7b:cb4e:: with SMTP id v14mr7347857wmj.140.1598794203243; Sun, 30 Aug 2020 06:30:03 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id q6sm7241106wma.22.2020.08.30.06.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 06:30:02 -0700 (PDT) Date: Sun, 30 Aug 2020 14:30:00 +0100 From: "Leif Lindholm" To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" , "Chen, Gilbert" , "Schaefer, Daniel" Subject: Re: [PATCH edk2-platforms 1/1] Silicon/SiFive: fix RELEASE builds of U54 PeiCoreInfoHobLib Message-ID: <20200830133000.GE20124@vanye> References: <20200829134118.19610-1-leif@nuviainc.com> <20200830113414.GA20124@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Aug 30, 2020 at 12:59:06 +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > @@ -63,7 +64,8 @@ CreateU54E51CoreProcessorSpecificDataHob ( > > > > return EFI_INVALID_PARAMETER; > > > > } > > > > > > > > - ASSERT_EFI_ERROR (SbiGetFirmwareContext (&FirmwareContext)); > > > > + Status = SbiGetFirmwareContext (&FirmwareContext); > > > > ASSERT_EFI_ERROR > > > ASSERT_EFI_ERROR() should start at the new line. I see this macro just > > > attached to the end of Status = SbiGetFirmwareContext > > > (&FirmwareContext). Is my editor problem? > > > > INVALID URI REMOVED > > 3A__edk2.groups.io_g_devel_message_64794&d=DwIBAg&c=C5b8zRQO1mi > > GmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m= > > UkdQYKg5exPcuGmzwjtBQvaRGX5SPNiaP9ko8nTDWgQ&s=r0p7ssf1Q8Y2070 > > L71hNFsILUzkHznlm5k8mpyVeV9k&e= > > It's your editor. > Ok. > > > > > > + (Status); > > > Please add error condition check for the Status. Return > > > EFI_INVALID_PARAMETERS to caller, and also update the function header > > > for the case of @retval is EFI_INVALID_PARAMETER. Just realized that > > > we use @return in the function header instead of @retval. > > > > I agree this looks like a better way of handling the failure, but I'll leave that to > > you. This patch simply stops the current handling from breaking RELEASE > > builds. > Sure! > > Reviewed-by: Abner Chang Thanks. Pushed as 50639477fc0f. > > > > Regards, > > > > Leif > > > > > > > > Thanks for this. > > > Abner > > > > > > > DEBUG ((DEBUG_INFO, " Firmware Context is at 0x%x.\n", > > > > FirmwareContext)); > > > > FirmwareContextHartSpecific = FirmwareContext->HartSpecific[HartId]; > > > > DEBUG ((DEBUG_INFO, " Firmware Context Hart specific is at 0x%x.\n", > > > > FirmwareContextHartSpecific)); > > > > -- > > > > 2.20.1 > > >