* [PATCH v2] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull
@ 2020-09-01 1:35 Qi Zhang
2020-09-01 7:08 ` [edk2-devel] " Laszlo Ersek
0 siblings, 1 reply; 2+ messages in thread
From: Qi Zhang @ 2020-09-01 1:35 UTC (permalink / raw)
To: devel; +Cc: Qi Zhang, Jian J Wang, Hao A Wu, Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940
Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
.../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
index 61abcfa2ec..327d80f319 100644
--- a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
+++ b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
@@ -12,7 +12,7 @@
FILE_GUID = 6DFD6E9F-9278-48D8-8F45-B6CFF2C2B69C
MODULE_TYPE = UEFI_DRIVER
VERSION_STRING = 1.0
- LIBRARY_CLASS = TpmMeasurementLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
+ LIBRARY_CLASS = TpmMeasurementLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER PEIM SEC
MODULE_UNI_FILE = TpmMeasurementLibNull.uni
#
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH v2] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull
2020-09-01 1:35 [PATCH v2] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull Qi Zhang
@ 2020-09-01 7:08 ` Laszlo Ersek
0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2020-09-01 7:08 UTC (permalink / raw)
To: devel, qi1.zhang; +Cc: Jian J Wang, Hao A Wu, Jiewen Yao
On 09/01/20 03:35, Qi Zhang wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940
>
> Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
> .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> index 61abcfa2ec..327d80f319 100644
> --- a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> +++ b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> @@ -12,7 +12,7 @@
> FILE_GUID = 6DFD6E9F-9278-48D8-8F45-B6CFF2C2B69C
> MODULE_TYPE = UEFI_DRIVER
> VERSION_STRING = 1.0
> - LIBRARY_CLASS = TpmMeasurementLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
> + LIBRARY_CLASS = TpmMeasurementLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER PEIM SEC
> MODULE_UNI_FILE = TpmMeasurementLibNull.uni
>
> #
>
It tends to improve readability if we keep the "earlier" / "more
primitive" module types to the left, such as:
SEC, PEIM, DXE_*, UEFI_*
But I don't want to obsess about this:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-01 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-01 1:35 [PATCH v2] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull Qi Zhang
2020-09-01 7:08 ` [edk2-devel] " Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox