* [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg
@ 2020-09-02 7:15 Nate DeSimone
2020-09-02 7:58 ` Chiu, Chasel
2020-09-02 17:05 ` Chaganty, Rangasai V
0 siblings, 2 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-09-02 7:15 UTC (permalink / raw)
To: devel
Cc: Chasel Chiu, Rangasai V Chaganty, Deepika Kethi Reddy,
Kathappan Esakkithevar
Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg
instead of CoffeelakeSiliconBinPkg.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 2d9dcb139f..6de834565a 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
@@ -10,7 +10,7 @@
[Defines]
DEFINE PLATFORM_PACKAGE = MinPlatformPkg
DEFINE PLATFORM_SI_PACKAGE = CoffeelakeSiliconPkg
- DEFINE PLATFORM_SI_BIN_PACKAGE = CoffeelakeSiliconBinPkg
+ DEFINE PLATFORM_SI_BIN_PACKAGE = CometlakeSiliconBinPkg
DEFINE PLATFORM_FSP_BIN_PACKAGE = CometLakeFspBinPkg/CometLake1
DEFINE PLATFORM_BOARD_PACKAGE = CometlakeOpenBoardPkg
DEFINE BOARD = CometlakeURvp
@@ -39,7 +39,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg
2020-09-02 7:15 [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg Nate DeSimone
@ 2020-09-02 7:58 ` Chiu, Chasel
2020-09-02 9:37 ` Kathappan Esakkithevar
2020-09-02 17:05 ` Chaganty, Rangasai V
1 sibling, 1 reply; 4+ messages in thread
From: Chiu, Chasel @ 2020-09-02 7:58 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, Kethi Reddy, Deepika,
Esakkithevar, Kathappan
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Wednesday, September 2, 2020 3:15 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> <kathappan.esakkithevar@intel.com>
> Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of
> CometlakeSiliconBinPkg
>
> Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead of
> CoffeelakeSiliconBinPkg.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5
> +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc
> index 2d9dcb139f..6de834565a 100644
> ---
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc
> +++
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> s
> +++ c
> @@ -10,7 +10,7 @@
> [Defines]
> DEFINE PLATFORM_PACKAGE = MinPlatformPkg
> DEFINE PLATFORM_SI_PACKAGE = CoffeelakeSiliconPkg
> - DEFINE PLATFORM_SI_BIN_PACKAGE = CoffeelakeSiliconBinPkg
> + DEFINE PLATFORM_SI_BIN_PACKAGE = CometlakeSiliconBinPkg
> DEFINE PLATFORM_FSP_BIN_PACKAGE =
> CometLakeFspBinPkg/CometLake1
> DEFINE PLATFORM_BOARD_PACKAGE =
> CometlakeOpenBoardPkg
> DEFINE BOARD = CometlakeURvp
> @@ -39,7 +39,8 @@
> #
> # Include PCD configuration for this board.
> #
> - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
>
> + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> +
> !include OpenBoardPkgPcd.dsc
> !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
>
> --
> 2.27.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg
2020-09-02 7:58 ` Chiu, Chasel
@ 2020-09-02 9:37 ` Kathappan Esakkithevar
0 siblings, 0 replies; 4+ messages in thread
From: Kathappan Esakkithevar @ 2020-09-02 9:37 UTC (permalink / raw)
To: Chiu, Chasel, Desimone, Nathaniel L, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, Kethi Reddy, Deepika
Reviewed-by: Kathappan Esakkithevar <Kathappan.Esakkithevar@intel.com>
> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Wednesday, September 2, 2020 1:29 PM
> To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>;
> devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Kethi Reddy,
> Deepika <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> <kathappan.esakkithevar@intel.com>
> Subject: RE: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add
> usage of CometlakeSiliconBinPkg
>
>
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
>
> > -----Original Message-----
> > From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> > Sent: Wednesday, September 2, 2020 3:15 PM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika
> > <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> > <kathappan.esakkithevar@intel.com>
> > Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage
> > of CometlakeSiliconBinPkg
> >
> > Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead
> of
> > CoffeelakeSiliconBinPkg.
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> > Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> > Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > ---
> > .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5
> > +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> > index 2d9dcb139f..6de834565a 100644
> > ---
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> > +++
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > s
> > +++ c
> > @@ -10,7 +10,7 @@
> > [Defines]
> > DEFINE PLATFORM_PACKAGE = MinPlatformPkg
> > DEFINE PLATFORM_SI_PACKAGE = CoffeelakeSiliconPkg
> > - DEFINE PLATFORM_SI_BIN_PACKAGE = CoffeelakeSiliconBinPkg
> > + DEFINE PLATFORM_SI_BIN_PACKAGE = CometlakeSiliconBinPkg
> > DEFINE PLATFORM_FSP_BIN_PACKAGE =
> > CometLakeFspBinPkg/CometLake1
> > DEFINE PLATFORM_BOARD_PACKAGE =
> > CometlakeOpenBoardPkg
> > DEFINE BOARD = CometlakeURvp
> > @@ -39,7 +39,8 @@
> > #
> > # Include PCD configuration for this board.
> > #
> > - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> >
> > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> > +
> > !include OpenBoardPkgPcd.dsc
> > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> >
> > --
> > 2.27.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg
2020-09-02 7:15 [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg Nate DeSimone
2020-09-02 7:58 ` Chiu, Chasel
@ 2020-09-02 17:05 ` Chaganty, Rangasai V
1 sibling, 0 replies; 4+ messages in thread
From: Chaganty, Rangasai V @ 2020-09-02 17:05 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io
Cc: Chiu, Chasel, Kethi Reddy, Deepika, Esakkithevar, Kathappan
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Wednesday, September 02, 2020 12:15 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg
Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead of CoffeelakeSiliconBinPkg.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 2d9dcb139f..6de834565a 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.ds
+++ c
@@ -10,7 +10,7 @@
[Defines]
DEFINE PLATFORM_PACKAGE = MinPlatformPkg
DEFINE PLATFORM_SI_PACKAGE = CoffeelakeSiliconPkg
- DEFINE PLATFORM_SI_BIN_PACKAGE = CoffeelakeSiliconBinPkg
+ DEFINE PLATFORM_SI_BIN_PACKAGE = CometlakeSiliconBinPkg
DEFINE PLATFORM_FSP_BIN_PACKAGE = CometLakeFspBinPkg/CometLake1
DEFINE PLATFORM_BOARD_PACKAGE = CometlakeOpenBoardPkg
DEFINE BOARD = CometlakeURvp
@@ -39,7 +39,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-02 17:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-02 7:15 [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg Nate DeSimone
2020-09-02 7:58 ` Chiu, Chasel
2020-09-02 9:37 ` Kathappan Esakkithevar
2020-09-02 17:05 ` Chaganty, Rangasai V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox