* [PATCH] Revert ".pytool/EccCheck: Disable Ecc error code 10014 for open CI"
@ 2020-09-03 6:56 Zhang, Shenglei
2020-09-03 8:07 ` [edk2-devel] " Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Zhang, Shenglei @ 2020-09-03 6:56 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
This reverts commit d4e0b9607c9a64a8eff20724b2e35ea2cd5bd33f.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2951
Previously false positive Ecc issue whose error code is 10014 was reported
under Linux OS. So we disabled it in EccCheck plugin for edk2 open CI.
As the bug is fixed, we need to revert the change and re-enbale it.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.pytool/Plugin/EccCheck/EccCheck.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccCheck/EccCheck.py
index 3eaad0bf5623..eee1ff7a77b5 100644
--- a/.pytool/Plugin/EccCheck/EccCheck.py
+++ b/.pytool/Plugin/EccCheck/EccCheck.py
@@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
"10011",
"10012",
"10013",
- "10014", #need to be removed after BZ2904 is fixed
"10015",
"10016",
"10017",
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] Revert ".pytool/EccCheck: Disable Ecc error code 10014 for open CI"
2020-09-03 6:56 [PATCH] Revert ".pytool/EccCheck: Disable Ecc error code 10014 for open CI" Zhang, Shenglei
@ 2020-09-03 8:07 ` Laszlo Ersek
2020-09-03 8:17 ` 回复: " gaoliming
[not found] ` <16313822F6F48C1D.16839@groups.io>
0 siblings, 2 replies; 4+ messages in thread
From: Laszlo Ersek @ 2020-09-03 8:07 UTC (permalink / raw)
To: devel, shenglei.zhang
Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
On 09/03/20 08:56, Zhang, Shenglei wrote:
> This reverts commit d4e0b9607c9a64a8eff20724b2e35ea2cd5bd33f.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2951
> Previously false positive Ecc issue whose error code is 10014 was reported
> under Linux OS. So we disabled it in EccCheck plugin for edk2 open CI.
> As the bug is fixed, we need to revert the change and re-enbale it.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .pytool/Plugin/EccCheck/EccCheck.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccCheck/EccCheck.py
> index 3eaad0bf5623..eee1ff7a77b5 100644
> --- a/.pytool/Plugin/EccCheck/EccCheck.py
> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
> "10011",
> "10012",
> "10013",
> - "10014", #need to be removed after BZ2904 is fixed
> "10015",
> "10016",
> "10017",
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Liming, can you please merge this? If so, please fix a typo in the
commit message: "re-enbale" should be "re-enable".
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH] Revert ".pytool/EccCheck: Disable Ecc error code 10014 for open CI"
2020-09-03 8:07 ` [edk2-devel] " Laszlo Ersek
@ 2020-09-03 8:17 ` gaoliming
[not found] ` <16313822F6F48C1D.16839@groups.io>
1 sibling, 0 replies; 4+ messages in thread
From: gaoliming @ 2020-09-03 8:17 UTC (permalink / raw)
To: devel, lersek, shenglei.zhang
Cc: 'Sean Brogan', 'Bret Barkelew',
'Michael D Kinney'
Laszlo:
Thanks! I will merge it. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+64998+4905953+8761045@groups.io
> <bounce+27952+64998+4905953+8761045@groups.io> 代表 Laszlo Ersek
> 发送时间: 2020年9月3日 16:08
> 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com
> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> 主题: Re: [edk2-devel] [PATCH] Revert ".pytool/EccCheck: Disable Ecc error
> code 10014 for open CI"
>
> On 09/03/20 08:56, Zhang, Shenglei wrote:
> > This reverts commit d4e0b9607c9a64a8eff20724b2e35ea2cd5bd33f.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2951
> > Previously false positive Ecc issue whose error code is 10014 was reported
> > under Linux OS. So we disabled it in EccCheck plugin for edk2 open CI.
> > As the bug is fixed, we need to revert the change and re-enbale it.
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> > .pytool/Plugin/EccCheck/EccCheck.py | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> b/.pytool/Plugin/EccCheck/EccCheck.py
> > index 3eaad0bf5623..eee1ff7a77b5 100644
> > --- a/.pytool/Plugin/EccCheck/EccCheck.py
> > +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> > @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
> > "10011",
> > "10012",
> > "10013",
> > - "10014", #need to be removed after
> BZ2904 is fixed
> > "10015",
> > "10016",
> > "10017",
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Liming, can you please merge this? If so, please fix a typo in the
> commit message: "re-enbale" should be "re-enable".
>
> Thanks!
> Laszlo
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH] Revert ".pytool/EccCheck: Disable Ecc error code 10014 for open CI"
[not found] ` <16313822F6F48C1D.16839@groups.io>
@ 2020-09-03 14:52 ` gaoliming
0 siblings, 0 replies; 4+ messages in thread
From: gaoliming @ 2020-09-03 14:52 UTC (permalink / raw)
To: devel, gaoliming, lersek, shenglei.zhang
Cc: 'Sean Brogan', 'Bret Barkelew',
'Michael D Kinney'
Merge @06dc822d045c2bb42e497487935485302486e151
> -----邮件原件-----
> 发件人: bounce+27952+64999+4905953+8761045@groups.io
> <bounce+27952+64999+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2020年9月3日 16:18
> 收件人: devel@edk2.groups.io; lersek@redhat.com;
> shenglei.zhang@intel.com
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; 'Michael D Kinney'
> <michael.d.kinney@intel.com>
> 主题: 回复: [edk2-devel] [PATCH] Revert ".pytool/EccCheck: Disable Ecc
> error code 10014 for open CI"
>
> Laszlo:
> Thanks! I will merge it. Reviewed-by: Liming Gao
> <gaoliming@byosoft.com.cn>
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+64998+4905953+8761045@groups.io
> > <bounce+27952+64998+4905953+8761045@groups.io> 代表 Laszlo Ersek
> > 发送时间: 2020年9月3日 16:08
> > 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com
> > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: Re: [edk2-devel] [PATCH] Revert ".pytool/EccCheck: Disable Ecc
> error
> > code 10014 for open CI"
> >
> > On 09/03/20 08:56, Zhang, Shenglei wrote:
> > > This reverts commit d4e0b9607c9a64a8eff20724b2e35ea2cd5bd33f.
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2951
> > > Previously false positive Ecc issue whose error code is 10014 was reported
> > > under Linux OS. So we disabled it in EccCheck plugin for edk2 open CI.
> > > As the bug is fixed, we need to revert the change and re-enbale it.
> > >
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > > ---
> > > .pytool/Plugin/EccCheck/EccCheck.py | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> > b/.pytool/Plugin/EccCheck/EccCheck.py
> > > index 3eaad0bf5623..eee1ff7a77b5 100644
> > > --- a/.pytool/Plugin/EccCheck/EccCheck.py
> > > +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> > > @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
> > > "10011",
> > > "10012",
> > > "10013",
> > > - "10014", #need to be removed after
> > BZ2904 is fixed
> > > "10015",
> > > "10016",
> > > "10017",
> > >
> >
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> >
> > Liming, can you please merge this? If so, please fix a typo in the
> > commit message: "re-enbale" should be "re-enable".
> >
> > Thanks!
> > Laszlo
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-03 14:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-03 6:56 [PATCH] Revert ".pytool/EccCheck: Disable Ecc error code 10014 for open CI" Zhang, Shenglei
2020-09-03 8:07 ` [edk2-devel] " Laszlo Ersek
2020-09-03 8:17 ` 回复: " gaoliming
[not found] ` <16313822F6F48C1D.16839@groups.io>
2020-09-03 14:52 ` gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox