From: D Scott Phillips <scott@scott.ph>
To: devel@edk2.groups.io
Subject: [PATCH] NetworkPkg/HttpDxe: Clear TlsChildHandle during cleanup
Date: Sat, 05 Sep 2020 01:15:44 +0000 [thread overview]
Message-ID: <20200905011540.6847-1-scott@scott.ph> (raw)
From: D Scott Phillips <d.scott.phillips@amperecomputing.com>
Leaving TlsChildHandle with the stale handle causes later use of https
with the http instance to incorrectly skip tls reconfiguration, use
the stale handle, and eventually call a garbage function pointer.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1917
Signed-off-by: D Scott Phillips <d.scott.phillips@amperecomputing.com>
---
NetworkPkg/HttpDxe/HttpProto.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c
index 3c7c6ff9f0..afc7db5a72 100644
--- a/NetworkPkg/HttpDxe/HttpProto.c
+++ b/NetworkPkg/HttpDxe/HttpProto.c
@@ -873,6 +873,7 @@ HttpCleanProtocol (
// Destroy the TLS instance.
//
HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->TlsChildHandle);
+ HttpInstance->TlsChildHandle = NULL;
}
if (HttpInstance->Tcp4ChildHandle != NULL) {
--
2.26.2
next reply other threads:[~2020-09-05 1:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 1:15 D Scott Phillips [this message]
2020-09-07 11:33 ` [edk2-devel] [PATCH] NetworkPkg/HttpDxe: Clear TlsChildHandle during cleanup Laszlo Ersek
2020-09-08 4:50 ` D Scott Phillips
2020-09-15 13:01 ` Maciej Rabeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200905011540.6847-1-scott@scott.ph \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox