public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jeremy Linton" <jeremy.linton@arm.com>
To: devel@edk2.groups.io
Cc: leif@nuviainc.com, pete@akeo.ie, awarkentin@vmware.com,
	ard.biesheuvel@arm.com, Jeremy Linton <jeremy.linton@arm.com>
Subject: [PATCH] Platform/RaspberryPi4: Correct thermal offset
Date: Wed,  9 Sep 2020 18:11:00 -0500	[thread overview]
Message-ID: <20200909231100.213015-1-jeremy.linton@arm.com> (raw)

The current mainline DT indicates that the thermal offset
on the rpi is 410040 rather than the 419949 being used.
This means our temp calculation is offset nearly 10C higher
when running in ACPI mode vs DT.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
index 2b9e8211cf..d116f965e1 100644
--- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl
+++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
@@ -269,7 +269,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI", 2)
           Field (TEMS, DWordAcc, NoLock, Preserve) {
             TMPS, 32
           }
-          return (((419949 - ((TMPS & 0x3ff) * 487)) / 100) + 2732);
+          return (((410040 - ((TMPS & 0x3ff) * 487)) / 100) + 2732);
         }
         Method (_SCP, 3) { }               // receive cooling policy from OS
 
-- 
2.13.7


             reply	other threads:[~2020-09-09 23:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 23:11 Jeremy Linton [this message]
2020-09-11 18:13 ` [PATCH] Platform/RaspberryPi4: Correct thermal offset Pete Batard
2020-09-11 19:48   ` Jeremy Linton
2020-10-22 13:45 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909231100.213015-1-jeremy.linton@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox