From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.21542.1599928831134377693 for ; Sat, 12 Sep 2020 09:40:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=vHJIR9ni; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id z9so7471838wmk.1 for ; Sat, 12 Sep 2020 09:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=50I2XKsKtcZWX0h8CA9VnWrdPP7njxM2luGzd4k1pas=; b=vHJIR9ni+qCpRB2qcgntXoaT+KEAhYpwUTQ/JcbWRAKMydyL0PP3IpUFD9oWksWqZ8 zTThxEZ5sbzgXUlvtIVcO9OkkwBynbt9dBAzWOHM4FUc980qsWZtFanQmhFUtEf+wdpJ G003xIhmUb/dFZHDA4jaJ98j5mDiHIeu+iSMeKtKeRjBOvyOUDunjUK5xWpNFo9zcNQE HA0PPpc8pjtg6SYImn20D7WVgh9oEjyz3o2wKvzCqPGsjTfrqRratkUEhKYXTtaBwyrN VPo2GlCiF4IdhDQ8wHsrWsevWIephnTUH/YDdi1Y6LHxPeL917mt8UPwtDHVrsEwgLtN eF5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=50I2XKsKtcZWX0h8CA9VnWrdPP7njxM2luGzd4k1pas=; b=T1Y0ebIo3oQCHT2yMdV0oSTFrZZ1mC79TmCDj5XasPGOfIA0uPuYYdXkQWOCTSzaOW iEePWEUpg7zXbgundXZQLiMubQjzwQy5kbKGjYD2gngDLvsFoxM1kU5HpQPFge+6hZp3 xDHTC2rP5lrFhOIgaGGXZ+j8nWMJdxHRxskjxSovw54VuxGjG/jgXD/36jZi/y6ZvM9S QG3PTknWoPp4pqOK8tvY6QqWwOicJs6+fm5Hu/vdgXSX6ycE578vuQ7syeviR96tiDXb a4J4PTSrgIVucXf8P8H/TFoK9JvXsGkOAKTJoElmtTgYnnM7HpAjek814E3e2AJIVjub TWyw== X-Gm-Message-State: AOAM532JFx9Mm9l1MRv7OEU0mC5waGlTNh8AAimSvusMRRbTUyf7wxi5 ZkO6mmOQeFacHmhfmdiKdguexu13h2Sc9L+nvK7gNN7lRVkWmZBdygSuus8UD3uDG8GZ/nTkBmB cdnl4YTWQkbaF1ITQZiatVcFOLgMshCdMQxmBDT28DUHpnqrRchzFchKpZmd3T6UEI9ng X-Google-Smtp-Source: ABdhPJwGkgnLZKlVzqg6MIgbKmkf2vuHyo5bgm0YT4uNmtlLdegQVcKTGmna1YfO3x5dsuDGOLm8zA== X-Received: by 2002:a1c:e389:: with SMTP id a131mr7701095wmh.181.1599928829270; Sat, 12 Sep 2020 09:40:29 -0700 (PDT) Return-Path: Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id i11sm10950893wre.32.2020.09.12.09.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2020 09:40:28 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [PATCH 1/1] OvmfPkg: drop redundant VendorID check in VirtioMmioDeviceLib Date: Sat, 12 Sep 2020 17:40:22 +0100 Message-Id: <20200912164022.5048-1-leif@nuviainc.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is a DEBUG warning printout in VirtioMmioDeviceLib if the current device's VendorID does not match the traditional 16-bit Red Hat PCIe vendor ID used with virtio-pci. The virtio-mmio vendor ID is 32-bit and has no connection to the PCIe registry. Most specifically, this causes a bunch of noise when booting an AArch64 QEMU platform, since QEMU's virtio-mmio implementation used 'QEMU' as the vendor ID: VirtioMmioInit: Warning: The VendorId (0x554D4551) does not match the VirtIo VendorId (0x1AF4). Drop the warning message. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Leif Lindholm --- .../VirtioMmioDeviceLib/VirtioMmioDevice.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c index 2f20272c1445..6dbbba008c75 100644 --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c @@ -58,7 +58,6 @@ VirtioMmioInit ( ) { UINT32 MagicValue; - UINT32 VendorId; UINT32 Version; // @@ -84,20 +83,6 @@ VirtioMmioInit ( return EFI_UNSUPPORTED; } - // - // Double-check MMIO-specific values - // - VendorId = VIRTIO_CFG_READ (Device, VIRTIO_MMIO_OFFSET_VENDOR_ID); - if (VendorId != VIRTIO_VENDOR_ID) { - // - // The ARM Base and Foundation Models do not report a valid VirtIo VendorId. - // They return a value of 0x0 for the VendorId. - // - DEBUG((DEBUG_WARN, "VirtioMmioInit: Warning: The VendorId (0x%X) does not " - "match the VirtIo VendorId (0x%X).\n", - VendorId, VIRTIO_VENDOR_ID)); - } - return EFI_SUCCESS; } -- 2.20.1