From: Jeff.Booher-Kaeding@arm.com
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
Leif Lindholm <leif@nuviainc.com>, Pete Batard <pete@akeo.ie>
Subject: [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4
Date: Mon, 14 Sep 2020 16:32:30 -0500 [thread overview]
Message-ID: <20200914213230.78282-1-jeff.booher-kaeding@arm.com> (raw)
Updated the pinout to match the Pi4 datasheet, tested with the RPi4, Pi3 Datasheet has same pinout.
Signed-off-by: Jeff Booher-Kaeding <Jeff.booher-kaeding@arm.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
index ac1004fe1836..6e793efb8227 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
@@ -502,7 +502,7 @@ ApplyVariables (
* 1 VREF N/A 1
* 3 nTRST GPIO22 ALT4 15
* 4 GND N/A 9
- * 5 TDI GPIO4 ALT5 7
+ * 5 TDI GPIO26 ALT4 37
* 7 TMS GPIO27 ALT4 13
* 9 TCK GPIO25 ALT4 22
* 11 RTCK GPIO23 ALT4 16
@@ -510,14 +510,14 @@ ApplyVariables (
*/
if (PcdGet32 (PcdDebugEnableJTAG)) {
GpioPinFuncSet (22, GPIO_FSEL_ALT4);
- GpioPinFuncSet (4, GPIO_FSEL_ALT5);
+ GpioPinFuncSet (26, GPIO_FSEL_ALT4);
GpioPinFuncSet (27, GPIO_FSEL_ALT4);
GpioPinFuncSet (25, GPIO_FSEL_ALT4);
GpioPinFuncSet (23, GPIO_FSEL_ALT4);
GpioPinFuncSet (24, GPIO_FSEL_ALT4);
} else {
GpioPinFuncSet (22, GPIO_FSEL_INPUT);
- GpioPinFuncSet (4, GPIO_FSEL_INPUT);
+ GpioPinFuncSet (26, GPIO_FSEL_INPUT);
GpioPinFuncSet (27, GPIO_FSEL_INPUT);
GpioPinFuncSet (25, GPIO_FSEL_INPUT);
GpioPinFuncSet (23, GPIO_FSEL_INPUT);
--
2.24.3 (Apple Git-128)
next reply other threads:[~2020-09-14 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 21:32 Jeff.Booher-Kaeding [this message]
2020-09-15 12:26 ` [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4 Pete Batard
2020-09-21 20:01 ` Andrei Warkentin
2020-09-29 14:01 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-10-05 12:07 ` Pete Batard
2020-10-05 14:30 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914213230.78282-1-jeff.booher-kaeding@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox