From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.71363.1600119152995825665 for ; Mon, 14 Sep 2020 14:32:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeff.booher-kaeding@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C990030E; Mon, 14 Sep 2020 14:32:31 -0700 (PDT) Received: from C02YV445LVDL.arm.com (unknown [10.122.4.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 87D7E3F73B; Mon, 14 Sep 2020 14:32:31 -0700 (PDT) From: Jeff.Booher-Kaeding@arm.com To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Pete Batard Subject: [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4 Date: Mon, 14 Sep 2020 16:32:30 -0500 Message-Id: <20200914213230.78282-1-jeff.booher-kaeding@arm.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Updated the pinout to match the Pi4 datasheet, tested with the RPi4, Pi3 Da= tasheet has same pinout. Signed-off-by: Jeff Booher-Kaeding Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pete Batard --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index ac1004fe1836..6e793efb8227 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c @@ -502,7 +502,7 @@ ApplyVariables ( * 1 VREF N/A 1=0D * 3 nTRST GPIO22 ALT4 15=0D * 4 GND N/A 9=0D - * 5 TDI GPIO4 ALT5 7=0D + * 5 TDI GPIO26 ALT4 37=0D * 7 TMS GPIO27 ALT4 13=0D * 9 TCK GPIO25 ALT4 22=0D * 11 RTCK GPIO23 ALT4 16=0D @@ -510,14 +510,14 @@ ApplyVariables ( */=0D if (PcdGet32 (PcdDebugEnableJTAG)) {=0D GpioPinFuncSet (22, GPIO_FSEL_ALT4);=0D - GpioPinFuncSet (4, GPIO_FSEL_ALT5);=0D + GpioPinFuncSet (26, GPIO_FSEL_ALT4);=0D GpioPinFuncSet (27, GPIO_FSEL_ALT4);=0D GpioPinFuncSet (25, GPIO_FSEL_ALT4);=0D GpioPinFuncSet (23, GPIO_FSEL_ALT4);=0D GpioPinFuncSet (24, GPIO_FSEL_ALT4);=0D } else {=0D GpioPinFuncSet (22, GPIO_FSEL_INPUT);=0D - GpioPinFuncSet (4, GPIO_FSEL_INPUT);=0D + GpioPinFuncSet (26, GPIO_FSEL_INPUT);=0D GpioPinFuncSet (27, GPIO_FSEL_INPUT);=0D GpioPinFuncSet (25, GPIO_FSEL_INPUT);=0D GpioPinFuncSet (23, GPIO_FSEL_INPUT);=0D --=20 2.24.3 (Apple Git-128)