public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <Alexei.Fedorov@arm.com>,
	<Pierre.Gondois@arm.com>, <Matteo.Carlini@arm.com>,
	<Ben.Adderson@arm.com>, <nd@arm.com>
Subject: [PATCH v1 0/7] DynamicTablesPkg: Fix assert ordering and ECC reported issues
Date: Tue, 22 Sep 2020 15:42:28 +0100	[thread overview]
Message-ID: <20200922144235.76292-1-sami.mujawar@arm.com> (raw)

This patch series fixes an assert ordering issue and the following
issues reported by the ECC tool.
  - [9002]  The function headers should follow Doxygen special
            documentation blocks in section 2.3.5 in Comment,
              - <@param [in]> does NOT have [in, out]
              - does NOT have tail **/
  - [1008]  File has invalid Non-ACSII char.
  - [5007]  There should be no initialization of a variable as part of
              its declaration Variable Name.
  - Changes the AML_DEBUG_STR() macro to AML_OPCODE_DEF().
 
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/1423_fix_assert_ordering_v1

Sami Mujawar (7):
  DynamicTablesPkg: Fix order of assert checks
  DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error
  DynamicTablesPkg: AcpiSratLibArm fix ECC error
  DynamicTablesPkg: AmlLib fix ECC errors
  DynamicTablesPkg: AmlLib\AmlDbgPrint fix ECC error
  DynamicTablesPkg: AmlEncoding change debug macro
  DynamicTablesPkg: SsdtSerialPortFixupLib fix ECC errors

 DynamicTablesPkg/DynamicTablesPkg.ci.yaml                                            |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c                     |   4 +-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c |  10 +-
 DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c                     |  10 +-
 DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.h                     |  40 ++-
 DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.c                             | 304 ++++++++++----------
 DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.h                             |   4 +-
 DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c                          |   4 +-
 DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c              |   2 +-
 DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c                      |   6 +-
 DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c                   |   8 +-
 DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c                      |  16 +-
 DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c                            |  20 +-
 DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c                |   4 +-
 DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c                            |   4 +-
 DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c                                |   6 +-
 DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c                                |   2 +-
 DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c      |  18 +-
 18 files changed, 246 insertions(+), 217 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


             reply	other threads:[~2020-09-22 14:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 14:42 Sami Mujawar [this message]
2020-09-22 14:42 ` [PATCH v1 1/7] DynamicTablesPkg: Fix order of assert checks Sami Mujawar
2020-09-22 15:06   ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 2/7] DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error Sami Mujawar
2020-09-22 15:07   ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 3/7] DynamicTablesPkg: AcpiSratLibArm " Sami Mujawar
2020-09-22 15:07   ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 4/7] DynamicTablesPkg: AmlLib fix ECC errors Sami Mujawar
2020-09-22 15:07   ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 5/7] DynamicTablesPkg: AmlLib\AmlDbgPrint fix ECC error Sami Mujawar
2020-09-22 15:07   ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 6/7] DynamicTablesPkg: AmlEncoding change debug macro Sami Mujawar
2020-09-22 15:07   ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 7/7] DynamicTablesPkg: SsdtSerialPortFixupLib fix ECC errors Sami Mujawar
2020-09-22 15:08   ` [edk2-devel] " Alexei Fedorov
2020-09-22 15:08 ` [edk2-devel] [PATCH v1 0/7] DynamicTablesPkg: Fix assert ordering and ECC reported issues Alexei Fedorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922144235.76292-1-sami.mujawar@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox