From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.76]) by mx.groups.io with SMTP id smtpd.web11.143.1600785803622432292 for ; Tue, 22 Sep 2020 07:43:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=4ej72stq; spf=pass (domain: arm.com, ip: 40.107.5.76, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lug2UjTeltpRolcjpBWV2rV07hw+w/j2KGGy8qyk+jk=; b=4ej72stq8rWCnXJo6IxOGEx7y5/QELqvi/d1wStUU42h2IEFpi3j+7npxpW7kebj0y5qiFZV4dWx+jVOPh5/hg3rfaRIHiy/26ZbiOmBBz6sSGIR/rfitAlQDzF19vmHc4Ld8oUrlNSTj6cey4xmVg5jQW+4+dgWBJxhX4BWbl8= Received: from MR2P264CA0088.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::28) by AM8PR08MB5588.eurprd08.prod.outlook.com (2603:10a6:20b:1d4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Tue, 22 Sep 2020 14:43:20 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:32:cafe::67) by MR2P264CA0088.outlook.office365.com (2603:10a6:500:32::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11 via Frontend Transport; Tue, 22 Sep 2020 14:43:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:20 +0000 Received: ("Tessian outbound 7a6fb63c1e64:v64"); Tue, 22 Sep 2020 14:43:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 55abef63e27817d8 X-CR-MTA-TID: 64aa7808 Received: from f27f2b23cc2e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A7E48F34-08EA-4B09-9A70-F295C200F037.1; Tue, 22 Sep 2020 14:42:42 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f27f2b23cc2e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dd1KUO4Ry3fRDASw+0Dsyzzfm255NPfldzJUC6bXWdNQDnkiPSUYWapywDKwZ2fXMMwPllblb+Irh4bfORNG+MziuITWm5KghyLK4TGZmdPFQdxKL0ed9WtSLM9v0FVBgz3B6YWiiSZIxLbvSWac07rOZQqxyUQV/ikg/Ov46GaCPzvzP9Uh3Pi9FyNFfB1oo8MnGabtC3w3I+clYf1BTbqYPlJ4EXV5x86zEaYH6TiGSw9TmIgBi9XCbxhYhS1or8TNM9veoKBQEoyrNP5flyahtaZfmMTjwkp64P9MA8DUiLE2gCWBtrg6gCLni1WqVmyds1RTOQtROcCaIFhWnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lug2UjTeltpRolcjpBWV2rV07hw+w/j2KGGy8qyk+jk=; b=Kh0gTXzKPz3S3UFVK0244PJb/YTCc+cSoat8Wl+GMSWgwWwxgX64Rcn1DeeSSlW25mTTnaVRDREF9v2Ayff7AALl8Z1Q1caqKqqbUmM8nzJttaCj9dGnSgaFihWj+31FlvIWI9woLFYVSVBZ5IO6PrWNvah0z0DtTyAzoVjCFgp9hs9qeb8iNdu/lQ+NBEB16T6jhnE62oxZvfSmi3ZReYBqSbekJGgt+TcjH5f4487vqsnRZabfpNLoXeUhzgsafw5VBzin3CDttoCgbmsNGwphri5vkzViSrzT1dAJo5Bo90+T+oJIGab5SMaw7IoHnuHNc2pF4b32nRuEx6Au6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lug2UjTeltpRolcjpBWV2rV07hw+w/j2KGGy8qyk+jk=; b=4ej72stq8rWCnXJo6IxOGEx7y5/QELqvi/d1wStUU42h2IEFpi3j+7npxpW7kebj0y5qiFZV4dWx+jVOPh5/hg3rfaRIHiy/26ZbiOmBBz6sSGIR/rfitAlQDzF19vmHc4Ld8oUrlNSTj6cey4xmVg5jQW+4+dgWBJxhX4BWbl8= Received: from DB6PR07CA0098.eurprd07.prod.outlook.com (2603:10a6:6:2c::12) by VE1PR08MB4941.eurprd08.prod.outlook.com (2603:10a6:803:112::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13; Tue, 22 Sep 2020 14:42:40 +0000 Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::d) by DB6PR07CA0098.outlook.office365.com (2603:10a6:6:2c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:40 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:36 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Tue, 22 Sep 2020 14:42:36 +0000 Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:35 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [PATCH v1 0/7] DynamicTablesPkg: Fix assert ordering and ECC reported issues Date: Tue, 22 Sep 2020 15:42:28 +0100 Message-ID: <20200922144235.76292-1-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4f3d280-86f5-4c0e-206b-08d85f05d996 X-MS-TrafficTypeDiagnostic: VE1PR08MB4941:|AM8PR08MB5588: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OWQHTj8y/9kzQ6s3e/Ck3RjkMJosl1icYuf5tIPfpIkXLRzv1Ht07MCkakCzXzm1ymAuH3aAFwK698ReKbyXwOYBz/zPwl35bl4FHKcZyHbNozgqF8QUBTbSarY+bohaxSo8uYZmIlc5xiquOqMx4udR+uTnfy63JaKpVi2KcABwzJopmh4MKoBjYJgn2I8VmJBEJCOilg5g8pWwVobO9FRF+CDQBDSEEpzvZbmSDUdSU6yHNwE8JD0HMmFPepqqjnw2FBJ6NlTyX7dPa458j9L4u3PgsybfM4RBfrftvnMHaFIUjtBoigKQyBpSKw+YsKAevrVc1c9VkBL1XxF8x6WK3gMREEfb9CIPMnANQ4NufLbJwgid00hSlcnZO/kPemmPK0jn9NK9Ps1XKQA3ngta8Xq/1GCPelHH+RRQ1zO/UGIPPzU/X92q/oEeKYUguFD/ta+jRM1oHesRNjWSyBlGMM42ytlHDbzWPPxO62s= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(39840400004)(396003)(376002)(136003)(346002)(46966005)(966005)(4326008)(186003)(6916009)(6666004)(83380400001)(70206006)(70586007)(5660300002)(7696005)(82310400003)(8676002)(44832011)(1076003)(86362001)(47076004)(54906003)(81166007)(316002)(356005)(426003)(478600001)(8936002)(2616005)(336012)(26005)(36756003)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4941 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9618f387-f987-4b48-4b83-08d85f05c208 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tAMr0m4oUPgbq7Y6gxo9cotnURLgpBPIvWpfKvGYNUX0k5GFGUAxewPUy0ZrWxECcD+q3J8DcBFACXK+VnwBgCuJ8MPCslhQgFJtwgk+m20Z4GVuMQ+nhaWY6sAdLqsTeXV5ZMDO6KjfefaQCF1Pd7LtV2U4N5fN1/ni4YFAjL9XMaSHHcvayVR8PBixdIDPs+1cRDZ3RfnUTzNbOhHgEXHd00opzADpT4aBAxhbKn/ZBYr4mTXCOsCzC+QuwiajNvedohpjEcpdkdmNBBUzm4kQZTWzlI9vhe+K7FNGXfAQRB2r2hWdMdNHKhqHNrQVyoe66vEGB8W/ABI1cYFU4+gSq7GPOFZzq2yzPIOcFj4ExqBLkNo2dHDlf7Dz6P6DeihswQiVBRcO506WgVkOkxrS7ZmPuAsrXTKK7LwLwgMTNHUT3TxGXHjDF3QiKupz0VlxY4bVbTS1iI0PUZCeLtuKVpFyJj7+d83Fthco+JvY4YwnILkpfve4o99/xRuO3JriEvRE3gx2cb7e1AlvhQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(346002)(39840400004)(396003)(136003)(46966005)(1076003)(8936002)(36756003)(6666004)(8676002)(5660300002)(2906002)(70206006)(82310400003)(44832011)(70586007)(2616005)(966005)(478600001)(7696005)(426003)(83380400001)(86362001)(316002)(81166007)(47076004)(36906005)(26005)(54906003)(186003)(336012)(4326008)(6916009);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:20.1765 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4f3d280-86f5-4c0e-206b-08d85f05d996 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5588 Content-Type: text/plain This patch series fixes an assert ordering issue and the following issues reported by the ECC tool. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 in Comment, - <@param [in]> does NOT have [in, out] - does NOT have tail **/ - [1008] File has invalid Non-ACSII char. - [5007] There should be no initialization of a variable as part of its declaration Variable Name. - Changes the AML_DEBUG_STR() macro to AML_OPCODE_DEF(). The changes can be seen at: https://github.com/samimujawar/edk2/tree/1423_fix_assert_ordering_v1 Sami Mujawar (7): DynamicTablesPkg: Fix order of assert checks DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error DynamicTablesPkg: AcpiSratLibArm fix ECC error DynamicTablesPkg: AmlLib fix ECC errors DynamicTablesPkg: AmlLib\AmlDbgPrint fix ECC error DynamicTablesPkg: AmlEncoding change debug macro DynamicTablesPkg: SsdtSerialPortFixupLib fix ECC errors DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 1 + DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 4 +- DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 10 +- DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c | 10 +- DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.h | 40 ++- DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.c | 304 ++++++++++---------- DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.h | 4 +- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 +- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c | 6 +- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c | 8 +- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c | 16 +- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 20 +- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c | 4 +- DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c | 4 +- DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c | 6 +- DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c | 2 +- DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c | 18 +- 18 files changed, 246 insertions(+), 217 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'