From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <Alexei.Fedorov@arm.com>,
<Pierre.Gondois@arm.com>, <Matteo.Carlini@arm.com>,
<Ben.Adderson@arm.com>, <nd@arm.com>
Subject: [PATCH v1 2/7] DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error
Date: Tue, 22 Sep 2020 15:42:30 +0100 [thread overview]
Message-ID: <20200922144235.76292-3-sami.mujawar@arm.com> (raw)
In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com>
Fix the following ECC reported error in SsdtSerialPortLibArm.
- [5007] There should be no initialization of a variable as part of
its declaration Variable Name.
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c
index a705d771be1a2d59c4b0f645269eb838ff605a1a..6a1e7487dfaf4ceb2e074e52cef2fc30bfce7152 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c
@@ -171,7 +171,7 @@ BuildSsdtSerialPortTableEx (
CM_ARM_SERIAL_PORT_INFO * SerialPortInfo;
UINT32 SerialPortCount;
UINTN Index;
- CHAR8 NewName[] = "COMx";
+ CHAR8 NewName[5];
UINT64 Uid;
EFI_ACPI_DESCRIPTION_HEADER ** TableList;
@@ -243,6 +243,10 @@ BuildSsdtSerialPortTableEx (
// can be done in case of failure.
*Table = TableList;
+ NewName[0] = 'C';
+ NewName[1] = 'O';
+ NewName[2] = 'M';
+ NewName[4] = '\0';
for (Index = 0; Index < SerialPortCount; Index++) {
Uid = SERIAL_PORT_START_UID + Index;
NewName[3] = AsciiFromHex ((UINT8)(Uid));
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2020-09-22 14:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 14:42 [PATCH v1 0/7] DynamicTablesPkg: Fix assert ordering and ECC reported issues Sami Mujawar
2020-09-22 14:42 ` [PATCH v1 1/7] DynamicTablesPkg: Fix order of assert checks Sami Mujawar
2020-09-22 15:06 ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` Sami Mujawar [this message]
2020-09-22 15:07 ` [edk2-devel] [PATCH v1 2/7] DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 3/7] DynamicTablesPkg: AcpiSratLibArm " Sami Mujawar
2020-09-22 15:07 ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 4/7] DynamicTablesPkg: AmlLib fix ECC errors Sami Mujawar
2020-09-22 15:07 ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 5/7] DynamicTablesPkg: AmlLib\AmlDbgPrint fix ECC error Sami Mujawar
2020-09-22 15:07 ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 6/7] DynamicTablesPkg: AmlEncoding change debug macro Sami Mujawar
2020-09-22 15:07 ` [edk2-devel] " Alexei Fedorov
2020-09-22 14:42 ` [PATCH v1 7/7] DynamicTablesPkg: SsdtSerialPortFixupLib fix ECC errors Sami Mujawar
2020-09-22 15:08 ` [edk2-devel] " Alexei Fedorov
2020-09-22 15:08 ` [edk2-devel] [PATCH v1 0/7] DynamicTablesPkg: Fix assert ordering and ECC reported issues Alexei Fedorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922144235.76292-3-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox